[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2023-09-07 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-29 Thread Felix Ernst
felixernst added a comment.


  In D24223#675682 , @Boxie wrote:
  
  > if you are coming from mac and choose the apple theme, you are expecting it 
to work like the apple environment, from shortcut keys, specific placement of 
items and look/feel of various components - even apps like dolphin not looking 
the same would be jarring.
  
  
  You are certainly picturing a more demanding and nitpicky user than I am but 
those do exist. I wonder where those expectations you mention would be coming 
from but I agree that if an appleĀ® fan installs Plasma with the preconception 
it can be made to be exactly like macOS they'll be in for a reality check. I 
don't really think the existence of a "Cupertino/Pear/Raincoat" theme would 
worsen that problem though. That's what I meant when I said "I don't think 
users actually expect that unless we market it as such."
  Anyways, going with "some layouts using existing plasma stuff" is alright as 
well even though this feels like we would be needlessly limiting us from 
offering layouts that are tried and tested.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: felixernst, Boxie, wstephenson, davidre, LeGast00n, enriqueme, mart, 
fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, Orage, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra


D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-28 Thread Felix Ernst
felixernst added a comment.


  In D24223#675589 , @Boxie wrote:
  
  > As others have mentioned - Let's not mimic other desktop environments 
(there are plenty of dragons and devils hiding there).
  
  
  Are there really? If we really aren't confident enough in these new global 
themes I would consider adding "(experimental)" to their name. Even then I 
think that shipping any additional layouts by default will send the right 
message. I don't think it really matters if those additional layouts mimic 
other DEs/OSs or not but for simplicities sake and because in this case I see 
value in showing off I would encourage the current approach.
  
  Some more thoughts because I (perhaps baselessly) feel like progress on this 
feature was held back by doubts: If I came from another OS and saw the option 
to fundamentally change the layout with two clicks I wouldn't actually be 
expecting it to work. Now this is Plasma and we want our most powerful features 
to work flawlessly as well but let's keep in mind that even a buggy attempt is 
more than others have attempted.
  I also wouldn't worry too much about the theme not resembling an existing 
DE/OS close enough. I don't think users actually expect that unless we market 
it as such. On the contrary marketing has told users that iPhones from Androids 
from Windows from Macs are fundamentally different. So yea, picture me cheering 
"LGTM" from the audience.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: felixernst, Boxie, wstephenson, davidre, LeGast00n, enriqueme, mart, 
fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, Orage, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra


D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-09 Thread Felix Ernst
felixernst added a comment.


  +1 to this change.
  Having the exact same panel and buttons on the left instead of at the bottom 
is a change that IMO even the most computer-illiterate Windows user should have 
no major trouble adapting to. Anyone else can change the panel position if they 
want to. In any case I can't picture a scenario in which it would stop someone 
from getting work done so I wouldn't be too worried about changing this default.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: felixernst, davidedmundson, ahiemstra, broulik, filipf, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-02 Thread Felix Ernst
felixernst added a comment.


  Current (?) one for comparison (from Kubuntu 18.04 since the one from Neon 
Unstable crashes for me)
  F7308896: Screenshot_20190902_143551.png 

  I feel like there was a lot of thought put into the current design of the 
dashboard and the search field in particular:
  
  - It does fit the style of having different logical parts of the dashboard 
purely divided by white space (and not by borders, lines).
  - It makes very clear that typing will trigger the search while in your 
screenshot it looks like the search field doesn't have focus and typing might 
not trigger the search.
  - In addition the size of the elements of the dashboard should loosely 
correspond to their importance.  The search is arguably the most important 
feature of the dashboard. The way you changed it it seems a bit too minor to me.
  
  I agree that the search as it currently is is inconsistent with how we 
display search fields anywhere else but it does fit with the rest of the 
dashboard. The overall style of the dashboard is pretty unique imo (for better 
or worse).
  
  Other than that +1 for the color change. I'm using Breeze and the dashboard 
with its white text on dark background always looked out of place to me.
  I agree that a blurred background would most likely look very nice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23651

To: ognarb, #plasma, #vdg
Cc: felixernst, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D22429: Make "Updates Available" notification persistent but low priority

2019-07-16 Thread Felix Ernst
felixernst added a comment.


  How about only making security update notifications persistent? There is no 
real harm in missing non-security updates in my opinion.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: felixernst, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Felix Ernst
felixernst added a comment.


  I don't think Konqi should be called a banker when wearing a suit. It doesn't 
fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. 
Business Konqi can work too.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D21939

To: ndavis, #vdg, #plasma
Cc: felixernst, GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D21471: [Notifications] Remove space between pause/stop and details button

2019-05-29 Thread Felix Ernst
felixernst added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

To: broulik, #plasma, #vdg, hein, filipf
Cc: felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart