Re: Review Request: big revamp of Device Notifier

[Gilles CHAUVIN]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2289
---



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
http://reviewboard.kde.org/r/1370/#comment1602

Just my 2 cents: s/insterted/inserted/


- Gilles


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard.kde.org/r/1370/
 ---
 
 (Updated 2009-09-01 16:55:56)
 
 
 Review request for Plasma.
 
 
 Summary
 ---
 
 This is a patch that modifies quite heavily the behaviour of the Device 
 Notifier.
 It comes from here: 
 http://kde-look.org/content/show.php/Device+Manager?content=106051
 It can show the not removable devices too, it can mount them automatically or 
 with a click, since the eject button is a mount button when the volume is 
 umounted. So that guy on the dot will be ok.
 It can hide some items in the same way as Dolphin's places (hide item/ show 
 all).
 Finally, it shows the various opening actions under the device instead of 
 calling that xp-ish window.
 
 
 Diffs
 -
 
   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
 1013960 
   
 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
 1013960 
   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
 1013960 
   
 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
  PRE-CREATION 
   
 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
  1013960 
   
 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
  1013960 
   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
 1013960 
   
 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
 1013960 
   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
 1013960 
   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
 1013960 
 
 Diff: http://reviewboard.kde.org/r/1370/diff
 
 
 Testing
 ---
 
 I'm using it every day since I released 0.1 on Kde-look. I tried all the 
 options on my pc and they work. Some people on kde-look posted some comments 
 about some problems, but it seems to me they are very particular cases, so in 
 my opinion it is quite stable to go in trunk, but anyway review it! :)
 
 
 Screenshots
 ---
 
 screen
   http://reviewboard.kde.org/r/1370/s/183/
 
 
 Thanks,
 
 Giulio
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Question about Plasma::Applet::setConfigurationRequired()

[Gilles CHAUVIN]

On Mon, Feb 9, 2009 at 23:10, Sebastian Kügler se...@kde.org wrote:
 Wild and random guess: try setMinimumSize() on your applet...


I'm not sure how/where I must use this. I'll try to see how it works
with the other applets.


BTW, thanks for your reply.


Gilles.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel