Re: Major CI changes - FreeBSD and Linux

[Gleb Popov]

On Mon, Jan 22, 2024 at 12:09 PM Ben Cooksley  wrote:
>
> Hi all,
>
> Over the past few weeks significant work has been undertaken to develop the 
> ability to make use of containerised builds for FreeBSD.

This is great news! Thank you for all the work done on that front.

D20217: Remove kwallet4 support

[Gleb Popov]

arrowd added inline comments.

INLINE COMMENTS

> pam_kwallet.c:436
>  
> -#ifdef KWALLET5
> -char* extraArg = NULL;
> -#else
> -char* extraArg = "--nofork";
> -#endif
> -char *args[] = {strdup(kwalletd), "--pam-login", pipeInt, sockIn, 
> extraArg, NULL};
> +char *args[] = {strdup(kwalletd), "--pam-login", pipeInt, sockIn, NULL, 
> NULL};
>  execve(args[0], args, pam_getenvlist(pamh));

I wonder why one of `NULL` wasn't removed completely?

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D20217

To: davidedmundson, #plasma, apol
Cc: arrowd, plasma-devel, balaji, galderaa, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Gitlab CI Dashboards and retirement of build.kde.org

[Gleb Popov]

On Sat, Sep 3, 2022 at 7:46 AM Ben Cooksley  wrote:
>
> As previously indicated, I have now shutdown build.kde.org along with the 
> domain that supported it's version of the CI tooling.
> The repository containing that tooling has now also been archived, and the 
> former build.kde.org domain has been redirected to metrics.kde.org.
>
> The server which was acting as a builder for build.kde.org will be rebuilt in 
> the coming days and reallocated to support Gitlab CI workloads.
>
> Thanks,
> Ben

What should be used instead of binary-factory? How do I transform this link?

https://binary-factory.kde.org/view/Windows%2064-bit/job/Kate_Release_win64/1762/artifact/kate-22.08.0-1762-windows-msvc2019_64-cl.exe

Re: Broken KRFB Build on non-linux platforms

[Gleb Popov]

On Fri, Sep 18, 2020 at 10:16 PM Ben Cooksley  wrote:

> Hi Aleix,
>
> Recently you committed some Linux only changes to KRFB. Unfortunately
> these changes were not guarded accordingly, and have therefore broken the
> build on all other platforms (FreeBSD in particular).
>
> Can you please correct this?
>
> As a side note, Pipewire is showing up far too often as a cause of build
> failures. To those developers doing work with this technology, please take
> extra care to ensure that you are not breaking the build.
>

I made a port of PipeWire for FreeBSD some time ago. Maybe the CI needs to
be adjusted to pull in multimedia/pipewire package?

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  I'm not familiar with KDE release engineering, so I'm asking to do merging 
someone else.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:6d86fd453417: kioclient: Dont convert `:x:y` to 
`?line=xcolumn=y` for URLs starting with… (authored by arrowd).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22525?vs=61957=62126

REVISION DETAIL
  https://phabricator.kde.org/D22525

AFFECTED FILES
  kioclient/urlinfo.h

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  In D22525#498393 , @dfaure wrote:
  
  > I suppose the kate developers like the fact that this currently works over 
FTP, SFTP, FISH, SMB, etc.
  >  So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries 
have a different meaning, one that we can't know client-side).
  
  
  I'm confused. I just tried SFTP and SMB without the patch and it also doesn't 
work. As I said, it is invalid to rewrite URLs for remote schemas.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  In D22525#497556 , @cfeck wrote:
  
  > Oh, if the latter syntax also works, then you are right.
  
  
  Not sure what you mean by "also works". Current code checks if the URL ends 
with `:x:y` and turns it into `?line=x=y`. This is used to open local 
text files at the given cursor position. However, for URL's like 
`http://localhost:3000` it is invalid to perform such transformation. My patch 
checks URL scheme and applies the transformation only if it is `file://`.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  In D22525#497332 , @cfeck wrote:
  
  > Could we only apply the `:xx` check on the filename part, not on the server 
part? Someone might expect that `http://path.to/file.txt:99` also works for 
remote files.
  
  
  I don't think that rewriting `http://path.to/file.txt:99` to 
`http://path.to/file.txt?line=99` is a good idea. I'd better not touch 
non`file://` URLs at all.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arrowd requested review of this revision.

REVISION SUMMARY
  BUG: 408632

TEST PLAN
  `kioclient5 exec http://localhost:9000` now works correctly.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22525

AFFECTED FILES
  kioclient/urlinfo.h

To: arrowd
Cc: plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:8072a6acf221: Add support for passing cursor information 
via URL parameters when running… (authored by arrowd).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18296?vs=55879=55973#toc

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18296?vs=55879=55973

REVISION DETAIL
  https://phabricator.kde.org/D18296

AFFECTED FILES
  kioclient/kioclient.cpp
  kioclient/kioclient.h
  kioclient/urlinfo.h

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added inline comments.

INLINE COMMENTS

> dfaure wrote in urlinfo.h:77
> But then you can't do `kde-open5 www.google.fr` anymore, right?
> 
> I see what you mean with typo handling, but there is no perfect solution. 
> Either we treat typos as URLs (but it means we also treat actual URLs as 
> such), or we treat everything non-existing as a local file (breaking any use 
> of short URLs). The latter is OK for kwrite, but not for the more general 
> purpose kioclient / kde-open5.

> But then you can't do kde-open5 www.google.fr anymore, right?

Ah, right. Ok, then.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd updated this revision to Diff 55879.
arrowd marked 5 inline comments as done.
arrowd added a comment.


  Address comments.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18296?vs=54774=55879

BRANCH
  cursor

REVISION DETAIL
  https://phabricator.kde.org/D18296

AFFECTED FILES
  kioclient/kioclient.cpp
  kioclient/kioclient.h
  kioclient/urlinfo.h

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  In D18296#445829 , @dfaure wrote:
  
  > Is the makeURL function still used, or should it be removed now?
  
  
  Yep, it is still used in a bunch of other places.

INLINE COMMENTS

> dfaure wrote in urlinfo.h:39
> const QString &
> 
> And what if it's a URL? At this point this string is pathOrUrl.

> const QString &

There is `path.chop(match.capturedLength());`, which requires non-const 
`QString`.

> And what if it's a URL? At this point this string is pathOrUrl.

Well, `if (QFile::exists(path))` will return false in this case, and `url` 
would get populated by `url = QUrl::fromUserInput()`. What's wrong with that?

> dfaure wrote in urlinfo.h:77
> I'm not sure about AssumeLocalFile, in the context of kde-open.
> This is about opening existing files, not creating new files.
> So it should be removed.

It is not about creating missing files, but reaction to user typos. If I try to 
open `fiel.txt` instead of a `file.txt`, I want to get a "no such file or 
directory error message" instead of popping browser trying to open 
"http://fiel.txt;.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in urlinfo.h:45-52
> Why doesn't it parse the URL if the file already exists?

If the file is named `foo:123`, it refuses to search for cursor infomation and 
just open it.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  In D18296#444642 , 
@elvisangelaccio wrote:
  
  > Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just 
create a static function and put the URL parsing logic there?
  
  
  I just copied this from Kate project. KDevelop also done this.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Can I finally push this?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  In D18296#437985 , @apol wrote:
  
  > Overall this makes sense to me, this assumes though that there will never 
be a file ending with `:digit`, is that something we can live with?
  
  
  Judging from
  
UrlInfo(QString path)
: line(0), column(0)
{
/**
 * first try: just check if the path is an existing file
 */
if (QFile::exists(path)) {
/**
 * create absolute file path, we will e.g. pass this over dbus 
to other processes
 * and then we are done, no cursor can be detected here!
 */
url = 
QUrl::fromLocalFile(QDir::current().absoluteFilePath(path));
return;
}

such files can still be opened, they just can't receive cursor information.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd updated this revision to Diff 54774.
arrowd marked an inline comment as done.
arrowd added a comment.


  Address comments.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18296?vs=49633=54774

BRANCH
  cursor

REVISION DETAIL
  https://phabricator.kde.org/D18296

AFFECTED FILES
  kioclient/kioclient.cpp
  kioclient/kioclient.h
  kioclient/urlinfo.h

To: arrowd, #plasma, #ktexteditor, broulik
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Monthly bump.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik
Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Pingy-ping, bumpy-bump.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Bump();

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Ping? Any chance to get this into 5.15?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #kde_applications
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd created this revision.
arrowd added a reviewer: KDE Applications.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arrowd requested review of this revision.

REVISION SUMMARY
  Second part of fix for a BUG 398998 ( 
https://bugs.kde.org/show_bug.cgi?id=398998 ).
  Kate changes are in D18099 .

TEST PLAN
  Printed resulted URL with `qDebug()`.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  cursor

REVISION DETAIL
  https://phabricator.kde.org/D18296

AFFECTED FILES
  kioclient/kioclient.cpp
  kioclient/kioclient.h
  kioclient/urlinfo.h

To: arrowd, #kde_applications
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart