D20035: Set autofocus to child KPluginSelector on UI load
jayeshbhoot created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jayeshbhoot requested review of this revision. REVISION SUMMARY A sibling commit to this commit in frameworks/kcmutils passes down the focus to the searchbar in KPluginSelector. CCBUG: 399516 BUG: 399516 REPOSITORY R119 Plasma Desktop BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20035 AFFECTED FILES kcms/runners/kcm.cpp To: jayeshbhoot Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20035: Set autofocus to child KPluginSelector on UI load
jayeshbhoot added a comment. True. The description isn't quite clear. The 'sibling commit' is this: https://phabricator.kde.org/D20034. But at the time of `arc diff`, I didn't know how to link to it. So I just linked them both via the BUG tag. Let me know what to correct here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20035 To: jayeshbhoot, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20035: Set autofocus to child KPluginSelector on UI load
jayeshbhoot updated this revision to Diff 54853. jayeshbhoot added a comment. - Fix autofocus on searchbar on UI load REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54744&id=54853 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20035 AFFECTED FILES kcms/runners/kcm.cpp To: jayeshbhoot, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20035: Set autofocus to child KPluginSelector on UI load
jayeshbhoot updated this revision to Diff 54855. jayeshbhoot added a comment. - Remove unused dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54853&id=54855 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20035 AFFECTED FILES kcms/runners/kcm.cpp To: jayeshbhoot, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20035: Set autofocus to child KPluginSelector on UI load
jayeshbhoot added a comment. This is my first patch. So I will need someone to land it. INLINE COMMENTS > ngraham wrote in kcm.cpp:41 > Don't need to include `QTimer` anymore. Fixed > ngraham wrote in kcm.cpp:89 > I'm not thrilled about this workaround. Any chance you can figure out why > `m_pluginSelector->setFocus()` doesn't work all on its own? > > Also, don't use first-person comments in code. My guess is parent class KCModule somehow messes up the setFocus() call in constructor. I can't be sure though; not enough knowledge on the codebase yet. But only that seems to explain the focus shifting to Defaults button in the module. Now, the focus is set in the overridden load() method. My bad on the first-person comment. Fixed. REPOSITORY R119 Plasma Desktop BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D20035 To: jayeshbhoot, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
