from:"Jonathan Marten"

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

2021-02-06 Thread Jonathan Marten

https://bugs.kde.org/show_bug.cgi?id=375249

Jonathan Marten  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #5 from Jonathan Marten  ---
The NFS ioslave has been updated to handle mount permissions problems and
report the error correctly when a file needs to be accessed.  It will also
ignore mounts which cannot be accessed and still allow access to those that
can.  Please test with a current build if possible, and reopen if there is
still a problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 348163] NFS configuration fails on absence of xdr_u_int64_t type

2021-02-04 Thread Jonathan Marten

https://bugs.kde.org/show_bug.cgi?id=348163

Jonathan Marten  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||j...@keelhaul.me.uk
 Resolution|--- |FIXED

--- Comment #1 from Jonathan Marten  ---
Believed fixed, kio_nfs compiles with current Glibc using TIRPC.
Please reopen if there are still build problems on any particular platform.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-17 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eed2d620cbd5: Consistent virtual desktop numbering 
between Switch Window popup and taskbar (authored by marten).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22740?vs=66138=66277

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma, #kwin, zzag
Cc: zzag, GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-15 Thread Jonathan Marten

marten updated this revision to Diff 66138.
marten added a comment.


  Ignore the desktop ID and simply use the loop index, adjusted so that the 
desktop numbers start at 1.  This is the same formatting as used by KWin 
(kwin/useractions.cpp) and the Task Manager applet 
(plasma-desktop/applets/taskmanager/package/contents/ui/ContextMenu.qml).  This 
should work as intended on both X11 and Wayland.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22740?vs=62545=66138

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-18 Thread Jonathan Marten

marten planned changes to this revision.
marten added a comment.


  @GB_2 thanks for testing;  a desktop UUID is obviously not friendly to show 
to the user, so there needs to be some sort of X11/Wayland runtime check here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Jonathan Marten

marten added a comment.


  In D22740#512556 , @ngraham wrote:
  
  > So does this fully fix 410190, or only partially?
  
  
  Fixes it completely for X11.
  Should really verify on Wayland before considering the bug to be completely 
fixed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-07-25 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marten requested review of this revision.

REVISION SUMMARY
  Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent 
virtual desktop numbering between the Switch Window popup and the taskbar Move 
To Desktop list.  This patch fixes the Switch Window popup to use the more 
natural (to the user) 1-based desktop IDs.
  
  According to virtualdesktopinfo.h, a desktop ID on Wayland is a QString while 
on X11 it is a uint.  Therefore using toString() here for correct formatting of 
the desktop ID on both X11 and Wayland.

TEST PLAN
  Built plasma-workspace with this change, observed correct and consistent 
desktop numbering in both these places.  Not yet able to test on Wayland.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-11 Thread Jonathan Marten

marten added a comment.


  Confirmed that man:clang(1) now correctly displays the man page with no 
spurious numbers shown.  Would be happy to abandon this review request.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, 
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, 
navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, 
emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, 
apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

2018-06-19 Thread Jonathan Marten

marten added a comment.


  Apologies for the unforeseen trouble.  I'll revert the committed change for 
now, and then investigate the fix that @kossebau suggests in the previous 
comment.  If this doesn't work then I'll look into splitting the kded and kcm 
modules into separate ones with a common library.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

2018-06-17 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0307eff98f2: Touchpad KDED module: Convert to JSON 
metadata (authored by marten).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13360?vs=35608=36264#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13360?vs=35608=36264

REVISION DETAIL
  https://phabricator.kde.org/D13360

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kdedactions.cpp
  kcms/touchpad/src/plugins.cpp
  kcms/touchpad/src/plugins.h

To: marten, #plasma, davidedmundson
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

2018-06-05 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
marten requested review of this revision.

REVISION SUMMARY
  This is now the preferred way of providing plugin metadata.  It's not just a 
cosmetic change because there is an actual problem with the original:  the 
desktop file kded_touchpad.desktop sets X-KDE-DBus-ModuleName=touchpad which is 
presumably intended to register the KDED module under that name on DBus;  all 
of the clients access it with the interface path "/modules/touchpad".  However, 
this key appears to be being ignored, and the module is registered under the 
path "/modules/kded_touchpad" which can be confirmed with qdbusviewer.  This 
incorrect path means that touchpad control via the Plasma applet does not work, 
and 'kcmshell5 kcmkded' does not show the touchpad module status correctly.
  
  This change updates the KDED plugin to use JSON metadata.

TEST PLAN
  Built plasma-desktop with this change.  Observed correct registration of the 
module name on DBus, correct operation of the Plasma touchpad applet, and of 
"kcmshell5 kcmkded" and "kcmshell5 kcm_touchpad".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kdedactions.cpp
  kcms/touchpad/src/plugins.cpp
  kcms/touchpad/src/plugins.h

To: marten, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9033: man ioslave: asserts trying to display pam(8)

2018-01-08 Thread Jonathan Marten

marten added a comment.


  Ping anyone - is the updated diff enough for review?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

2018-01-08 Thread Jonathan Marten

marten added a comment.


  Ping - anyone able to review?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9079: bluedevil-sendfile: Set option descriptions for command line help

2017-12-01 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:85351d220d83: bluedevil-sendfile: Set option descriptions 
for command line help (authored by marten).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9079?vs=23201=23226

REVISION DETAIL
  https://phabricator.kde.org/D9079

AFFECTED FILES
  src/sendfile/main.cpp

To: marten, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9079: bluedevil-sendfile: Set option descriptions for command line help

2017-12-01 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The "--kio", "--ubi" and "--files"options (or their short equivalents) have 
no description text set.  This does not affect their functionality, but the 
options are not displayed correctly if the "--help" option is used:
  
$ bluedevil-sendfile --help
Usage: bluedevil-sendfile [options]
Bluetooth Send File Wizard

Options:
  --kio, -k --ubi, -u 
--files, -f -h, --help   Displays 
this help.
  -v, --versionDisplays version information.
  --author Show author information.
  --licenseShow licence information.
  --desktopfile The base file name of the desktop entry 
for
   this application.
  
  Setting a description for these options displays the help correctly:
  
$ bluedevil-sendfile --help
Usage: bluedevil-sendfile [options]
Bluetooth Send File Wizard

Options:
  --kio, -k   Specify receiving device by MAC address.
  --ubi, -u   Specify receiving device by UBI path.
  --files, -f   Files to be sent.
  -h, --help   Displays this help.
  -v, --versionDisplays version information.
  --author Show author information.
  --licenseShow licence information.
  --desktopfile The base file name of the desktop entry 
for
   this application.
  
  This is really a problem with QCommandLineParser or something associated with 
it, but in the interests of good documentation there should be a description 
for the options anyway.

TEST PLAN
  Built bluedevil-sendfile with these changes, observed correct "--help" output 
as above.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D9079

AFFECTED FILES
  src/sendfile/main.cpp

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9033: man ioslave: asserts trying to display pam(8)

2017-11-29 Thread Jonathan Marten

marten updated this revision to Diff 23118.
marten added a comment.


  Used const where appropriate.
  
  Apologies for the lack of context in the diff - I hadn't realised until you 
pointed it out that Phabricator doesn't automatically provide context (unlike 
Reviewboard).  Maybe there should be a mention in 
https://community.kde.org/Infrastructure/Phabricator about generating the diff 
with a suitable amount of context?

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9033?vs=23085=23118

REVISION DETAIL
  https://phabricator.kde.org/D9033

AFFECTED FILES
  man/kio_man.cpp
  man/man2html.cpp

To: marten, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9033: man ioslave: asserts trying to display pam(8)

2017-11-29 Thread Jonathan Marten

marten marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9033: man ioslave: asserts trying to display pam(8)

2017-11-28 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  That page, and many others, links to another page with just a plain name:
  
.so PAM.8
  
  This is read by man2html and passed to MANProtocol::readManPage() with a 
filename of "../PAM.8".  This is then resolved against the containing directory 
"/usr/share/man/man8", becoming "/usr/share/man/PAM.8".  No such file exists 
and the mandir.entryList().first() asserts because the list is empty.
  
  The relative filename is correct in the case of other pages. e.g. telinit(8) 
which uses:
  
.so man8/init.8
  
  So it is not enough to simply ignore the "..".  The change to man2html here 
attempts to correct the reference by detecting whether it is of the form 
"../page.sect" and is not "../manN/page.sect", and removing the ".." component 
only in the first case.
  
  While investigating this I found it useful to have a better diagnostic if the 
.so page could not be found.  The change here to kio_man.cpp detects that case 
and displays an error page instead of asserting.  This should only happen if 
there is a bug in the man page, but it is useful to have a pointer so that the 
upstream man page can be fixed.

TEST PLAN
  Built kio_extras with this change.  Verified correct display of the man pages:
  
man:/pam(8) - simple page name
man:/service(8)
man:/telinit(8) - relative page name with section
man:/vigr(8)
man:/mq_open(2) - relative page name to another section

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

AFFECTED FILES
  man/kio_man.cpp
  man/man2html.cpp

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8617: Folder View previews dialogue: Improve visual layout

2017-11-03 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ad5f2e332708: Folder View previews dialogue: Improve 
visual layout (authored by marten).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8617?vs=21768=21839

REVISION DETAIL
  https://phabricator.kde.org/D8617

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml

To: marten, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8617: Folder View previews dialogue: Improve visual layout

2017-11-02 Thread Jonathan Marten

marten updated this revision to Diff 21768.
marten added a comment.


  Fix name for view background colour

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8617?vs=21766=21768

REVISION DETAIL
  https://phabricator.kde.org/D8617

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8617: Folder View previews dialogue: Improve visual layout

2017-11-02 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is the small dialogue that is summoned by the "More Preview Options" 
button on the "Icons" page.  Previously:
  
  F5466090: folderview-properties-preview_BEFORE.png 

  
  there was no margin around either the scrolling list of the dialogue buttons. 
 The revised layout:
  
  F5466093: folderview-properties-preview_AFTER.png 

  
  has margins added where appropriate.
  
  The background colour of the scroll view is forced to the standard system 
background.  This does not appear to be an issue with the Breeze style, but 
with older styles the scroll view background seems to be use the window 
background colour rather than the configured view background colour.

TEST PLAN
  Built plasma-desktop with this change, checked appearance and operation of 
the configuration dialogue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8617

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8563: Folder View icons properties: Improve visual layout

2017-11-01 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7af16dc48fa0: Folder View icons properties: Improve 
visual layout (authored by marten).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8563?vs=21601=21691

REVISION DETAIL
  https://phabricator.kde.org/D8563

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: marten, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8563: Folder View icons properties: Improve visual layout

2017-10-31 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change is similar to https://phabricator.kde.org/D8424, for the "Icons" 
tab of the dialogue.  In the current layout:
  
  F5459638: folderview-properties-icons_BEFORE.png 

  
  the controls are all of varying sizes and are not aligned, and the group 
titles are indented so far that they are not immediately recognisable as such.
  
  The revised layout:
  
  F5459640: folderview-properties-icons_AFTER.png 

  
  uses a single grid layout to enforce the sizes and alignment of the GUI 
controls.
  
  Note that the screen shots above have had the QML tweaked to show all of the 
controls, in order to demonstrate the entire layout.  In practice (and in the 
diff here of course) not all of the controls are shown depending on the 
containment type of the folder view.

TEST PLAN
  Built plasma-desktop with this change. Checked appearance and operation of 
the configuration dialogue both as a desktop containment and as a standalone 
plasmoid.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8563

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

2017-10-23 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:540a90cdeac2: Folder View location properties: Improve 
visual layout (authored by marten).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8424?vs=21132=21154

REVISION DETAIL
  https://phabricator.kde.org/D8424

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: marten, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

2017-10-23 Thread Jonathan Marten

marten added a comment.


  Thanks! - yes, I have push access.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8424

To: marten, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

2017-10-22 Thread Jonathan Marten

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current appearance of this dialogue:
  
  F5443493: folderview-properties-location_BEFORE.png 

  
  has a number of visual anomalies:  most significantly, the spacing and 
alignment between the 3rd/4th radio buttons and their text is not the same as 
the 1st/2nd buttons.  Not only is the visual appearance different but also the 
operation:  the 1st/2nd buttons can be selected by clicking on the label in 
addition to the button, so increasing the target area, but the 3rd/4th can only 
be clicked on the actual button.  Also, the group box titles ("Location" and 
"Title"), with no visual distinction and indented a long way, are not obvious 
for being group titles.
  
  The revised layout:
  
  F5443501: folderview-properties-location_AFTER.png 

  
  uses a single grid layout, so aligning all of the combo boxes and entry 
fields.  All four radio buttons have text, so they are able to be selected by 
clicking on the text.

TEST PLAN
  Built plasma-desktop with this change.  Checked appearance and operation both 
as a desktop containment (when the "Title" controls do not appear) and as a 
standalone plasmoid (when they do).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8424

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

2017-09-14 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Viewing the clang(1) man page shows spurious floating point numbers, either 
"0.0", "3.5" or "7.0", scattered throughout the page:
  
  F3910985: clang-manpage-DX.png 
  
  These appear to be generated by the ".RS" line within a macro, as in the 
decompressed clang.1.bz2 man page source:
  
  .de1 INDENT
  .\" .rstReportMargin pre:
  . RS \\$1
  . nr rst2man-indent\\n[rst2man-indent-level] \\n[an-margin]
  . nr rst2man-indent-level +1
  .\" .rstReportMargin post:
  ..
  
  where the macro parameter to .INDENT is the spurious floating point number 
that appears.
  
  When the .RS is seen in the REQ_RS case in scan_request(), if there are 
arguments scan_expression() is called to read the first argument.  
Unfortunately, scan_expression() simply sees the "\\$1" text and does not 
attempt to expand it as a macro argument.  Since this string does not match any 
of the syntax known to scan_expression() the argument is ignored, the scan 
pointer is not advanced and the argument is output as if it were normal text.
  
  This change recognises the "\\$1" syntax in scan_expression() and uses 
scan_escape_direct() to parse it.  The string value is then converted to a 
number.  It is only possible to return an integer (rounded) because 
scan_expression() only handles integers, but at least something approximate is 
returned and the argument is skipped and not output.

TEST PLAN
  Built kio_man with this change, verified correct output of this man page and 
others.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

AFFECTED FILES
  man/man2html.cpp

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D6573: Babelfish plugin: Allow secure URLs to be translated

2017-07-09 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R226:b90b0b0321a9: Babelfish plugin: Allow secure URLs to be 
translated (authored by marten).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6573?vs=16361=16394#toc

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6573?vs=16361=16394

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

2017-07-08 Thread Jonathan Marten

marten updated this revision to Diff 16361.
marten added a comment.


  Use KParts::BrowserExtension::childObject(part) to test for browser part 
(needs to be guarded by part!=NULL).
  Split up the big conditional.
  Use part->widget() as parent for message boxes.

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6573?vs=16347=16361

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

2017-07-08 Thread Jonathan Marten

marten marked 2 inline comments as done.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6573: Babelfish plugin: Allow secure URLs to be translated

2017-07-08 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Dolphin, plasma-devel.

REVISION SUMMARY
  The plugin originally only allows HTTP URLs to be translated.  With the 
increasing use of automatic redirection to HTTPS, this seriously restricts the 
utility of the plugin - neither www.kde.org nor Wikipedia can be translated.
  
  This change enables the plugin for HTTPS URLs also.  Since this can result in 
secure information being transmitted over the network in clear text and 
received by the online translation service, a warning dialogue (with the option 
to not ask again) is shown.
  
  The change also removes some unused header files and ports KUrl -> QUrl, 
which eliminates the use of KDELibs4Support.

TEST PLAN
  Built konqueror with this change, checked operation of Tools - Translate Web 
Page for www.kde.org and other secure pages.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5871: Remove obviously wrongly-named symbolic links

2017-05-15 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R267:1b641f89d752: Remove obviously wrongly-named symbolic 
links (authored by marten).

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5871?vs=14560=14564

REVISION DETAIL
  https://phabricator.kde.org/D5871

AFFECTED FILES
  128x128/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  16x16/mimetypes/text-x-generic.svapplication-x-awk.png
  16x16/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  22x22/mimetypes/text-x-generic.svapplication-x-awk.png
  22x22/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  256x256/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  32x32/mimetypes/text-x-generic.svapplication-x-awk.png
  32x32/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  48x48/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  64x64/mimetypes/text-x-generic.svapplication-x-awk.png
  64x64/mimetypes/text-x-generic.svapplicatiopn-x-awk.png

To: marten, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5871: Remove obviously wrongly-named symbolic links

2017-05-15 Thread Jonathan Marten

marten created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  It's not clear where these entries came from, but they are clearly a mistake 
- either scripting or copy-and-paste.
  The intended 'text-x-generic' and 'application-x-awk' icons still exist.

TEST PLAN
  Built and installed oxygen-icons5 with these changes, checked correct 
installation of icons.

REPOSITORY
  R267 Oxygen Icons

REVISION DETAIL
  https://phabricator.kde.org/D5871

AFFECTED FILES
  128x128/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  16x16/mimetypes/text-x-generic.svapplication-x-awk.png
  16x16/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  22x22/mimetypes/text-x-generic.svapplication-x-awk.png
  22x22/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  256x256/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  32x32/mimetypes/text-x-generic.svapplication-x-awk.png
  32x32/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  48x48/mimetypes/text-x-generic.svapplicatiopn-x-awk.png
  64x64/mimetypes/text-x-generic.svapplication-x-awk.png
  64x64/mimetypes/text-x-generic.svapplicatiopn-x-awk.png

To: marten, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

2017-05-11 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:92c9c0f31966: Add FindSamba.cmake, needed for the SMB 
ioslave (authored by marten).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5761?vs=14274=14395#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5761?vs=14274=14395

REVISION DETAIL
  https://phabricator.kde.org/D5761

AFFECTED FILES
  cmake/COPYING-CMAKE-SCRIPTS
  cmake/FindSamba.cmake

To: marten, #plasma, dfaure, lbeltrame
Cc: fvogt, lbeltrame, plasma-devel, jriddell, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

2017-05-11 Thread Jonathan Marten

marten added a comment.


  In https://phabricator.kde.org/D5761#108658, @lbeltrame wrote:
  
  > Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to 
this commit, if it's not in the repository already, or there won't be any 
reference to the license.
  
  
  Sorry, I'm not yet familiar with that and can't find any documented 
reference.  Do you mean simply add a copy of the 
extra-cmake-modules/COPYING-CMAKE-SCRIPTS file in the cmake subdirectory 
(alongside the new FindSamba.cmake)?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5761

To: marten, #plasma, dfaure, lbeltrame
Cc: fvogt, lbeltrame, plasma-devel, jriddell, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5564: Man ioslave: Port away from KDELibs4Support

2017-05-09 Thread Jonathan Marten

marten added inline comments.

INLINE COMMENTS

> dfaure wrote in kio_man.cpp:247
> keep the spaces around !=

Will fix.

> dfaure wrote in man2html.cpp:6015
> why PLASMA? This is kde/kdenetwork/kio-extras, usable outside of a plasma 
> workspace. I'm curious where PLASMA_VERSION_STRING even comes from !?

This was originally the closest thing I could find to the "KDE" version 
available.  However, it's been pointed out that it makes kio-extras depend on 
Plasma, and I've now changed it to take the version from the project version of 
kio-extras itself.

There doesn't really seem to be much point in displaying this information at 
all, so if you think it would be worthwhile I'll remove the entire "KDE 
version" string (i.e. act as if SIMPLE_MAN2HTML was defined above).  Not sure 
whether the number/string registers defined about lines 297 and 1513 above are 
ever used in any man pages, though, but if they are no use they could be cut 
out as well.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5564

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

2017-05-08 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This CMake module used to be provided by KDELibs4Support.  Since the removal 
of that dependency from kio-extras, the module is not found and the SMB ioslave 
cannot be built.
  
  This differential takes a local copy of the module from KDELibs4Support in 
kio-extras.  No other part of KDE frameworks or Plasma appears to need Samba, 
therefore this approach should be preferable to copying it into ECM.

TEST PLAN
  Copied this file into kio-extras/cmake source directory and built.
  Samba libraries (from Samba 4.2.14) are found, and the SMB ioslave is built 
and works correctly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5761

AFFECTED FILES
  cmake/FindSamba.cmake

To: marten, #plasma, dfaure
Cc: plasma-devel, jriddell, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[kio-extras] [Bug 379593] git master fails to build: plasma_version.h not found

2017-05-07 Thread Jonathan Marten

https://bugs.kde.org/show_bug.cgi?id=379593

Jonathan Marten <j...@keelhaul.me.uk> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kio
   ||-extras/6d47e158a4e20af0c36
   ||5d9aac17a5c69553d9e5e

--- Comment #3 from Jonathan Marten <j...@keelhaul.me.uk> ---
Git commit 6d47e158a4e20af0c365d9aac17a5c69553d9e5e by Jonathan Marten.
Committed on 07/05/2017 at 19:59.
Pushed by marten into branch 'master'.

man ioslave: Do not depend on Plasma for version numbers

The version numbers are only used for display to the user in specially
formatted KDE man pages.  Take them from the version of the kio-extras
package.

M  +6-0config-runtime.h.cmake
M  +11   -8man/man2html.cpp

https://commits.kde.org/kio-extras/6d47e158a4e20af0c365d9aac17a5c69553d9e5e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 379593] git master fails to build: plasma_version.h not found

2017-05-07 Thread Jonathan Marten

https://bugs.kde.org/show_bug.cgi?id=379593

--- Comment #2 from Jonathan Marten <j...@keelhaul.me.uk> ---
CI (comment #1) should have been fixed by commit 6be8b06a to kio-extras.

I'll commit a further fix for the version numbering:  to avoid introducing an
extra dependency it should be possible to just use the PROJECT_VERSION that is
set in kio-extras' CMakeLists.txt.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5566: recentdocuments ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:26f76fc64bae: recentdocuments ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5566?vs=13748=14194

REVISION DETAIL
  https://phabricator.kde.org/D5566

AFFECTED FILES
  recentdocuments/CMakeLists.txt
  recentdocuments/recentdocuments.cpp
  recentdocuments/recentdocumentsnotifier.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5562: Fish ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:149d281277df: fish ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5562?vs=13743=14192

REVISION DETAIL
  https://phabricator.kde.org/D5562

AFFECTED FILES
  fish/CMakeLists.txt
  fish/fish.cpp
  fish/fish.h
  fish/tests/CMakeLists.txt

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:11df45b3d216: SFTP ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5568?vs=14036=14196

REVISION DETAIL
  https://phabricator.kde.org/D5568

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5569: thumbnail ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b0b12086e786: Thumbnail ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5569?vs=13752=14197

REVISION DETAIL
  https://phabricator.kde.org/D5569

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/thumbnail.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5564: Man ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:cefa4de62964: Man ioslave: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5564?vs=13744=14191

REVISION DETAIL
  https://phabricator.kde.org/D5564

AFFECTED FILES
  man/CMakeLists.txt
  man/kio_man.cpp
  man/kmanpart.cpp
  man/man2html.cpp
  man/tests/CMakeLists.txt

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5567: Settings ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:117e6235ce81: Settings ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5567?vs=13750=14195

REVISION DETAIL
  https://phabricator.kde.org/D5567

AFFECTED FILES
  settings/CMakeLists.txt
  settings/kio_settings.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5565: Network ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:17effe0d9f73: Network ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5565?vs=13746=14193

REVISION DETAIL
  https://phabricator.kde.org/D5565

AFFECTED FILES
  network/ioslave/main.cpp
  network/ioslave/networkinitwatcher.h
  network/ioslave/networkslave.cpp
  network/network/CMakeLists.txt
  network/network/molletnetwork_export.h
  network/network/netdevice.cpp
  network/network/netdevice.h
  network/network/netservice.cpp
  network/network/netservice.h
  network/network/network.cpp
  network/network/network.h

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5560: Archive ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bbd3d8feb250: Archive: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5560?vs=13741=14189

REVISION DETAIL
  https://phabricator.kde.org/D5560

AFFECTED FILES
  archive/CMakeLists.txt
  archive/autotests/CMakeLists.txt
  archive/autotests/testkioarchive.cpp
  archive/kio_archivebase.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5561: Filter ioslave: Port away from KDELibs4Support

2017-05-06 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:c285acd05e32: filter: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5561?vs=13742=14190

REVISION DETAIL
  https://phabricator.kde.org/D5561

AFFECTED FILES
  filter/CMakeLists.txt
  filter/filter.cc

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-30 Thread Jonathan Marten

marten updated this revision to Diff 14036.
marten added a comment.


  There seems to be only one place where the result from the openPasswordDialog 
is actually propagated to the outside.  I've changed this one; the point of 
changing the others was to port away from the old deprecated function.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5568?vs=13751=14036

REVISION DETAIL
  https://phabricator.kde.org/D5568

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas

D5569: thumbnail ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the thumbnail ioslave and therefore, along with the previously submitted 
changes to the other subdirectories, from the entire kio-extras package.
  
  There are no actual code changes involved here, just removing unused header 
files.

TEST PLAN
  Built kio-extras with this change, checked correct operation of thumbnail 
generation in file managers.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5569

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/thumbnail.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the SFTP ioslave.

TEST PLAN
  Built kio-extras with this change, checked correct operation of ioslave and 
access to remote hosts via SFTP.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5568

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5567: Settings ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the settings ioslave.

TEST PLAN
  Built kio-extras with this change, checked correct operation of ioslave and 
listing of KCM modules in Konqueror.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5567

AFFECTED FILES
  settings/CMakeLists.txt
  settings/kio_settings.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5566: recentdocuments ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the recentdocuments ioslave.

TEST PLAN
  Built kio-extras with this change, checked correct operation of ioslave and 
listing of recent documents in Konqueror.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5566

AFFECTED FILES
  recentdocuments/CMakeLists.txt
  recentdocuments/recentdocuments.cpp
  recentdocuments/recentdocumentsnotifier.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5565: Network ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the network ioslave.

TEST PLAN
  Built kio-extras with this change, checked correct operation of ioslave.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5565

AFFECTED FILES
  network/ioslave/main.cpp
  network/ioslave/networkinitwatcher.h
  network/ioslave/networkslave.cpp
  network/network/CMakeLists.txt
  network/network/molletnetwork_export.h
  network/network/netdevice.cpp
  network/network/netdevice.h
  network/network/netservice.cpp
  network/network/netservice.h
  network/network/network.cpp
  network/network/network.h

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5564: Man ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the man ioslave and the man2html converter.

TEST PLAN
  Built kio-extras with this change, checked correct operation of ioslave and 
man page generation/display.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5564

AFFECTED FILES
  man/CMakeLists.txt
  man/kio_man.cpp
  man/kmanpart.cpp
  man/man2html.cpp
  man/tests/CMakeLists.txt

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5562: Fish ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the ioslave.

TEST PLAN
  Built kio-extras with this change, checked correct operation of fish ioslave 
accessing local and remote hosts.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5562

AFFECTED FILES
  fish/CMakeLists.txt
  fish/fish.cpp
  fish/fish.h
  fish/tests/CMakeLists.txt

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5561: Filter ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the filter-based ioslaves: bzip/bzip2, gzip, lzma, xz

TEST PLAN
  Built kio-extras with this change, checked correct operation of those 
ioslaves with their appropriate compressed file formats.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5561

AFFECTED FILES
  filter/CMakeLists.txt
  filter/filter.cc

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5560: Archive ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten added a comment.


  Also: Install KIOArchive library with LIBRARY NAMELINK_SKIP so that clients 
will depend on major soversion, as suggested by jriddell.
  Make major soversion number the same as first part of full version, for 
consistency.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5560

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5560: Archive ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change removes the build and runtime requirement for KDELibs4Support 
from the archive-based ioslaves (ar, tar and zip).

TEST PLAN
  Built kio-extras with this change, all autotests pass, checked correct 
operation of those ioslaves with their appropriate archive formats.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5560

AFFECTED FILES
  archive/CMakeLists.txt
  archive/autotests/CMakeLists.txt
  archive/autotests/testkioarchive.cpp
  archive/kio_archivebase.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5112: Make archiver ioslave extensible

2017-03-29 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:785d85f3fe5a: Make the archiver KIOslave extensible 
(authored by marten).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5112?vs=12896=12972#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5112?vs=12896=12972

REVISION DETAIL
  https://phabricator.kde.org/D5112

AFFECTED FILES
  archive/CMakeLists.txt
  archive/KF5KioArchiveConfig.cmake.in
  archive/kio_archive.cpp
  archive/kio_archive.h
  archive/kio_archivebase.cpp
  archive/kio_archivebase.h

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5112: Make archiver ioslave extensible

2017-03-29 Thread Jonathan Marten

marten added a comment.


  I'd done some porting away from kdelibs4 in this change, in particular 
KMimeType -> QMime* but realized that it was getting a bit involved and would 
be mixing up two unrelated changes (involving about 30 files for the whole of 
kio-extras) .  So I'll submit a separate change for the remainder of the 
porting.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5112: Make archiver ioslave extensible

2017-03-28 Thread Jonathan Marten

marten updated this revision to Diff 12896.
marten added a comment.


  Remove KF5 prefixes, the library is now libkioarchive.so

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5112?vs=12641=12896

REVISION DETAIL
  https://phabricator.kde.org/D5112

AFFECTED FILES
  archive/CMakeLists.txt
  archive/KF5KioArchiveConfig.cmake.in
  archive/KioArchiveConfig.cmake.in

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5112: Make archiver ioslave extensible

2017-03-27 Thread Jonathan Marten

marten added a comment.


  Point taken regarding the KF5 prefix, this was based on the installed names 
for libkonq (= libKF5Konq.so etc) although not every application support 
library is named the same way (libkworkspace5.so isn't).
  
  Would the name libKioArchive.so, etc be appropriate, or should it be all 
lower case (libkioarchive.so)?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5112: Make archiver ioslave extensible

2017-03-20 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The tar, zip and ar ioslaves are implemented in kio-extras/archive by a 
single plugin (class ArchiveProtocol).  This uses the URL scheme to determine 
which archive decoder to use - KTar, KZip or KAr all from the KArchive (tier 1) 
framework.  Unfortunately, it is not possible to use this ioslave as a base for 
another archive format plugin to be distributed and built outside of the KDE 
source tree, because the supported protocols and their decoders are hardcoded 
in the depths of ArchiveProtocol::checkNewFile().  This means that a new 
ioslave for another archive format would need to copy and adapt the whole of 
the ArchiveProtocol source.
  
  This change makes it possible to do that by moving most of ArchiveProtocol 
into an abstract base class ArchiveProtocolBase, compiled into an library and 
installed along with its supporting files.  This is not a framework library 
(and is not ever intended to be), but a support library similar to libkonq.  It 
calls a virtual function in a derived class to create the KArchive-based 
decoder depending on the URL scheme.  The ioslave plugin for the existing 
archive formats is a single derived class (although it could just as easily be 
three) which is installed in the same way as before.
  
  With this change, it is then possible to build and install an additional 
out-of-tree ioslave plugin, deriving from ArchiveProtocolBase and using its 
installed headers and library, without needing any further changes to 
kio-extras.
  
  The additional files installed are:
  
  lib/cmake/KF5KioArchive/KF5KioArchiveConfig.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveConfigVersion.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveTargets.cmake
  lib/cmake/KF5KioArchive/KF5KioArchiveTargets-debug.cmake
  include/KF5/kio_archivebase.h
  include/KF5/libkioarchive_export.h
  lib/libKF5KioArchive.so.5.97.0
  lib/libKF5KioArchive.so.6 -> libKF5KioArchive.so.5.97.0
  lib/libKF5KioArchive.so -> libKF5KioArchive.so.6
  
  The .so versions are set as for libkonq, although they can easily be changed 
if required.

TEST PLAN
  Built kio-extras with this change, all autotests pass.
  Konqueror operates correctly to browse tar and zip archives.
  External archive format plugin builds and works correctly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5112

AFFECTED FILES
  archive/CMakeLists.txt
  archive/KF5KioArchiveConfig.cmake.in
  archive/kio_archive.cpp
  archive/kio_archive.h
  archive/kio_archivebase.cpp
  archive/kio_archivebase.h

To: marten, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

2017-02-23 Thread Jonathan Marten

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cc5720494a01: Fonts KCM: Fix layout of hinting settings, 
port away from KDE4 (authored by marten).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4740?vs=11675=11698

REVISION DETAIL
  https://phabricator.kde.org/D4740

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Changed Subscribers] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

2017-02-23 Thread Jonathan Marten

marten added inline comments.

INLINE COMMENTS

> receivefilejob.h:69
>  BluezQt::Request m_request;
> +bool m_accepted = false;
>  };

Allowed in C++11, but would this not be clearer done in the constructor 
initialization list?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D4744

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: marten, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 126 lines] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

2017-02-23 Thread Jonathan Marten

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change improves the layout of the font hinting sub-dialogue of this KCM. 
 Previously there was no spacing around or between the GUI elements and the 
combo boxes did not line up:
  
  F2542184: fontskcm-hinting-settings-Dx-before.png 

  
  Now the dialogue uses a QFormLayout (but left aligned as discussed in 
https://phabricator.kde.org/D2853) with style default spacing:
  
  F2542188: fontskcm-hinting-settings-Dx-after.png 

  
  In addition some porting away from KDE4 support is done:
  
  KDialog -> QDialog
  KApplication -> QApplication
  KProcess -> QProcess
  KStandardDirs -> KSharedConfig
  KDoubleNumInput -> QDoubleSpinBox
  
  There is, however, some KDE4 porting still remaining to be done, since I'm 
not sure whether there are Frameworks equivalents to these at the moment:
  
  KGlobalSettings::emitChange(KGlobalSettings::FontChanged);
  KFontDialog::getFontDiff()

TEST PLAN
  Built plasma-desktop with  these changes, checked correct appearance and 
operation of Fonts KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4740

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

2017-01-19 Thread Jonathan Marten

marten added a comment.


  Agreed that a decision needs to be made, but I'm not an expert on the 
KPackage system and so wasn't sure whether the warning may be useful to package 
developers in some cases - in which case leaving it commented out would make it 
easier to reinstate than removing it entirely.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Plasma Workspace Wallpapers] [Bug 363860] Slideshow does not cycle if only one image in set directory

2017-01-18 Thread Jonathan Marten

https://bugs.kde.org/show_bug.cgi?id=363860

Jonathan Marten <j...@keelhaul.me.uk> changed:

   What|Removed |Added

 CC||p.suetter...@royac.iac.es

--- Comment #2 from Jonathan Marten <j...@keelhaul.me.uk> ---
*** Bug 368955 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 2 lines] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

2017-01-18 Thread Jonathan Marten

marten created this revision.
marten added reviewers: Frameworks, Plasma.
marten set the repository for this revision to R290 KPackage.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described in https://bugs.kde.org/show_bug.cgi?id=350148, this message 
appears three times every time the slideshow plugin changes the background 
image.  It cannot be disabled via Qt logging rules.  Apart from possible 
interest to package developers this message serves no useful purpose, so 
suppressing it would avoid clutter in the user's session log.

TEST PLAN
  Built KPackage with this change, all autotests pass.
  Observed correct operation of Plasma desktop and slideshow background, with 
no log messages.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

AFFECTED FILES
  src/kpackage/package.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-03 Thread marten (Jonathan Marten)

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP8bee1a78b04a: Mouse KCM: Align spin boxes, port 
to Qt5 (authored by marten).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2853?vs=7051=7057

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma, mart
Cc: andreaska, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 170 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-03 Thread marten (Jonathan Marten)

marten updated this revision to Diff 7051.
marten added a comment.


  Using a form layout wrapped in an outer layout with stretch added to the 
right.  Gives the intended effect, with all spin boxes the same size and lining 
up on both tabs.  The boxes for the "Keyboard Navigation" tab are wider than 
they should be, because the check box makes the form layout wider - probably 
not worth the complexity of fixing, the appearance is at least better than 
before.
  
  The indentation here is awful, especially the "Keyboard Navigation" block 
enclosed in spurious braces and then indented outwards...  I've kept that which 
exists at the moment, and will fix in a separate commit so as not to mix code 
and whitespace changes.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2853?vs=7049=7051

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: andreaska, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 126 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-03 Thread marten (Jonathan Marten)

marten updated this revision to Diff 7049.
marten added a comment.


  Apologies for the confusion... this patch corresponds to the last screen 
shot, with ExpandingFieldsGrow and MinimumExpanding (currently only for the 
"Advanced" tab).
  
  Adding an outer layout with a stretch to the right seem to be the way to go, 
I'll work on that.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2853?vs=7032=7049

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-03 Thread marten (Jonathan Marten)

marten added a comment.


  This is what happens with a QFormLayout with 
fieldGrowthPolicy=ExpandingFieldsGrow and fields' 
sizePolicy=MinimumExpanding/Fixed.  The effect is not good - it moves the spin 
box controls a long way away.  Shall I stick with the grid layout?
  
  F349555: mouse-kcmshell-after-3.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2853

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-02 Thread marten (Jonathan Marten)

marten added a comment.


  Thanks for the hint David... I thought that I'd tried the approach of setting 
the fieldGrowthPolicy and the sizePolicy of the fields, and the problem with 
that was that the spinboxes were then extended to the full width of the form - 
not looking good, as well as putting the numeric values a long way away from 
their labels.  So I remembered seeing the event filter technique used somewhere 
else, and did that.  I'll take another look at the QFormLayout approach, 
though, and see if it can be made to give the right appearance.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2853

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 196 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-10-01 Thread marten (Jonathan Marten)

marten updated this revision to Diff 7032.
marten added a comment.


  Implemented using a grid layout.  It looks the same, not needing the event 
filter but at the cost of more code to generate the layout (getting the 
required label alignment, setting label buddies, keeping track of rows...) 
which QFormLayout does automatically.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2853?vs=6916=7032

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-09-26 Thread marten (Jonathan Marten)

marten added a comment.


  A grid layout would fix it, but I assume that the point of using a form 
layout is that it would automatically pick up the platform and style policy 
(field and label alignment, stretch policy etc).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2853

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 154 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

2016-09-25 Thread marten (Jonathan Marten)

marten created this revision.
marten added a reviewer: Plasma.
marten set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
marten added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The "Advanced" and "Keyboard Navigation" tabs of the mouse control panel 
(kcmshell5 mouse) contain a number of spin boxes, all of which were originally 
at their natural widths (see "before" screen shots):
  
  F341313: mouse-kcmshell-before-2.png 
  
  F341312: mouse-kcmshell-before-1.png 
  
  This change improves the appearance by aligning them all to have the same 
width:
  
  F341315: mouse-kcmshell-after-2.png 
  
  F341314: mouse-kcmshell-after-1.png 
  
  In addition to this, the spin boxes are ported from the deprecated KNumInput 
to QSpinBox/QDoubleSpinBox as appropriate, and some cruft (including unneeded 
include files) is removed.

TEST PLAN
  Built mouse KCM with these changes, checked appearance and operation.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-14 Thread marten (Jonathan Marten)

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE4be156bc6776: Image wallpaper: Fix 
verification of a background image file (authored by marten).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2722?vs=6579=6736

REVISION DETAIL
  https://phabricator.kde.org/D2722

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-10 Thread marten (Jonathan Marten)

marten added a comment.


  Sorry, I'm not yet totally au fait with the Phabricator workflow.  Does 
"accepted and ready to land" mean to commit it?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)

marten set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 11 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)

marten removed rPLASMAWORKSPACE Plasma Workspace as the repository for this 
revision.
marten updated this revision to Diff 6579.
marten added a comment.


  Implemented BackgroundFinder::isAcceptableSuffix() as suggested.
  
  Yes, I already have Git commit access (assuming that nothing special needs to 
be set up within Phabricator, this being my first review in that).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2722?vs=6578=6579

REVISION DETAIL
  https://phabricator.kde.org/D2722

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)

marten added a comment.


  broulik's suggestion would make the code clearer,  I'll look into it.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)

marten created this revision.
marten added a reviewer: Plasma.
marten set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When a new image file is detected via Image::pathCreated(), its file 
extension is checked against BackgroundFinder::suffixes() to ensure that it is 
a supported format.  However, despite its name, suffixes() returns a list of 
glob patterns (i.e. all prefixed with "*.") so the contains() never succeeds 
and the new file is not added.
  
  suffixes() is also used within the BackgroundCreator class itself to set a 
directory name filter.  To maintain compatibility it may be better to not 
change the name or meaning of this function, but instead to take account of the 
pattern in Image::pathCreated().  This patch does just that.

TEST PLAN
  Built plasma-workspace with this changed, checked correct operation of 
slideshow wallpaper.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2722

AFFECTED FILES
  wallpapers/image/image.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-06-05 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---

(Updated June 5, 2016, 2:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Changes
---

Submitted with commit 226401862f2c68f9bd37e95f6fae241b2d41e733 by Jonathan 
Marten to branch master.


Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666


Repository: plasma-integration


Description
---

The referenced bug says that, by default, there is no file overwrite check when 
using QFileDialog to save a file.  Indeed, on closer investigating it appears 
that there is no way to even explictly force an overwrite check when using the 
KDE platform theme, because of this code in 
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:

// overwrite option
if 
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
 {
dialog->m_fileWidget->setConfirmOverwrite(false);
}

The default for KFileWidget is already for no overwrite check (as set in 
kio/src/filewidgets/kfilewidget.cpp which initialises 
KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
this from the calling application through the platform plugin.

Suggest that the default option should be the same as that defined by Qt for 
QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
has set the QFileDialog::DontConfirmOverwrite option.  This is also a sensible 
default to have from the user's point of view.  This change does that in the 
platform theme plugin, for all saving operations.


Diffs
-

  autotests/kfiledialog_unittest.cpp 59915da 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
  tests/qfiledialogtest.cpp 1d69ea1 

Diff: https://git.reviewboard.kde.org/r/127944/diff/


Testing
---

Built plasma-intergration with this change, confirmed correct operation of file 
dialogues and that confirmation is requested when overwriting an existing file, 
unless the QFileDialog::DontConfirmOverwrite option is specified.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-20 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---

(Updated May 20, 2016, 9:22 a.m.)


Review request for kde-workspace and Plasma.


Changes
---

Use a temporary file for the overwrite check, instead of assuming a name that 
should exist.


Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666


Repository: plasma-integration


Description
---

The referenced bug says that, by default, there is no file overwrite check when 
using QFileDialog to save a file.  Indeed, on closer investigating it appears 
that there is no way to even explictly force an overwrite check when using the 
KDE platform theme, because of this code in 
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:

// overwrite option
if 
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
 {
dialog->m_fileWidget->setConfirmOverwrite(false);
}

The default for KFileWidget is already for no overwrite check (as set in 
kio/src/filewidgets/kfilewidget.cpp which initialises 
KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
this from the calling application through the platform plugin.

Suggest that the default option should be the same as that defined by Qt for 
QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
has set the QFileDialog::DontConfirmOverwrite option.  This is also a sensible 
default to have from the user's point of view.  This change does that in the 
platform theme plugin, for all saving operations.


Diffs (updated)
-

  autotests/kfiledialog_unittest.cpp 59915da 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
  tests/qfiledialogtest.cpp 1d69ea1 

Diff: https://git.reviewboard.kde.org/r/127944/diff/


Testing
---

Built plasma-intergration with this change, confirmed correct operation of file 
dialogues and that confirmation is requested when overwriting an existing file, 
unless the QFileDialog::DontConfirmOverwrite option is specified.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-18 Thread Jonathan Marten



> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your 
> > change, but the test passed nevertheless.
> 
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.
> 
> Jonathan Marten wrote:
> Now I see that there are autotests after all.  How do I run them?
> 
> Martin Gräßlin wrote:
> you can go to the build directory and just do:
> make test
> 
> or just run the individial test binary created in build/autotests. The 
> relevant one would be kfiledialog_unittest and kfiledialogqml_unittest
> 
> Jonathan Marten wrote:
> Ok, found them and how - thanks.
> 
> It doesn't appear to be possible to just check that the QFileDialog 
> option is passed correctly through to the file widget, because KFileWidget 
> has no way to read back the option set by setConfirmOverwrite.  So it won't 
> be a simple test like the setFileMode tests - it will have to look for the 
> message box being shown.  Is that worth doing (and reliable enough)?
> 
> Martin Gräßlin wrote:
> hmm yeah, tricky. I think it would be ok to check for the messagebox 
> being shown as that's kind of also how the autotest for the dialog works in 
> general. But I also don't have an idea on how to check whether the messagebox 
> got opened. So maybe just push without it.
> 
> Btw. please push for the Plasma/5.6 branch.

Ok, have worked out an autotest.  It's not pretty, but it does work - passing 
with the modified platform theme and failing with the original.  It puts up a 
save box for a file which already exists, clicks the OK button and checks that 
a message box appears or not according to the QFileDialog option.  The message 
box has to be checked in a QTimer slot because, if it does appear, it runs its 
own event loop which halts the test until the user clicks one of its buttons.

Go easy with it - it's my first ever Frameworks autotest :-)


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
---


On May 18, 2016, 11:07 a.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> ---
> 
> (Updated May 18, 2016, 11:07 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 360666
> https://bugs.kde.org/show_bug.cgi?id=360666
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> The referenced bug says that, by default, there is no file overwrite check 
> when using QFileDialog to save a file.  Indeed, on closer investigating it 
> appears that there is no way to even explictly force an overwrite check when 
> using the KDE platform theme, because of this code in 
> plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
> 
> // overwrite option
> if 
> (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
>  {
> dialog->m_fileWidget->setConfirmOverwrite(false);
> }
> 
> The default for KFileWidget is already for no overwrite check (as set in 
> kio/src/filewidgets/kfilewidget.cpp which initialises 
> KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
> this from the calling application through the platform plugin.
> 
> Suggest that the default option should be the same as that defined by Qt for 
> QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
> has set the QFileDialog::DontConfirmOverwrite option.  This is also a 
> sensible default to have from the user's point of view.  This change does 
> that in the platform theme plugin, for all saving operations.
> 
> 
> Diffs
> -
> 
>   autotests/kfiledialog_unittest.cpp 59915da 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
>   tests/qfiledialogtest.cpp 1d69ea1 
> 
> Diff: https://git.reviewboard.kde.org/r/127944/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-intergration with this change, confirmed correct operation of 
> file dialogues and that confirmation is requested when overwriting an 
> existing file, unless the QFileDialog::DontConfirmOverwrite option is 
> specified.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-18 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---

(Updated May 18, 2016, 11:07 a.m.)


Review request for kde-workspace and Plasma.


Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666


Repository: plasma-integration


Description
---

The referenced bug says that, by default, there is no file overwrite check when 
using QFileDialog to save a file.  Indeed, on closer investigating it appears 
that there is no way to even explictly force an overwrite check when using the 
KDE platform theme, because of this code in 
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:

// overwrite option
if 
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
 {
dialog->m_fileWidget->setConfirmOverwrite(false);
}

The default for KFileWidget is already for no overwrite check (as set in 
kio/src/filewidgets/kfilewidget.cpp which initialises 
KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
this from the calling application through the platform plugin.

Suggest that the default option should be the same as that defined by Qt for 
QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
has set the QFileDialog::DontConfirmOverwrite option.  This is also a sensible 
default to have from the user's point of view.  This change does that in the 
platform theme plugin, for all saving operations.


Diffs (updated)
-

  autotests/kfiledialog_unittest.cpp 59915da 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
  tests/qfiledialogtest.cpp 1d69ea1 

Diff: https://git.reviewboard.kde.org/r/127944/diff/


Testing
---

Built plasma-intergration with this change, confirmed correct operation of file 
dialogues and that confirmation is requested when overwriting an existing file, 
unless the QFileDialog::DontConfirmOverwrite option is specified.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten



> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your 
> > change, but the test passed nevertheless.
> 
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.
> 
> Jonathan Marten wrote:
> Now I see that there are autotests after all.  How do I run them?
> 
> Martin Gräßlin wrote:
> you can go to the build directory and just do:
> make test
> 
> or just run the individial test binary created in build/autotests. The 
> relevant one would be kfiledialog_unittest and kfiledialogqml_unittest

Ok, found them and how - thanks.

It doesn't appear to be possible to just check that the QFileDialog option is 
passed correctly through to the file widget, because KFileWidget has no way to 
read back the option set by setConfirmOverwrite.  So it won't be a simple test 
like the setFileMode tests - it will have to look for the message box being 
shown.  Is that worth doing (and reliable enough)?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
---


On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> ---
> 
> (Updated May 17, 2016, 3:20 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 360666
> https://bugs.kde.org/show_bug.cgi?id=360666
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> The referenced bug says that, by default, there is no file overwrite check 
> when using QFileDialog to save a file.  Indeed, on closer investigating it 
> appears that there is no way to even explictly force an overwrite check when 
> using the KDE platform theme, because of this code in 
> plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
> 
> // overwrite option
> if 
> (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
>  {
> dialog->m_fileWidget->setConfirmOverwrite(false);
> }
> 
> The default for KFileWidget is already for no overwrite check (as set in 
> kio/src/filewidgets/kfilewidget.cpp which initialises 
> KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
> this from the calling application through the platform plugin.
> 
> Suggest that the default option should be the same as that defined by Qt for 
> QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
> has set the QFileDialog::DontConfirmOverwrite option.  This is also a 
> sensible default to have from the user's point of view.  This change does 
> that in the platform theme plugin, for all saving operations.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
>   tests/qfiledialogtest.cpp 1d69ea1 
> 
> Diff: https://git.reviewboard.kde.org/r/127944/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-intergration with this change, confirmed correct operation of 
> file dialogues and that confirmation is requested when overwriting an 
> existing file, unless the QFileDialog::DontConfirmOverwrite option is 
> specified.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten



> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your 
> > change, but the test passed nevertheless.
> 
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.

Now I see that there are autotests after all.  How do I run them?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
---


On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> ---
> 
> (Updated May 17, 2016, 3:20 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 360666
> https://bugs.kde.org/show_bug.cgi?id=360666
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> The referenced bug says that, by default, there is no file overwrite check 
> when using QFileDialog to save a file.  Indeed, on closer investigating it 
> appears that there is no way to even explictly force an overwrite check when 
> using the KDE platform theme, because of this code in 
> plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
> 
> // overwrite option
> if 
> (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
>  {
> dialog->m_fileWidget->setConfirmOverwrite(false);
> }
> 
> The default for KFileWidget is already for no overwrite check (as set in 
> kio/src/filewidgets/kfilewidget.cpp which initialises 
> KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
> this from the calling application through the platform plugin.
> 
> Suggest that the default option should be the same as that defined by Qt for 
> QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
> has set the QFileDialog::DontConfirmOverwrite option.  This is also a 
> sensible default to have from the user's point of view.  This change does 
> that in the platform theme plugin, for all saving operations.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
>   tests/qfiledialogtest.cpp 1d69ea1 
> 
> Diff: https://git.reviewboard.kde.org/r/127944/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-intergration with this change, confirmed correct operation of 
> file dialogues and that confirmation is requested when overwriting an 
> existing file, unless the QFileDialog::DontConfirmOverwrite option is 
> specified.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten



> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote:
> > The change looks sensible to me, but I would appreciate a test case for it. 
> > There are already some tests for the file dialog, so it should be easy to 
> > extend.

There is no autotest, but have updated tests/qfiledialogtest with options 
'--confirmOverwrite' (on or off) and '--nativeDialog' (on or off).  Checked 
operation of these options and overwrite warning.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95532
---


On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> ---
> 
> (Updated May 17, 2016, 3:20 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 360666
> https://bugs.kde.org/show_bug.cgi?id=360666
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> The referenced bug says that, by default, there is no file overwrite check 
> when using QFileDialog to save a file.  Indeed, on closer investigating it 
> appears that there is no way to even explictly force an overwrite check when 
> using the KDE platform theme, because of this code in 
> plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
> 
> // overwrite option
> if 
> (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
>  {
> dialog->m_fileWidget->setConfirmOverwrite(false);
> }
> 
> The default for KFileWidget is already for no overwrite check (as set in 
> kio/src/filewidgets/kfilewidget.cpp which initialises 
> KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
> this from the calling application through the platform plugin.
> 
> Suggest that the default option should be the same as that defined by Qt for 
> QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
> has set the QFileDialog::DontConfirmOverwrite option.  This is also a 
> sensible default to have from the user's point of view.  This change does 
> that in the platform theme plugin, for all saving operations.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
>   tests/qfiledialogtest.cpp 1d69ea1 
> 
> Diff: https://git.reviewboard.kde.org/r/127944/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-intergration with this change, confirmed correct operation of 
> file dialogues and that confirmation is requested when overwriting an 
> existing file, unless the QFileDialog::DontConfirmOverwrite option is 
> specified.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---

(Updated May 17, 2016, 3:20 p.m.)


Review request for kde-workspace and Plasma.


Changes
---

Added test


Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666


Repository: plasma-integration


Description
---

The referenced bug says that, by default, there is no file overwrite check when 
using QFileDialog to save a file.  Indeed, on closer investigating it appears 
that there is no way to even explictly force an overwrite check when using the 
KDE platform theme, because of this code in 
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:

// overwrite option
if 
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
 {
dialog->m_fileWidget->setConfirmOverwrite(false);
}

The default for KFileWidget is already for no overwrite check (as set in 
kio/src/filewidgets/kfilewidget.cpp which initialises 
KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
this from the calling application through the platform plugin.

Suggest that the default option should be the same as that defined by Qt for 
QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
has set the QFileDialog::DontConfirmOverwrite option.  This is also a sensible 
default to have from the user's point of view.  This change does that in the 
platform theme plugin, for all saving operations.


Diffs (updated)
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 
  tests/qfiledialogtest.cpp 1d69ea1 

Diff: https://git.reviewboard.kde.org/r/127944/diff/


Testing
---

Built plasma-intergration with this change, confirmed correct operation of file 
dialogues and that confirmation is requested when overwriting an existing file, 
unless the QFileDialog::DontConfirmOverwrite option is specified.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---

Review request for kde-workspace and Plasma.


Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666


Repository: plasma-integration


Description
---

The referenced bug says that, by default, there is no file overwrite check when 
using QFileDialog to save a file.  Indeed, on closer investigating it appears 
that there is no way to even explictly force an overwrite check when using the 
KDE platform theme, because of this code in 
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:

// overwrite option
if 
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
 {
dialog->m_fileWidget->setConfirmOverwrite(false);
}

The default for KFileWidget is already for no overwrite check (as set in 
kio/src/filewidgets/kfilewidget.cpp which initialises 
KFileWidgetPrivate::confirmOverwrite to false).  There is no way to override 
this from the calling application through the platform plugin.

Suggest that the default option should be the same as that defined by Qt for 
QFileDialog:  always perform an ovewrwrite check on saving, unless the caller 
has set the QFileDialog::DontConfirmOverwrite option.  This is also a sensible 
default to have from the user's point of view.  This change does that in the 
platform theme plugin, for all saving operations.


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d 

Diff: https://git.reviewboard.kde.org/r/127944/diff/


Testing
---

Built plasma-intergration with this change, confirmed correct operation of file 
dialogues and that confirmation is requested when overwriting an existing file, 
unless the QFileDialog::DontConfirmOverwrite option is specified.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-26 Thread Jonathan Marten

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
---

(Updated Jan. 27, 2016, 6:56 a.m.)

Status
--

This change has been marked as submitted.

Review request for Plasma and KDE Usability.

Changes
---

Submitted with commit 3546406db06600ff61132085e08366d62cbab53f by Jonathan
Marten to branch master.

Repository: plasma-desktop

Description
---

In Plasma 5 this KCM only lists the names of the available runners, with no
explanation of what they do. In its previous incarnation in KDE4 (the dropdown
list from the runner config button), the descriptions were displayed. This
change restores them.

Diffs
-

kcms/runners/kcm.h f1239ee
kcms/runners/kcm.cpp 4af82de

Diff: https://git.reviewboard.kde.org/r/126300/diff/

Testing
---

Built plasma-desktop with this change, checked appearance of KCM in Breeze,
Oxygen and older styles.

File Attachments

Screenshot before

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines elided

https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png

Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-24 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review91537
---



Ping anyone?

- Jonathan Marten


On Jan. 10, 2016, 4:33 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> ---
> 
> (Updated Jan. 10, 2016, 4:33 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no 
> explanation of what they do.  In its previous incarnation in KDE4 (the 
> dropdown list from the runner config button), the descriptions were 
> displayed.  This change restores them.
> 
> 
> Diffs
> -
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
> Oxygen and older styles.
> 
> 
> File Attachments
> 
> 
> Screenshot before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines elided
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-10 Thread Jonathan Marten

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
---

(Updated Jan. 10, 2016, 4:33 p.m.)

Review request for Plasma and KDE Usability.

Changes
---

Long description lines elided with "..." instead of simply truncated,
screenshot updated.

Not sure if it's possible to show a tool tip only if the description is
truncated, since the width calculation is done while painting in the item
delegate but the tool tip would have to be set when the items are statically
created in SearchConfigModule::load(). So the options would be to have either
no tool tip, or a tool tip for everything even if the text is not truncated.
Since the "Control Audio Player" example seems to be the only one that gets
truncated in a standard Plasma5 install with the standard dialogue and font
sizes, I'm not sure it is worth addressing.

Repository: plasma-desktop

Description
---

Diffs (updated)
-

kcms/runners/kcm.h f1239ee
kcms/runners/kcm.cpp 4af82de

Diff: https://git.reviewboard.kde.org/r/126300/diff/

Testing
---

Built plasma-desktop with this change, checked appearance of KCM in Breeze,
Oxygen and older styles.

File Attachments (updated)

Screenshot before

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines elided

https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png

Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126300: Plasma Search KCM: display the runner descriptions

2015-12-10 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

In Plasma 5 this KCM only lists the names of the available runners, with no 
explanation of what they do.  In its previous incarnation in KDE4 (the dropdown 
list from the runner config button), the descriptions were displayed.  This 
change restores them.


Diffs
-

  kcms/runners/kcm.h f1239ee454cf40c3721743d5c771b4686d449d21 
  kcms/runners/kcm.cpp 4af82de9c385725a23cc09a074c5803f11a7945f 

Diff: https://git.reviewboard.kde.org/r/126300/diff/


Testing
---

Built plasma-desktop with this change, checked appearance of KCM in Breeze, 
Oxygen and older styles.


File Attachments


Screenshot before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/
---

(Updated Nov. 9, 2015, 1:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 78f02ac2ed40e88d6f069f35794d991b40a33139 by Jonathan 
Marten to branch master.


Bugs: 354984
https://bugs.kde.org/show_bug.cgi?id=354984


Repository: plasma-desktop


Description
---

See the referenced bug.  The special locale value "C" needs to be written out 
as simply that and not with an encoding suffix added, otherwise the resulting 
value is not accepted by the locale system.


Diffs
-

  kcms/formats/kcmformats.cpp ea9dece 

Diff: https://git.reviewboard.kde.org/r/125984/diff/


Testing
---

Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, 
checked correct operation of desktop and of CLI and GUI applications.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/
---

(Updated Nov. 9, 2015, 8:28 a.m.)


Review request for Plasma.


Changes
---

Corrected...


Bugs: 354984
https://bugs.kde.org/show_bug.cgi?id=354984


Repository: plasma-desktop


Description
---

See the referenced bug.  The special locale value "C" needs to be written out 
as simply that and not with an encoding suffix added, otherwise the resulting 
value is not accepted by the locale system.


Diffs (updated)
-

  kcms/formats/kcmformats.cpp ea9dece 

Diff: https://git.reviewboard.kde.org/r/125984/diff/


Testing
---

Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, 
checked correct operation of desktop and of CLI and GUI applications.


Thanks,

Jonathan Marten

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-07 Thread Jonathan Marten



> On Nov. 7, 2015, 1:48 p.m., Sebastian Kügler wrote:
> > kcms/formats/kcmformats.cpp, line 124
> > <https://git.reviewboard.kde.org/r/125984/diff/1/?file=415684#file415684line124>
> >
> > spaces around the comparison operator, please.

OK, will correct.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/#review88137
---


On Nov. 7, 2015, 1:14 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125984/
> ---
> 
> (Updated Nov. 7, 2015, 1:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 354984
> https://bugs.kde.org/show_bug.cgi?id=354984
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> See the referenced bug.  The special locale value "C" needs to be written out 
> as simply that and not with an encoding suffix added, otherwise the resulting 
> value is not accepted by the locale system.
> 
> 
> Diffs
> -
> 
>   kcms/formats/kcmformats.cpp ea9dece 
> 
> Diff: https://git.reviewboard.kde.org/r/125984/diff/
> 
> 
> Testing
> ---
> 
> Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, 
> checked correct operation of desktop and of CLI and GUI applications.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

1 2 >

1 - 100 of 112 matches

Mail list logo