Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- (Updated Feb. 8, 2017, 2:32 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong Diffs - applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45 applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 applets/binary-clock/package/contents/config/config.qml PRE-CREATION applets/binary-clock/package/contents/config/main.xml PRE-CREATION applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION applets/binary-clock/package/contents/ui/main.qml PRE-CREATION applets/binary-clock/plasma-applet-binaryclock.desktop 9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5 Diff: https://git.reviewboard.kde.org/r/120325/diff/ Testing --- It works on the desktop, but the dots are too small in the panel Thanks, Joseph Wenninger
Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- (Updated Okt. 1, 2014, 8:21 nachm.) Review request for Plasma. Changes --- ColumnLayout, GridLayout, less whitespaces. Okay to push and fix the panel layout later on? Repository: kdeplasma-addons Description --- port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong Diffs (updated) - applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45 applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 applets/binary-clock/package/contents/config/config.qml PRE-CREATION applets/binary-clock/package/contents/config/main.xml PRE-CREATION applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION applets/binary-clock/package/contents/ui/main.qml PRE-CREATION applets/binary-clock/plasma-applet-binaryclock.desktop 9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5 Diff: https://git.reviewboard.kde.org/r/120325/diff/ Testing --- It works on the desktop, but the dots are too small in the panel Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
> On Sept. 23, 2014, 8:47 vorm., Marco Martin wrote: > > applets/binary-clock/package/contents/ui/BinaryClock.qml, line 39 > > <https://git.reviewboard.kde.org/r/120325/diff/1/?file=314629#file314629line39> > > > > perhaps the reason it looks too small in panels is that should use > > main.height instead of Layout.height? Panel layout still needs some work - Joseph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review67274 --- On Okt. 1, 2014, 8:21 nachm., Joseph Wenninger wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120325/ > --- > > (Updated Okt. 1, 2014, 8:21 nachm.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > port of the kde4 c++ based binary clock to kf5/qml only. It works on the > desktop, but some sizing/dot sizeing issues exist in the panels. At least it > is a start > > I'd like somebody to have a look at it to tell me, if I'm on the right way or > if I'm completely wrong > > > Diffs > - > > applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 > applets/binary-clock/CMakeLists.txt > b42a6e76752af3cc800ad5455ba0678a18a0ce45 > applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 > applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 > applets/binary-clock/binaryclock.cpp > 75c4548588ff15e2316dd1c2e888ad8c07f7f78b > applets/binary-clock/clockConfig.ui > 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 > applets/binary-clock/package/contents/config/config.qml PRE-CREATION > applets/binary-clock/package/contents/config/main.xml PRE-CREATION > applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION > applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION > applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION > applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION > applets/binary-clock/package/contents/ui/main.qml PRE-CREATION > applets/binary-clock/plasma-applet-binaryclock.desktop > 9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5 > > Diff: https://git.reviewboard.kde.org/r/120325/diff/ > > > Testing > --- > > It works on the desktop, but the dots are too small in the panel > > > Thanks, > > Joseph Wenninger > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong Diffs - applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 applets/CMakeLists.txt 38751705f0b712ee8ce6861a7d437402be480873 applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45 applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION applets/binary-clock/package/contents/ui/main.qml PRE-CREATION applets/binary-clock/plasma-applet-binaryclock.desktop 10bd99b0518873f819ae89c9e9b9e09d9eb3490e applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 applets/binary-clock/package/contents/config/config.qml PRE-CREATION applets/binary-clock/package/contents/config/main.xml PRE-CREATION applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b Diff: https://git.reviewboard.kde.org/r/120325/diff/ Testing --- It works on the desktop, but the dots are too small in the panel Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models
rameworks/plasma-framework/src/declarativeimports/core/datasource.h:43 #30 0x7f2f2dfac8b8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 #31 0x7f2f2dfac8e8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 Diffs - src/declarativeimports/core/datasource.cpp 2e7a2af4919f85bb385e95f2a29f9cdb5e7ecfda src/declarativeimports/core/datasource.h 3a8b522919f04f8581e98271aff55ccc001062c8 Diff: https://git.reviewboard.kde.org/r/120110/diff/ Testing --- This part of plasma shell does not cause a crash for me anymore. Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models
rameworks/plasma-framework/src/declarativeimports/core/datasource.h:43 #30 0x7f2f2dfac8b8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 #31 0x7f2f2dfac8e8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 Diffs (updated) - src/declarativeimports/core/datasource.cpp 2e7a2af4919f85bb385e95f2a29f9cdb5e7ecfda src/declarativeimports/core/datasource.h 3a8b522919f04f8581e98271aff55ccc001062c8 Diff: https://git.reviewboard.kde.org/r/120110/diff/ Testing --- This part of plasma shell does not cause a crash for me anymore. Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models
mework/src/declarativeimports/core/datasource.h:43 #30 0x7f2f2dfac8b8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 #31 0x7f2f2dfac8e8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 Diffs (updated) - src/declarativeimports/core/datasource.h 3a8b522919f04f8581e98271aff55ccc001062c8 src/declarativeimports/core/datasource.cpp 2e7a2af4919f85bb385e95f2a29f9cdb5e7ecfda Diff: https://git.reviewboard.kde.org/r/120110/diff/ Testing --- This part of plasma shell does not cause a crash for me anymore. Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models
> On Sept. 9, 2014, 9:04 vorm., David Edmundson wrote: > > src/declarativeimports/core/datasource.cpp, line 171 > > <https://git.reviewboard.kde.org/r/120110/diff/1/?file=310511#file310511line171> > > > > Nice work identifying the cause, but I think we can improve the fix. > > > > We were calling this lambda after the datasource object is deleted so > > this (and therefore m_models) is pointing to random memory, we just happen > > to be resetting the random memory to zero just beforehand, but it's not a > > fix that is going to work for long. > > > > It's interesting that there's a model that outlives the datasource, > > that implies a buggy datasource somewhere... but we need to fix this too. > > > > It could be solved by using a normal slot so we get automatic > > disconnect wheh the receiver is destroyed. > > > > Can probably be done with better lambdas but I don't know how. With a traditional slot the model has to have a property telling it's sourcename or we need a second inverse map. If I'm not mistaken, QQMLPropertyMap does not allow lookups or item removals by the value, but only by key. The first solution makes it more difficult for users of the API, the second solution isn't that nice either. What would be your idea to keep track of the sourcename for a model being deleted. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/#review66098 --- On Sept. 9, 2014, 8:15 vorm., Joseph Wenninger wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120110/ > --- > > (Updated Sept. 9, 2014, 8:15 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Fix a crash when shutting down plasma shell, while destruction models > > > While porting the kate session applet to plasma KF5, I noticed plasmashell > crashing while using "kquitapp5 plasmashell" while destroying the model in > the clipboard engine and in my engine (which is based on the clipboard > engine). > > The problem for me was, that the lambda in Plasma::DataEngine:167 accessed > m_models, which was/is not valid anymore. > > Thread 1 (Thread 0x7f2f4cadb880 (LWP 4241)): > [KCrash Handler] > #6 0x7f2f488336df in QQmlOpenMetaObject::setValue(QByteArray const&, > QVariant const&) () from /home/jowenn/KDE/qt5/qtbase/lib/libQt5Qml.so.5 > #7 0x7f2f486c6d14 in QQmlPropertyMap::clear(QString const&) () from > /home/jowenn/KDE/qt5/qtbase/lib/libQt5Qml.so.5 > #8 0x7f2f2dfb94e4 in Plasma::DataSourceoperator()(void) > const (__closure=0x7fffb8e86670) at > /home/jowenn/KDE/kf5/src/frameworks/plasma-framework/src/declarativeimports/core/datasource.cpp:167 > #9 0x7f2f2dfb9b88 in QtPrivate::FunctorCall, > QtPrivate::List<>, void, Plasma::DataSource::modelChanged(const QString&, > QAbstractItemModel*):: >::call(Plasma::DataSource::, void > **) (f=..., arg=0x7fffb8e86800) at > /home/jowenn/KDE/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:502 > #10 0x7f2f2dfb9b5e in > QtPrivate::Functor QAbstractItemModel*)::, 0>::call, > void>(Plasma::DataSource:: &, void *, void **) (f=..., > arg=0x7fffb8e86800) at > /home/jowenn/KDE/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:559 > #11 0x7f2f2dfb9b13 in > QtPrivate::QFunctorSlotObject QString&, QAbstractItemModel*)::, 0, QtPrivate::List<>, > void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void **, bool *) > (which=1, this_=0x56aee80, r=0x5776340, a=0x7fffb8e86800, ret=0x0) at > /home/jowenn/KDE/qt5/qtbase/src/corelib/kernel/qobject_impl.h:200 > #12 0x7f2f459656be in QMetaObject::activate(QObject*, int, int, void**) > () from /home/jowenn/KDE/qt5/qtbase/lib/libQt5Core.so.5 > #13 0x7f2f4596609f in QObject::destroyed(QObject*) () from > /home/jowenn/KDE/qt5/qtbase/lib/libQt5Core.so.5 > #14 0x7f2f4596d70b in QObject::~QObject() () from > /home/jowenn/KDE/qt5/qtbase/lib/libQt5Core.so.5 > #15 0x7f2f458ddd1d in QAbstractItemModel::~QAbstractItemModel() () from > /home/jowenn/KDE/qt5/qtbase/lib/libQt5Core.so.5 > #16 0x7f2e401af49e in KateSessionsModel::~KateSessionsModel > (this=0x5776340, __in_chrg=) at > /home/jowenn/KDE/kf5/src/kde/applications/kate/addons/sessionap
Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models
QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 #31 0x7f2f2dfac8e8 in QQmlPrivate::QQmlElement::~QQmlElement (this=0x552c060, __in_chrg=) at /home/jowenn/KDE/qt5/qtdeclarative/src/qml/qml/qqmlprivate.h:106 Diffs - src/declarativeimports/core/datasource.h 3a8b522919f04f8581e98271aff55ccc001062c8 src/declarativeimports/core/datasource.cpp 2e7a2af4919f85bb385e95f2a29f9cdb5e7ecfda Diff: https://git.reviewboard.kde.org/r/120110/diff/ Testing --- This part of plasma shell does not cause a crash for me anymore. Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
