Re: Workaround in WebView...

[Kenneth Christiansen]

I will try to search for it :-) I get hundreds of bug e-mails per day :-)

Kenneth

On Tue, Mar 23, 2010 at 2:51 PM, Aaron J. Seigo  wrote:
> On March 23, 2010, Kenneth Christiansen wrote:
>> Would be nice if you could point out there places you found it to be
>> using the QGraphicsView wrongly. Some of the issues are due to us
>> having to keep supporting QWebView which can make it tricky at times,
>> so if you find any issue, please let us know.
>
> gladly. and as noted, i did file a bug report on this issue, with a detailed
> explanation of what goes wrong and why, on the QtWebkit bug tracker. you even
> commented on it. :)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Senior Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Workaround in WebView...

[Kenneth Christiansen]

Would be nice if you could point out there places you found it to be
using the QGraphicsView wrongly. Some of the issues are due to us
having to keep supporting QWebView which can make it tricky at times,
so if you find any issue, please let us know.

Kenneth

> i did. with code showing the problem, minutes after committing the work around
> to libplasma so at least plasma-desktop wouldn't crash horribly.
>
> nor was i the only one to do so: there's a near duplicate report that's also
> been triaged. it's not quite the same crash, but has the same underlying
> reason.
>
> since we're handing out advice to each other, let's try this: in future those
> working on webkit and/or qgraphicsview might wish to test things like "let's
> open a combobox on a qwebpage that's in a qgraphicsscene" before making a
> release?
>
> the number of these kinds of very basic yet critical (e.g. crash causing)
> problems that are making it into Qt releases is discouraging.
>
> this one wasn't the result of some accidental interaction between two Qt
> modules (QtWebkit and QGraphicsView), this was the result of a very poor
> implementation of QGraphicsView support inside of QtWebkit. it is/was code in
> QtWebkit that specifically uses QGraphicsView and which was full of
> assumptions that was quite plainly and obviously (just from reading the code,
> not even from testing) _wrong_.
>
> if it were simply a matter of "the plasma guys put QtWebkit and QGraphicsView
> together in a way we didn't expect" i'd be more charitable about the
> situation. but this is a crash that was introduced by Qt hackers working on
> integrating two Qt modules.
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Senior Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Webslice applet moved to kdereview

[Kenneth Christiansen]

Qt 4.6 has QGraphicsWebView :-) which is a QGraphicsWidget. If we
would make a QGraphics version of, lets say, QLineEdit, it would
probably be called QGraphicsLineEdit and not QGraphicsLineEditWidget.
That was more or less the consensus we had when naming the
QGraphicsWebView (which was renamed some times along the way :-))

If you go with KGraphics, I would prefer KGraphicsWebSlide.

Cheers!

On Thu, Nov 12, 2009 at 11:05 PM, Aaron J. Seigo  wrote:
> On November 12, 2009, Kenneth Christiansen wrote:
>> Plasma widgets are by default GraphicsItems right? So what about
>> Plasma::WebSlice? and then call the QWidget for KWebSlide?
>
> +1 on Plasma::WebSlice if it goes into libplasma; otherwise
> KGraphicsWebSliceWidget to go the route of the Qt naming of
> QGraphics[Item|Widget]
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Webslice applet moved to kdereview

[Kenneth Christiansen]

Hi there,

Cool stuff. I don't know about the Plasma naming, but we are trying to
not call anything but base classes for *Widget.

Plasma widgets are by default GraphicsItems right? So what about
Plasma::WebSlice? and then call the QWidget for KWebSlide?

Just a suggestion :-)

Kenneth

On Thu, Nov 12, 2009 at 9:51 PM, Sebastian Kügler  wrote:
> Hey,
>
> I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4.
>
> The webslice applet is there to put an interactive part of a webpage onto 
> Plasma as
> an applet.
>
> You can specify an element with a CSS selector (a.k.a. the nice way) or by its
> geometry (the way that works for semantically-not-so-nice webpages, but can 
> easily
> break). This can be handy if you want to monitor only the news box on a 
> webpage, for
> example.
>
> The webslice widget uses Qt WebKit for rendering the element and is fully
> interactive. I'm planning to make use of the KDE integration soon that has 
> just
> entered kdelibs, so we also share cookies and login information.
>
> There are two widgets coming along with this. First, a SliceGraphicsWidget 
> which is
> used inside the plasmoid, and a QWidget, which basically wraps the
> SliceGraphicsWidget. Those are possible candidates for inclusion into 
> kdelibs, if
> other developers want to use this as well. If you use the qmake-based build, 
> you get
> a small binary you can play around with.
>
> The webslice plasmoid has been written by Richard Moore and me with the help 
> of some
> of the qtwebkit guys and is another early part of Silk we'd like to see 
> merged.
>
> Please let me know if there's anything wrong with it, or where you see room 
> for
> improvement and I'll address it.
>
> Thanks,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QWebFrame and baseUrl

[Kenneth Christiansen]

Hi again.

I talked to Thiago Macieira and he told me that QUrl in 4.6 is more
strict than in 4.5, but there isn't any behaviour change.

Can you please give me examples that stopped working?

cc'ing Thiago.

Cheers,
Kenneth

On Mon, Nov 9, 2009 at 5:28 PM, Aaron J. Seigo  wrote:
> On November 9, 2009, Kenneth Christiansen wrote:
>> So I wonder why this stopped working, if this is due to a QUrl change,
>> due to our change or due to a change in WebKit itself.
>
> yes, with a switch to KUrl it apparently started working (URLs with #s in them
> were one issue iirc?)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QWebFrame and baseUrl

[Kenneth Christiansen]

Hi there,

Strange...

We merely fixed the behavior to be as expected and documented.

setHtml was totally broken. It was adding the baseurl to the session
history if one was supplied, and not adding anything if nothing was
supplied. That has now been fixed.

So I wonder why this stopped working, if this is due to a QUrl change,
due to our change or due to a change in WebKit itself.

Can you please add a bug to bugs.webkit.org ?

Kenneth

On Wed, Nov 4, 2009 at 2:39 PM, Aaron J. Seigo  wrote:
> On November 4, 2009, Marco Martin wrote:
>> anyways, the patch looks good
>
> yes, please commit (and grrr! to the trolls for changing behaviour like this)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Tokamak 4 dates

[Kenneth Christiansen]

So do you guys need a WebKit guy around :-) ?

Cheers,
Kenneth

On Mon, Oct 5, 2009 at 7:44 AM, Sebastian Kügler  wrote:
> Hey fellow Plasmoids,
>
> As you've heard, Tokamak4 will take place in Nürnberg, Germany in and around 
> the
> openSuse offices. The next step to make it happen is finding a date. From 
> what I
> understand, the second half of February seems like a good time. KDE 4.4 will 
> be
> released beginning of February, so this would fall nicely at the beginning of 
> the 4.5
> cycle.
>
> So, how about we start on Feb. 19th and the last people depart on the 26th? 
> (That's
> Friday to Friday.)
>
> Any other proposals for a date?
>
> Also, who here would like to attend?
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: WebView Kinetic Scrolling

[Kenneth Christiansen]

> this whas added to achieve scrolling by flicking (even in an animate way, by
> dragging fastly the webview and "launching" it)
> right now is done by a private class (right now with timers, will be ported to
> kinetic) that sets the scrollvalue properties to achieve that.
> seems a sane approach?

So you need separate methods for each orientation? That might not be
very efficient as it will result in two different scrolls. I'm also
asking because I believe we have a scroll(int dx, int dy) method
somewhere (probably QWebFrame)

> also this behaiur would make sense at lower levels in qt or perhaps is better
> that gets implemented by users of qgraphicswebwiew?

It is a graphicsitem after all, so it will actually have a scroll
method already that takes a dx, dy and an area (defaults to the
boundingRect). Could you use this instead?

> as for make plasma::webview use qgraphicswebwiew:
> -keep both, separate implementations (uugly :)
> -webview subclassesqgraphicswebwiew (aaah, bic)
> -webview is an empty qgraphicswidget that contains nothing but a

> qgraphicswebwiew: i think despite ugly it's the only feasible option?

I guess so, unfortunately.

-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: WebView Kinetic Scrolling

[Kenneth Christiansen]

> api wise of course it doesn't have much, because as our plasma one just wraps
> the most useful functions of qwebframe and qwebpage,, however just taking a
> quick look...

I saw that you have added some extra API like setHorizontalScroll or
something similar. If you have some extra methods that you need and
think are generally useful, please discuss them with us :-)

> progressChanged() signal. we and qwebpage too use loadProgress() maybe using
> the same name for consitency?

I will take that up at our next API review, thanks.

> isInteractive() is isContentEditable() of qwebpage? if it is they should be
> called the same way, if not what is the difference?

Nope, it is like in the DUI and in the QGraphicsScene. It simply
blocks events (mouse etc) from reaching the page.

> atm i can't come up with other stuff :)

OK :-) If you come up with something, ping me at #qtwebkit (freenode)
or just e-mail me.

Thanks!
Kenneth
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: WebView Kinetic Scrolling

[Kenneth Christiansen]

Would be cool if you guys could have a look at the QGraphicsWebView in
WebKit trunk, so we can get feedback on the API before we release it
with Qt 4.6.

Cheers,
Kenneth

On Sat, Oct 3, 2009 at 10:16 AM, Marco Martin  wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1764/#review2534
> ---
>
> Ship it!
>
>
> apart a couple of stye issues it's ok
>
>
> trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> 
>
>    if (event->pos().x()
>
>
>
> trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> 
>
>    if (me.isAccepted()) {
>
>
>
> trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> 
>
>    also there, no spaces
>
>
> - Marco
>
>
> On 2009-10-03 13:07:41, igorto wrote:
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/1764/
>> ---
>>
>> (Updated 2009-10-03 13:07:41)
>>
>>
>> Review request for Plasma, Aaron Seigo, Marco Martin, and Adenilson 
>> Cavalcanti.
>>
>>
>> Summary
>> ---
>>
>> Add support for kinetic scrolling in webview widget.
>>
>> TODO:
>>
>> -Make Horizontal Kinetic Scrolling works
>>
>>
>> Diffs
>> -
>>
>>   trunk/KDE/kdelibs/plasma/widgets/webview.h 1030897
>>   trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1030897
>>
>> Diff: http://reviewboard.kde.org/r/1764/diff
>>
>>
>> Testing
>> ---
>>
>> webbrowser
>>
>>
>> Thanks,
>>
>> igorto
>>
>>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasmate Proposal - added some changes and screenshots

[Kenneth Christiansen]

Any change of QtCreator (/KDevelop) integration?

Looks pretty nice btw :-)

Cheers,
Kenneth

On Tue, Mar 31, 2009 at 6:21 PM, Diego Casella  wrote:
> Hello guys,
> I made some changes on my PlasMate proposal, and also I added a screenshot
> about the main window ( I think the element placement
> is pretty nice and clean =P ).
> In this moment it only opens a file, and shows it in the editor field;
> however take a look and tell me your impressions.
> http://socghop.appspot.com/document/show/user/diego_casella/plasmate
>
> Best regards,
>
> Diego.
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel