Re: KPipeWire dependency

[Luca Beltrame]

In data martedì 31 maggio 2022 13:53:43 CEST, Aleix Pol ha scritto:
> Sorry didn't see your e-mail, I addressed it yesterday.

With these changes I was able to package KPipeWire successfully. Two more 
minor nits:

- PROJECT_VERSION is not the same as the other Plasma projects in master 
(instead of 5.25.xxx it's 5.24.xxx).
- A very basic README would be useful.

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: KPipeWire dependency

[Luca Beltrame]

In data lunedì 30 maggio 2022 13:04:35 CEST, Aleix Pol ha scritto:

Hello Aleix,

> Addressed most "reuse lint" warnings in there.
> Thanks for pointing it out!

Thanks for fixing. While packaging it for openSUSE I've noticed that it 
installs libKPipeWire.so and libKPipeWireRecord.so, but the libraries don't 
have any soversion set. Are they meant to be used as shared libraries? If so, 
can this be addressed?

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: KPipeWire dependency

[Luca Beltrame]

In data lunedì 30 maggio 2022 02:08:25 CEST, Aleix Pol ha scritto:

Hello Aleix,

> This means it becomes a dependency for the master branch and thus the
> unstable builds.

KiPipeWire does not ship a license in its repository: would you be able to add 
one? Or packaging it would not be possible.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

ksystemstats tests failing?

[Luca Beltrame]

Hello,

when building on the OBS, the tests in ksystemstats have been failing for a 
couple of days:

Running tests...
[   92s] /usr/bin/ctest --force-new-ctest-process 
[   92s] Test project /home/abuild/rpmbuild/BUILD/ksystemstats-5.22.80git.
20210527T155341~6abf71d/build
[   92s] Start 1: ksystemstatstest
[   92s] 1/1 Test #1: ksystemstatstest .***Failed0.03 sec
[   92s] * Start testing of KStatsTest *
[   92s] Config: Using QtTest library 5.15.2, Qt 5.15.2 (x86_64-little_endian-
lp64 shared (dynamic) release build; by GCC 10.3.0), unknown unknown
[   92s] PASS   : KStatsTest::initTestCase()
[   92s] FAIL!  : KStatsTest::findById() 'findSensor("testContainer/
testObject/property1")' returned FALSE. ()
[   92s]Loc: [/home/abuild/rpmbuild/BUILD/ksystemstats-5.22.80git.
20210527T155341~6abf71d/autotests/main.cpp(99)]
[   92s] PASS   : KStatsTest::update()
[   92s] PASS   : KStatsTest::subscription()
[   92s] PASS   : KStatsTest::changes()
[   92s] FAIL!  : KStatsTest::dbusApi() 'sensors.count() == 4' returned FALSE. 
()
[   92s]Loc: [/home/abuild/rpmbuild/BUILD/ksystemstats-5.22.80git.
20210527T155341~6abf71d/autotests/main.cpp(152)]
[   92s] PASS   : KStatsTest::cleanupTestCase()
[   92s] Totals: 5 passed, 2 failed, 0 skipped, 0 blacklisted, 2ms
[   92s] * Finished testing of KStatsTest *

The question mark is because I'm not sure if it's something local to the build 
environment, or an actual problem with the test themselves.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

[plasma/plasma-workspace] components/containmentlayoutmanager: Revert "don't make config key change and size change conflict"

[Luca Beltrame]

Git commit ea95ebd0cdc8991938994daadaccea883ceabacc by Luca Beltrame.
Committed on 24/04/2021 at 22:15.
Pushed by lbeltrame into branch 'master'.

Revert "don't make config key change and size change conflict"

This reverts commit 156509b785b6b4312d984841f9ba6375687389d3.

At least this prevents plasmashell from crashing until a solution is
found.

CCMAIL: notm...@gmail.com
CCMAIL: plasma-devel@kde.org
CCBUG: 436041

M  +32   -58   components/containmentlayoutmanager/appletslayout.cpp
M  +2-22   components/containmentlayoutmanager/appletslayout.h

https://invent.kde.org/plasma/plasma-workspace/commit/ea95ebd0cdc8991938994daadaccea883ceabacc

diff --git a/components/containmentlayoutmanager/appletslayout.cpp 
b/components/containmentlayoutmanager/appletslayout.cpp
index 64de4006c..c9cf2ebca 100644
--- a/components/containmentlayoutmanager/appletslayout.cpp
+++ b/components/containmentlayoutmanager/appletslayout.cpp
@@ -47,11 +47,9 @@ AppletsLayout::AppletsLayout(QQuickItem *parent)
 connect(m_saveLayoutTimer, &QTimer::timeout, this, [this]() {
 // We can't save the layout during bootup, for performance reasons and 
to avoid race consitions as much as possible, so if we needto save and still 
starting up,
 // don't actually savenow, but we will when Corona::startupCompleted 
is emitted
-
 if (!m_configKey.isEmpty() && m_containment && 
m_containment->corona()->isStartupCompleted()) {
 const QString serializedConfig = 
m_layoutManager->serializeLayout();
 m_containment->config().writeEntry(m_configKey, serializedConfig);
-m_containment->config().writeEntry(m_fallbackConfigKey, 
serializedConfig);
 // FIXME: something more efficient
 m_layoutManager->parseLayout(serializedConfig);
 m_savedSize = size();
@@ -59,43 +57,44 @@ AppletsLayout::AppletsLayout(QQuickItem *parent)
 }
 });
 
-m_layoutChangeTimer = new QTimer(this);
-m_layoutChangeTimer->setSingleShot(true);
-m_layoutChangeTimer->setInterval(100);
-connect(m_layoutChangeTimer, &QTimer::timeout, this, [this]() {
-const QString &serializedConfig = 
m_containment->config().readEntry(m_configKey, "");
-if ((m_layoutChanges & ConfigKeyChange) && 
!serializedConfig.isEmpty()) {
-if (!m_configKey.isEmpty() && m_containment) {
-m_layoutManager->parseLayout(serializedConfig);
-
-if (width() > 0 && height() > 0) {
-m_layoutManager->resetLayoutFromConfig();
-m_savedSize = size();
-}
-}
-} else if (m_layoutChanges & SizeChange) {
-const QRect newGeom(x(), y(), width(), height());
-// The size has been restored from the last one it has been saved: 
restore that exact same layout
-if (newGeom.size() == m_savedSize) {
-m_layoutManager->resetLayoutFromConfig();
-
-// If the resize is consequence of a screen resolution change, 
queue a relayout maintaining the distance between screen edges
-} else if (!m_geometryBeforeResolutionChange.isEmpty()) {
-m_layoutManager->layoutGeometryChanged(newGeom, 
m_geometryBeforeResolutionChange);
-m_geometryBeforeResolutionChange = QRectF();
+m_configKeyChangeTimer = new QTimer(this);
+m_configKeyChangeTimer->setSingleShot(true);
+m_configKeyChangeTimer->setInterval(100);
+connect(m_configKeyChangeTimer, &QTimer::timeout, this, [this]() {
+if (!m_configKey.isEmpty() && m_containment) {
+
m_layoutManager->parseLayout(m_containment->config().readEntry(m_configKey, 
""));
 
-// Heuristically relayout items only when the plasma startup 
is fully completed
-} else {
-polish();
+if (width() > 0 && height() > 0) {
+m_layoutManager->resetLayoutFromConfig();
+m_savedSize = size();
 }
 }
-m_layoutChanges = NoChange;
 });
 m_pressAndHoldTimer = new QTimer(this);
 m_pressAndHoldTimer->setSingleShot(true);
 connect(m_pressAndHoldTimer, &QTimer::timeout, this, [this]() {
 setEditMode(true);
 });
+
+m_sizeSyncTimer = new QTimer(this);
+m_sizeSyncTimer->setSingleShot(true);
+m_sizeSyncTimer->setInterval(150);
+connect(m_sizeSyncTimer, &QTimer::timeout, this, [this]() {
+const QRect newGeom(x(), y(), width(), height());
+// The size has been restored from the last one it has been saved: 
restore that exact same layout
+if (newGeom.size() == m_savedSize) {
+m_layoutManager->resetLayoutFromConfig();
+
+// If the resize is cons

[plasma/plasma-desktop] containments/desktop/package/contents/ui: Revert "Save layouts per-resolution"

[Luca Beltrame]

Git commit 1d68bc118a1b0eb0e3ce1bc25c17c781cd6cead5 by Luca Beltrame.
Committed on 24/04/2021 at 22:15.
Pushed by lbeltrame into branch 'master'.

Revert "Save layouts per-resolution"

This reverts commit 1390b55188e032336a9e92fb74bd55260493f1eb.

At least this prevents plasmashell from crashing until a solution is
found.

CCMAIL: notm...@gmail.com
CCMAIL: plasma-devel@kde.org
CCBUG: 436041

M  +1-3containments/desktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1d68bc118a1b0eb0e3ce1bc25c17c781cd6cead5

diff --git a/containments/desktop/package/contents/ui/main.qml 
b/containments/desktop/package/contents/ui/main.qml
index 8960e078b..18c943901 100644
--- a/containments/desktop/package/contents/ui/main.qml
+++ b/containments/desktop/package/contents/ui/main.qml
@@ -277,9 +277,7 @@ FolderViewDropArea {
 id: appletsLayout
 anchors.fill: parent
 // NOTE: use plasmoid.availableScreenRect and not own width and height 
as they are updated not atomically
-configKey: "ItemGeometries-" + 
Math.round(plasmoid.screenGeometry.width) + "x" + 
Math.round(plasmoid.screenGeometry.height)
-fallbackConfigKey: plasmoid.availableScreenRect.width > 
plasmoid.availableScreenRect.height ? "ItemGeometriesHorizontal" : 
"ItemGeometriesVertical"
-
+configKey: plasmoid.availableScreenRect.width > 
plasmoid.availableScreenRect.height ? "ItemGeometriesHorizontal" : 
"ItemGeometriesVertical"
 containment: plasmoid
 editModeCondition: plasmoid.immutable
 ? ContainmentLayoutManager.AppletsLayout.Locked

Re: Gitlab and plasma dev

[Luca Beltrame]

In data lunedì 18 maggio 2020 15:48:34 CEST, Nate Graham ha scritto:

> discussions and announcements. That would help the signal-to-noise ratio
> stay high for the mailing list.

I'm of the opposite opinion: the mails don't affect me (they're sorted in 
subfolders by filters), but sometimes I've jumped in discussions and found 
regressions merely by reading mails as they arrived to the mailing lists.

Subscribing to everything would be a hassle, it is much easier through a ML 
(and filters help separating discussions from merge requests).


signature.asc
Description: This is a digitally signed message part.

D29752: Prefix disk name on size labels

[Luca Beltrame]

lbeltrame added a comment.


  I don't speak C that well, but it looks OK to me.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29752

To: davidedmundson, lbeltrame, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Please watch build statuses of dependent projects (was: Re: Manner in which kde-gtk-config development is conducted)

[Luca Beltrame]

In data sabato 21 marzo 2020 01:31:40 CET, Ben Cooksley ha scritto:

> Plasma community in general until I raised the matter by commenting on
> the original review - several days after the fact.

I take the opportunity to ask reviewers who review changes to watch for the 
impact of such changes on other dependent projects within KDE. Case in point: 
kaccounts-integration changes (which were reviewed, mind you, so this is not a 
blind push or something reckless)  which broke building / dependent projects 
several times over the course of the past week. 

This is something that even a pre-review CI won't help with, so lxr and 
careful approaches are the way to go. 

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> CMakeLists.txt:86
> +set(WEBENGINE_SCRIPTING_ENABLED FALSE)
> +if(Qt5WebEngineWidgets_FOUND AND Qt5WebChannel_FOUND)
> +set(WEBENGINE_SCRIPTING_ENABLED TRUE)

Should you add a message in case one of the two is not found?

REPOSITORY
  R111 KSysguard Library

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27347

To: fvogt, #plasma, davidedmundson
Cc: lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Luca Beltrame]

In data martedì 18 febbraio 2020 19:26:21 CET, Nate Graham ha scritto:

> Neon is already an OS, whether or not you want to admit it. It's
> installed from an ISO. A hardware vendor (Slimbook) is shipping it on

Erm, where did I say that in my reply? ;)  I merely say that going "Neon or 
else unsupported" is a very downstream-hostile attitude, already seen with 
other software ("my way or the highway" in these cases) such as Audacity or 
Anki (the latter being one of the most downstream-hostile projects I've ever 
known). 

(Neon suffers from the same "LTS problem" for everything that's not KDE-made 
software, FTR, but that's not the issue I want to raise here)


-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D27457: Move kcminit_startup and kded to plasma-session

[Luca Beltrame]

lbeltrame added a comment.


  This completely breaks startup in my system and in openQA:
  
  https://openqa.opensuse.org/tests/1177118#step/finish_desktop/6
  
  (Notice that there is *no* desktop loaded).
  
  Basically many programs that start early complain that the Qt plugin can't be 
found because they can't connect to the display (started too early?):
  
feb 17 23:38:40 leon kwalletd5[1661]: qt.qpa.xcb: could not connect to 
display
[...]
feb 17 23:38:40 leon kwalletd5[1661]: qt.qpa.plugin: Could not load the Qt 
platform plugin "xcb" in "" even though it was found.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson
Cc: lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Luca Beltrame]

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto:

> think KDE software should be presented to users. Basically, we
> acknowledge that Neon is already an actual OS--the "KDE OS"--and we

Please don't suggest such downstream-hostile solutions, in particular because 
this failing is entirely upstream. We have already plenty in FOSS, I don't 
want KDE to be yet another community that "adopts" them.

"We messed up so let's make things our way" is not an acceptable approach.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D9875: Extend parsing ssh prompt

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Just because the "accept" flag was cleared.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Luca Beltrame]

In data martedì 7 gennaio 2020 10:51:19 CET, David Edmundson ha scritto:

> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.

From the openSUSE side: +1. We're trying to get rid of Qt4 applications / libs 
/ whatever entirely and this is another nail in the coffin.

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

D24798: Migrate QQC1 to QQC2

[Luca Beltrame]

lbeltrame added a comment.


  Fixed in 47c76ebc83ee1f96c7a5fd9be23c6234a93143e8 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: lbeltrame, davidedmundson, GB_2, ahiemstra, broulik, kmaterka, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24798: Migrate QQC1 to QQC2

[Luca Beltrame]

lbeltrame added a comment.


  This change breaks SDDM theme loading. See 
https://bugs.kde.org/show_bug.cgi?id=414252.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: lbeltrame, davidedmundson, GB_2, ahiemstra, broulik, kmaterka, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24865: [SystemTray] Support for AttentionIcon

[Luca Beltrame]

lbeltrame added a comment.


  +1 to my untrained eye.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Luca Beltrame]

lbeltrame added a comment.


  Tested, works. +1.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D13881: oxygen-demo : add KMessage preview

[Luca Beltrame]

lbeltrame reopened this revision.
lbeltrame added a comment.


  This breaks when building the Oxygen style for Qt4 (which is still a 
supported build option AFAIK):
  
[   73s] 
/home/abuild/rpmbuild/BUILD/oxygen-5.6.90git/kstyle/demo/oxygenframedemowidget.cpp:33:10:
 fatal error: kwidgetsaddons_version.h: No such file or directory
[   73s]33 | #include 
[   73s]   |  ^~
[   73s] compilation terminated.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D13881

To: rjvbb, #vdg, plasma-devel
Cc: lbeltrame, GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Fwd: Plasma 5.17 beta Discover system updates regression

[Luca Beltrame]

In data domenica 22 settembre 2019 14:20:21 CEST, Myriam Schweingruber ha 
scritto:

(this might come in twice, due to gmane seemingly eating a message)

> FYI, this is now reported on both Arch and Neon, with several dozen
> duplicates in this bug report: https://bugs.kde.org/show_bug.cgi?id=411286

According to what I was told, Arch ships Qt 5.13.1 so should be not affected 
by this bug. Can this be confirmed?

So far I know that Neon, and only Neon, is affected due to the Qt version they 
ship, and being a Qt bug, I'd wager it's more of a Neon problem than a KDE 
issue.

openSUSE is not affected because it ships Qt 5.13.x (and Leap has Qt 5.9). 


-- 
Luca Beltrame
GPG key ID:  A29D259B

D23846: Fix build error of wrong function reference

[Luca Beltrame]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cf154a59148b: Fix compile (authored by lbeltrame).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23846?vs=65791&id=65815

REVISION DETAIL
  https://phabricator.kde.org/D23846

AFFECTED FILES
  systemmonitor/main.cpp

To: guoyunhe, #plasma, meven
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22014: Add a copy of FindKXB from kwin

[Luca Beltrame]

lbeltrame abandoned this revision.
lbeltrame added a comment.


  Actually, those changes are not needed. The includes aren't used at all.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22014

To: lbeltrame, cgiboudeaux
Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22014: Add a copy of FindKXB from kwin

[Luca Beltrame]

lbeltrame created this revision.
lbeltrame added a reviewer: cgiboudeaux.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lbeltrame requested review of this revision.

REVISION SUMMARY
  1a54c53bca82a28d77f379a6d5cb2e1a3be46fe5 
 
added a requirement for xkbcommon
  without actually looking for it. As FindXKB is not yet in ECM, this commit
  puts a copy of it in the source, and hooks it up with CMake.

TEST PLAN
  Did not compile for me earlier, now compiles.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  xkb-compile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22014

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXKB.cmake
  src/kmodifierkeyinfoprovider/CMakeLists.txt

To: lbeltrame, cgiboudeaux
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: Review Request: plasma-thunderbolt

[Luca Beltrame]

In data mercoledì 15 maggio 2019 15:27:07 CEST, Daniel Vrátil ha scritto:

> Thus I'd kindly ask you to take one more look at the codebase [1] and let me
> know if there are any more issues to fix, or if we can proceed to include
> this in the next Plasma release.

The repository at this point is missing either a LICENSE or a COPYING file 
with the correct license (there is none).

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.


  It needs D21152  applied as well to work 
properly in my scenario.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame added a comment.


  Doesn't seem to work with screens that have a rotation. 
  Setup:
  
  F6821443: Screenshot_20190513_134034.png 

  
  Actual display of a notification:
  
  (note where it is, when it's set to "bottom right":
  
  F6821445: Screenshot_20190513_134120.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame added a comment.


  I'll test and report if it works in my case, too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto:

> In this case, it seems like the problem is that there are certain
> individuals or teams that are pushing risky, breaking changes without code
> review, and then ignoring failures in the CI. I think we might do well to
> try to answer the question of why that's happening before we create a new
> rule aimed at stopping it.

Well put. Review or not review, clearly something in the process has failed, 
and I suspect "friction" rather than actual bad-faith ignorance of the CI 
results. 

So, perhaps to force myself out of the bikeshedding (mea culpa) on reviews, 
I'll steal Friedrich's points from another mail and put them here 
synthetically:

- Why are the CI mails ignored / filtered? Too many, hard to parse, difficult 
to interpret?
- What can be done to have people look at them and make sure they don't 
overlook breakage?

At least for the second point, as I mentioned earlier in the thread, probably 
having the committer being mailed in case of failure (GitLab does this IIRC) 
might be better than just on the mailing list. The second approach is what we 
use in openSUSE, where I usually don't subscribe to failure notifications 
(almost 300 packages is overkill) but a bot starts pestering me with mails the 
moment build failures go unfixed (granted, the time scale is different). 

For the first, I'd like people more involved in the development to say their 
word.

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 16:04:01 CET, Boudhayan Gupta ha scritto:

> I don't get why mandatory code reviews are so unpopular.

It's not "unpopular". As far as the discussion goes, the opinions (from 
several parties) say that they're not a silver bullet, and that some projects 
benefit from them more than others. 

The ultimate solution is actually more developers (yeah, I know, easy...).

CI, OTOH, has been IMO very useful (despite the headaches Ben mentions) for 
all the projects in KDE. 

> I don't care if you lose time. I don't want the guys building my house to

You should if the review stays there for years when there's no one else to 
review it. 

> As a user, I simply do not want unreviewed crap running on my computer.

Well, reviews help but they're just part of the equation. CI helps as well 
(and IMO, it should be more visible as I mentioned earlier in the thread).
And perfectly reviewed code (as well as unreviewed code) can still be a 
problem (as an integrator, I see that often). 

> one-liners, you're probably too overconfident to be writing good code
> anyway, so I'm going to operate on the presumption that if the code hasn't
> had more than one pair of eyeballs ever looking at it, it's crap.

I would say that there's no need to be like this. There is bound to be 
disagreement (and there is) but not as much as to define quality on 
assumptions. 

To be clear: I'm neither on the side of "review all the things" nor on the 
anarchist side. I just want to make sure we don't engage in policies that can 
be (potentially, just potentially) harmful for some parts of KDE (while they 
are perfectly OK for others). 

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto:

> OK, to be fair not 100% today's situation because of the above. It was based
> on best judgment maybe we're missing such a set of guidelines. I admit I'm
> slightly doubtful though.

I can't claim it may work 100%, but I've seen other communities (many, many 
years ago) where a "semi anarchy" replaced by "iron-gripped rules" from one 
day to another actually killed them. 

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 10:17:18 CET, Tomaz Canabrava ha scritto:

> The problem is that a git comit is a git commit, there's no way that a
> typo will be treated differently then another commit.

It's a "social" problem and not a technical one: you can see it across 
repositories managed by different groups. Some are very used to reviews, 
others not (and not necessarily PIM).

Hence the (even debatable, if you may) proposal.

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> I'd argue we're loosing more with the current state of PIM than we'd loose
> with mandatory reviews.

Perhaps, instead of an all-or-nothing approach, why not a minimal set of 
"requirements" that would require a review? Yes, it requires more discipline 
from those involved, but at least it will help people getting "ingrained" with 
the concept without being a wall.

Examples:

- No review: typo fixes, compile errors, version bumps (internal)
- Review: build system adjustments (perhaps CC some people knowledgeable in 
this case), non-trivial changes like patches
- "Deprecation" removals (as in the casus belli here) - review if touching 
more than a handful of files / multiple repos

(list made by someone who has a passing knowledge of C++, so feel free to rip 
me to shreds)

Pre-commit CI (i.e. once the switch to GitLab occurs) and perhaps direct 
mailing to the user (as I suggested earlier) in case of continuous failures 
will also help.

If this thing works, one can gradually ramp up the requirements of things that 
go through review when the "muscle memory" is formed.

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: CI system maintainability

[Luca Beltrame]

In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:

> at your screen or pair with you" in the past. Clearly this compromise gets
> somewhat exploited and that's especially bad in the case of a fragile and
> central component like KDE PIM.

I'm not sure I agree. I can't speak for seasoned developers, but I've found 
myself in a situation (more than once) where the fix is trivial (compile 
error, missing ";", etc) and being forced to go through review would (IMO) 
unnecessarily raise friction.

-- 
Luca Beltrame
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D19656: Comparisson has a typo, === and not = ==.

[Luca Beltrame]

lbeltrame added a comment.


  This was already fixed by 0d5c93b7c5318600f53d214efca2a060c0f0eea7 
.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseHandlerLoading

REVISION DETAIL
  https://phabricator.kde.org/D19656

To: tcanabrava, rooty
Cc: lbeltrame, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18867: Remove redundant DNS field per bug 403546

[Luca Beltrame]

lbeltrame added a comment.


  Migrating sounds like a good idea. I don't think popups are necessary for 
this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18867

To: andersonbruce, jgrulich
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Works. No side effects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

To: broulik, #plasma, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14147: Port from GConf to GSettings

[Luca Beltrame]

lbeltrame added a comment.


  Ping! Is this still being looked at? As distributions may phase out 
pulseaudio-gconf, this is important.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  In D17154#391812 , @gepardo wrote:
  
  > Are there any strong reasons?
  
  
  Not everyone has their XDG paths set in ~/.local, even more so when doing 
development.
  
  In addition, I had a look at the script. While I do stuff in Python for a 
living (and for many years) I could not figure out what was the purpose of the 
classes, the functions, and the last part of the generation of the theme is a 
bunch of calls without much context. In short, this needs to be documented, and 
clearly, otherwise it'll be treated as a magic black box and the moment 
something breaks, no one will know how to fix it.
  
  Yes, I'm to blame because I didn't look at it sooner.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  
https://invent.kde.org/sysadmin/ci-tooling/commit/d3443ccf5b0233f4fd0b19c93d8332046b616f58
 adds the PyCairo dependency to the CI, although the build system must still 
check for it (as it doesn't now).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  In D17154#391718 , @lbeltrame 
wrote:
  
  >
  
  
  
  
  > - It requires the Breeze style to be installed to load the color schemes 
but the dependency isn't checked anywhere
  
  This should be hopefully fixed by 
https://commits.kde.org/breeze-gtk/92978bb2a243fdca5f58fa231b425bbe1802b231

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  In D17154#391718 , @lbeltrame 
wrote:
  
  >
  
  
  
  
  > - There are decoding errors in the Python script because it doesn't take 
into account translations
  
  Fixed in 
https://commits.kde.org/breeze-gtk/cf5f675799a35687dd1fd4a13a4b80a860b71935.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  There are several issues with this patch, which cause build failures:
  
  - It requires PyCairo (python3-cairo in openSUSE) but the dependency isn't 
checked anywhere
  - It requires the Breeze style to be installed to load the color schemes but 
the dependency isn't checked anywhere
  - There are decoding errors in the Python script because it doesn't take into 
account translations
  
  As shown by the falures in the CI.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17007: Do hash and hex name based output hashes

[Luca Beltrame]

lbeltrame requested changes to this revision.
lbeltrame added a comment.
This revision now requires changes to proceed.


  As a packager: messing up with user configuration without a clear migration 
path is a no-no.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D17007

To: romangg, #plasma, lbeltrame
Cc: lbeltrame, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D15093: Add WireGuard capability.

[Luca Beltrame]

lbeltrame added a comment.


  In D15093#315885 , @andersonbruce 
wrote:
  
  >
  
  
  
  
  > As to copyright notice, I see that most are listed with name and email 
address.  Is the latter expected or is just name enough?  I don't have a 
business email anymore and I am somewhat hesitant to use my personal address 
but can if it is expected.
  
  This is important when the author is for example no longer involved in the 
specific development, but needs being contacted (for example, for asking for a 
relicense).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich
Cc: lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

[Luca Beltrame]

lbeltrame added a comment.


  Some smallish nitpicks I noticed there. Also, does this mean that NM has WG 
support now?
  
  I'll also let @jgrulich comment on this, but I'm not too fond of the manual 
parsing of the INI-like file used by WG. While I can't check at the moment, 
there should be KF5 or Qt classes to handle tihs.

INLINE COMMENTS

> passwordfield.h:2
> +/*
> +Copyright 2015 Jan Grulich 
> +

Please add your name to copyright if you wrote most of the code (likewise 
elsewhere in the code, and in the .desktop file.

> wireguardutils.cpp:42
> +// and/or a subnet (separated by the rest by a slash; 0 - 32)
> +bool WireGuardUtils::is_ip4(QString addr, bool allow_subnet, bool allow_port)
> +{

You may want to use QHostAddress instead of doing your own parsing of IPs: 
https://stackoverflow.com/questions/46853422/how-to-tell-if-qhostaddress-is-ipv4-or-ipv6-in-qt5

> wireguardwidget.cpp:296
> +{
> +d->ui.endpointLineEdit->setStyleSheet("* { background-color: 
> rgb(255,128, 128) }");
> +}

Why this? It will break proper coloring with people that use custom themes. 
IIRC you can have the widget handle it (but I can't check at the moment).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich
Cc: lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: plasma-devel to auto-discard non-subscribers?

[Luca Beltrame]

In data martedì 19 giugno 2018 16:05:34 CEST, Harald Sitter ha scritto:

> I really do not think this list doesn't benefit from a moderation queue.

-1. I direct people to this list when they have queries, and for one-off 
matters they shouldn't be forced to subscribe. An outright rejection of the 
mail will just drive them away.
Let's not raise the barrier to entry unless it's actually useful. I fail to 
see compelling arguments here.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D12990: update mouse kcm docbook to 5.13

[Luca Beltrame]

lbeltrame added a comment.


  @ltoscano  The question was asked due to a bad merge in plasma-desktop, which 
needed a force push. This commit was originally in the branch, but no longer 
due to this. Hence, the question: should it be added back?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12990

To: lueck, #plasma, #documentation, mart
Cc: lbeltrame, bshah, ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, 
ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Luca Beltrame]

In data giovedì 24 maggio 2018 12:05:08 CEST, Ben Cooksley ha scritto:

> Based on the lack of response I will be deeming Plasma Vault unmaintained
> and will be moving it there in 24 hours time.

Please contact Ivan first. He may have missed this message in the ML.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D13001: Handle children of added nodes as well

[Luca Beltrame]

lbeltrame added a comment.


  What's the easiest way to test this? I might just patch the package and see 
what happens.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13001

To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Luca Beltrame]

lbeltrame added reviewers: Plasma, hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

[Luca Beltrame]

lbeltrame added a comment.


  +1 from me, fixes the issue I had.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10764

To: broulik, #plasma, mart, lbeltrame
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

[Luca Beltrame]

lbeltrame added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  Ping? Why this has not been committed even if in "accepted" state?

REPOSITORY
  R127 KWayland

BRANCH
  subsurface-parent-destroyed

REVISION DETAIL
  https://phabricator.kde.org/D10300

To: graesslin, #frameworks, #kwin, #plasma, davidedmundson
Cc: lbeltrame, plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9998: Actually quit threads nicely

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> fvogt wrote in Resources.cpp:60
> It's the `// initial delay before processing the events` plus some time for 
> it to process the last request. I can add a comment if you want to.

A comment would do (so that it is less "magic").

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D9998

To: fvogt, #plasma, ivan, anthonyfieroni
Cc: lbeltrame, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9998: Actually quit threads nicely

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> Resources.cpp:60
> +requestInterruption();
> +wait(1500);
>  }

What's the reason for 1500 here?

> ResourceScoreMaintainer.cpp:62
> +requestInterruption();
> +wait(1500);
>  }

Same as above.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D9998

To: fvogt, #plasma, ivan, anthonyfieroni
Cc: lbeltrame, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9495: Properly detect Gallium drivers with newer Mesa

[Luca Beltrame]

lbeltrame added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  
  
  > I consider detecting for newer driver a feature.
  
  That might make things more difficult for downstreams, however.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D9495

To: fvogt, #plasma, graesslin
Cc: lbeltrame, kwin, plasma-devel, #kwin, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

[Luca Beltrame]

lbeltrame added a comment.


  It looks like it broke building with `BUILD_TESTING=OFF`:
  
  
/home/abuild/rpmbuild/BUILD/plasma-desktop-5.11.90git.20171028T043842~https://phabricator.kde.org/R119:44827507af3a3908ea503eddee30ebec8ca7c34e/containments/desktop/plugins/folder/foldermodel.h:74:45:
 error: expected initializer before ':' token

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: lbeltrame, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6634: Require C++14

[Luca Beltrame]

lbeltrame added a comment.


  openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as 
well.

REPOSITORY
  R108 KWin

BRANCH
  cxx-14

REVISION DETAIL
  https://phabricator.kde.org/D6634

To: graesslin, #plasma, lbeltrame, ivan
Cc: ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

[plasma-workspace] shell: Remove Hidden=true from the .desktop file

[Luca Beltrame]

Git commit 5f4333feb815ae45ca03a8e6db4d56b5d9b558da by Luca Beltrame.
Committed on 02/07/2017 at 20:09.
Pushed by lbeltrame into branch 'master'.

Remove Hidden=true from the .desktop file

Otherwise plasmashell doesn't start on login due to it being ignored
from autostart.

CCMAIL: plasma-devel@kde.org

M  +0-1shell/org.kde.plasmashell.desktop

https://commits.kde.org/plasma-workspace/5f4333feb815ae45ca03a8e6db4d56b5d9b558da

diff --git a/shell/org.kde.plasmashell.desktop 
b/shell/org.kde.plasmashell.desktop
index 76aae877..f28d396b 100644
--- a/shell/org.kde.plasmashell.desktop
+++ b/shell/org.kde.plasmashell.desktop
@@ -55,5 +55,4 @@ X-DBUS-ServiceName=org.kde.plasmashell
 OnlyShowIn=KDE;
 X-KDE-autostart-phase=0
 Icon=plasma
-Hidden=true
 

Re: Plasma Browser Integration is in kdereview

[Luca Beltrame]

In data lunedì 5 giugno 2017 16:42:34 CEST, David Edmundson ha scritto:

>  - chrome also has a feature where we can ship a text file on the distro
> side that will make the browser automatically fetch an extension from their
> store.

You may need to ask distributions if they are OK with it. Also bear in mind 
that, at least for the Chrome ecosystem, Chrome and Chromium (the latter 
actually used by the distributions) handle this mechanism in a slightly 
different way (I had a very high-level discussion with kbroulik on IRC a few 
weeks ago).

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: plasma 5.10 tars

[Luca Beltrame]

Il giorno Thu, 25 May 2017 23:29:34 +0100
Jonathan Riddell  ha scritto:

> Plasma 5.10 tars are now available on racnoss for packagers

Plasmate was removed from the plasma-sdk tarball, while it was in there
for the beta. The commit doing so is also explicitly marked "FEATURE".
It's kind of surprising to see such a large change from beta to final.
Given the ongoing feature freeze, was this allowed by mistake, or
intentionally?


-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B


pgpKCAqtYd1F0.pgp
Description: Firma digitale OpenPGP

[kio-extras] [Bug 376344] cant write to smb shares which has write access

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #44 from Luca Beltrame  ---
(In reply to madcatx from comment #43)

> Is it just me or is there currently no obvious way how to get a phabricator
> account? Thanks...

Please register on identity.kde.org, then you can use the "Login with LDAP"
form of Phabricator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #30 from Luca Beltrame  ---
If you want the developers to look at the patch, please submit it to
https://phabricator.kde.org. Patches in Bugzilla unfortunately tend to get
lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5012: Delay notifications until desktop session has loaded

[Luca Beltrame]

lbeltrame added a comment.


  Months later, it turns out that notify-osd ships a 
org.freedesktop.Notifications.service already, so it conflicts with the one 
made by this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, 
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5806: When building menu hyerarchies, parent menus to their containers

[Luca Beltrame]

lbeltrame added a comment.


  Unfortunately this change causes crashes in KPart-using applications that do 
stuff with their QActions with Qt 5.9. okular and kontact are affected, at 
least.
  
  This is a typical backtrace (got this from Eike, but I have the same):
  
#0  QAction::setEnabled (this=0xa4f160, b=b@entry=true) at 
/home/eike/devel/src/qt5/qtbase/src/widgets/kernel/qaction.cpp:1020 
   
#1  0x7fffd334e4a7 in PageView::updateActionState 
(this=this@entry=0x95ca80, haspages=haspages@entry=true, 
documentChanged=documentChanged@entry=true, 
hasformwidgets=hasformwidgets@entry=false)  
at /home/eike/devel/src/kde/kdegraphics/okular/ui/pageview.cpp:1096 

   
#2  0x7fffd33509fd in PageView::notifySetup (this=0x95ca80, 
pageSet=..., setupFlags=) at 
/home/eike/devel/src/kde/kdegraphics/okular/ui/pageview.cpp:1063
  
#3  0x7fffd2fe7e0b in Okular::Document::openDocument (this=, docFile=..., url=..., _mime=..., password=...) at 
/home/eike/devel/src/kde/kdegraphics/okular/core/document.cpp:2452  
#4  0x7fffd32f474e in Okular::Part::doOpenFile 
(this=this@entry=0x740830, mimeA=..., fileNameToOpenA=..., 
isCompressedFile=isCompressedFile@entry=0x7fffc9ef) 
 
at /home/eike/devel/src/kde/kdegraphics/okular/part.cpp:1292

  
#5  0x7fffd32f5c56 in Okular::Part::openFile (this=0x740830) at 
/home/eike/devel/src/kde/kdegraphics/okular/part.cpp:1414   
   
#6  0x77b88385 in KParts::ReadOnlyPartPrivate::openLocalFile 
(this=0x719070) at 
/home/eike/devel/src/frameworks/kparts/src/readonlypart.cpp:187 
   
#7  0x77b88010 in KParts::ReadOnlyPart::openUrl (this=0x740830, 
url=...) at /home/eike/devel/src/frameworks/kparts/src/readonlypart.cpp:150 
   
#8  0x7fffd32e8139 in Okular::Part::openUrl (this=0x740830, _url=...) 
at /home/eike/devel/src/kde/kdegraphics/okular/part.cpp:1567

#9  0x0041291c in Shell::openUrl (this=this@entry=0x6c6bf0, 
url=..., serializedOptions=...) at 
/home/eike/devel/src/kde/kdegraphics/okular/shell/shell.cpp:277
#10 0x00412af2 in Shell::openDocument (this=this@entry=0x6c6bf0, 
url=..., serializedOptions=...) at 
/home/eike/devel/src/kde/kdegraphics/okular/shell/shell.cpp:218
#11 0x00412b76 in Shell::openDocument (this=this@entry=0x6c6bf0, 
url=..., serializedOptions=...) at 
/home/eike/devel/src/kde/kdegraphics/okular/shell/shell.cpp:205
#12 0x0040c6c0 in Okular::main (paths=..., serializedOptions=...) 
at /home/eike/devel/src/kde/kdegraphics/okular/shell/okular_main.cpp:170
#13 0x0040be3b in main (argc=, argv=) 
at /home/eike/devel/src/kde/kdegraphics/okular/shell/main.cpp:72

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: lbeltrame, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Build issue of KWin in TumbleWeed

[Luca Beltrame]

In data domenica 14 maggio 2017 20:06:37 CEST, Michail Vourlakos ha scritto:

> Even though the xkbcommon (0.7.1) packages are installed (and devel
> package also) from main repo

You will need libxkbcommon-x11-devel and libxkbcommon-devel installed.  Are 
they both present?

You can also use "zypper si -d kwin5" and you'll get all the build 
dependencies installed.

(For the future, you may want to use opensuse-...@opensuse.org, as this is a 
distro-specific issue).

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: Next Plasma LTS and openSUSE

[Luca Beltrame]

In data martedì 18 aprile 2017 16:37:18 CEST, Aleix Pol ha scritto:

Hello Aleix,

sorry for the delay in the response.

> Clearly having an LTS release doesn't cut it for openSUSE, as we
> already did that last time and for the next release we're receiving
> yet another e-mail like the house is on fire.

openSUSE is in part handled by SUSE (the company) and in part by the 
community. There are cases where the the wishes of the individuals in each of 
the two may differ a lot. That is why some individuals (including high-profile 
community members) are pushing to use GNOME by default, which is the desktop 
used by SUSE Enterprise Linux. The main reasons, as far as I can understand, 
are the fact that there are people working on it already, and because they 
would share the development/maintenance with RH. And RH handles a good part of 
GNOME, so it's clearly seen as "enterprise".

Of course, openSUSE *doesn't* have to do that by default, and in fact that is 
why (long) threads have went on the relevant topic (although the community is 
sadly very keen on converting all discussions and debates into
awful flamewars, with no actual content except "KDE sux" and "GNOME sux more"). 
As far as I can understand, this topic comes out every now and then 
internally.But at least IMO, what we want to do is to make Plasma even more 
viable than before (it is already a lot, in my unscientific opinion) to ensure 
it is not demoted for mere politics. 

> - Which parts from 5.8 have worked well?

The whole LTS part in my opinion worked *remarkably* well. It provided a very 
good desktop, supported by bugfixes over long periods of time. I would add that 
also the beta and the early release phase done almost impeccably. Timing was, 
as discussed at the time, very useful. 

> - Which parts from 5.8 haven't worked well?

Some are due to the process, and not a fault of Plasma itself. The openSUSE 
maintenance team, which is in charge of the stable version updates, doesn't 
like when we supply tarballs with updated version numbers and no actual 
changes. On the other side of the fence, I know this may cause some logistic 
problems (I know that David Faure rejected such an approach when some Kolab 
Systems people asked for it in KF5). 
In some cases, commits broke building and the (very rare) "feature" changes 
like when the tm partial rewrite code ended up in 5.8. In general terms, there 
were a more than a few case of regressions.

> - Do you have the feeling that your feedback is acted on?

In my opinion yes, but I have one foot in two shoes, so to speak. ;)

> - Where are the problems we should be concerned with?

Detailing arguments why some favor GNOME over KDE would just result in 
bikeshedding, but we can list some if you'd like to.

> Personally, with my Discover hat on, I have seen very little feedback
> from opensuse and that worries me:

We don't have Discover installed by default. Some of the reasons are:

- We found PackageKit to be not too reliable (in our experience).
- The zypp based PackageKit backend used by openSUSE does not stay active in 
the background, which is a problem for Discover (but also for other AppStream 
software centers). A fix is being worked on.
- Other KDE team members found Discover to be very prone to crashes, but it 
may have to do with Qt rather than Discover itself.
- We found the UI to be a little alien to the rest of Plasma.

It's installed by default on the KDE live images (not the general openSUSE 
lives, but KDE team live images) though.

With all that said, let's also focus on the future: Qt 5.9 will be a LTS 
release (and will be likely also shipped by "enterprise" distributions), so it 
would be a good idea to plan a new Plasma LTS release sitting on top 
of Qt 5.9. What do you think?

Thanks in advance.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

[Luca Beltrame]

lbeltrame requested changes to this revision.
lbeltrame added a comment.
This revision now requires changes to proceed.


  Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to 
this commit, if it's not in the repository already, or there won't be any 
reference to the revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5761

To: marten, #plasma, dfaure, lbeltrame
Cc: lbeltrame, plasma-devel, jriddell, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5761: Removal of KDELibs4Support means own copy of FindSamba.cmake needed

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  This breaks the SMB ioslave, so please commit at the earliest. Thanks!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5761

To: marten, #plasma, dfaure, lbeltrame
Cc: lbeltrame, plasma-devel, jriddell, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[kdeplasma-addons] /: Revert "Bump frameworks version"

[Luca Beltrame]

Git commit 2c21566486b0503803fe3997e5af2da70360f776 by Luca Beltrame.
Committed on 03/05/2017 at 05:15.
Pushed by lbeltrame into branch 'master'.

Revert "Bump frameworks version"

Frameworks versions have not yet bumped in the respective repositories.
The only effect this causes at the moment is the impossibility to build
kdeplasma-addons (no Frameworks with that version exist)

This reverts commit 36b5ad587a9468851cbdd4497536cefb7c6780e0.

CCMAIL: k...@davidedmundson.co.uk
CCMAIL: plasma-devel@kde.org

M  +1-1CMakeLists.txt

https://commits.kde.org/kdeplasma-addons/2c21566486b0503803fe3997e5af2da70360f776

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f5ecaf014..fe4ffda35 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -20,7 +20,7 @@ include(KDECompilerSettings NO_POLICY_SCOPE)
 include(ECMQtDeclareLoggingCategory)
 
 set(REQUIRED_QT_VERSION 5.3.0)
-set(KF5_MIN_VERSION 5.34.0)
+set(KF5_MIN_VERSION 5.8.0)
 find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Core Gui DBus Quick 
Qml Widgets X11Extras)
 
 find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS

Next Plasma LTS and openSUSE

[Luca Beltrame]

Hi everyone,

this is basically the same discussion as already took place for 5.8.

According to distrowatch, it looks very much like we're currently the _only_ 
remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default.
Not only has Ubuntu switched to GNOME, for openSUSE there's currently also a 
major fork in the road happening next:

- openSUSE Tumbleweed will likely switch to having no default at all
  (user has to choose one)
- openSUSE Leap _may_ switch to GNOME as it is the desktop in SUSE Linux
  Enterprise. The argument here is that SUSE has a desktop team that is paid 
  to fix bugs, while this is not the case for the community-maintained KDE
  packages.

It's obvious that this switch must not happen for various political reasons:
- GNOME becomes the de-facto standard desktop (Fedora, Ubuntu, openSUSE)
- This headline: "openSUSE switches default desktop after 10+ years, KDE not 
viable?"
- openSUSE KDE users might think that the focus shifted away

The only chance I can see avoiding the switch is by delivering a flawless 
experience for the next major release, which will be released roughly this 
time next year. So it would be perfect to have a 5.12 (?) LTS by then. The way 
the schedule aligned for Leap 42.2 with Plasma 5.8.2 was perfect, thanks for 
that again!

Additionally, it would be great to have an Applications LTS as well, which 
would make a faster feature-release cycle alongside a slower LTS cycle 
possible.

I'm aware that this is an awful situation to be in, but I hope that we can 
figure something out...


The openSUSE KDE team

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: proposal: make plasma *not* build with Qt 5.8.0

[Luca Beltrame]

In data mercoledì 22 marzo 2017 16:51:54 CET, Martin Gräßlin ha scritto:

> So if we have more issues we should tell distros about it. It just makes
> all of us look bad if there are known issues and distros ship it without
> better knowledge.

Given that Qt doesn't want to release 5.8.1 before 5.9, a list of review 
requests fixing glaring bugs would also be very helpful.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: proposal: make plasma *not* build with Qt 5.8.0

[Luca Beltrame]

In data mercoledì 22 marzo 2017 14:37:27 CET, Marco Martin ha scritto:

> Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to
> make even more obvious that 5.8.0 is discouraged, to make cmake fail in

-1, this makes things unnecessarily complicated for downstreams. 

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: [KDE4] what component does the screenlocking?

[Luca Beltrame]

In data venerdì 3 marzo 2017 10:59:03 CET, René J.V. Bertin ha scritto:

> @plasma-devel : Can anyone tell me if a screensaver  exists for
> Plasma5 that puts up a simple, CPU-cheap clock like kclock does or if not,

Support for screensavers has been removed even in 4.x times when the new lock 
screen architecture was introduced. 

This was done after a poll on KDE Community Forums in 2011:
https://forum.kde.org/viewtopic.php?f=66&t=97102

That said, the screenlocker IIRC supports Plasma packages for wallpapers, so, 
like the "video on lock screen" feature showcased in recent Plasma releases, 
you can probably mimic what you want (but I'll leave how to the experts).

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: [KDE4] what component does the screenlocking?

[Luca Beltrame]

In data mercoledì 1 marzo 2017 15:44:48 CET, René J. V. Bertin ha scritto:

> And is that loginctl command supposed to work only on systems that use

Only with systemd. IIRC FreeBSD has a patch to make it work with ConsoleKit.

> systemd throughout or elsewhere too? `loginctl kill-session X` works for me
> but not `loginctl lock-session X` or `loginctl unlock-session X`, is that
> because Ubuntu 14.04 only pretends to use systemd and (AFAIK) uses upstart

Ubuntu 14.04 only has a shim that implements just a subset of what systemd 
offers. 16.04 offers full support instead.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

Re: [KDE4] what component does the screenlocking?

[Luca Beltrame]

In data martedì 28 febbraio 2017 23:16:42 CET, René J.V. Bertin ha scritto:

> 3) suppose something like this happens on a Plasma5 desktop, what backdoors
> are there to unlock the session without killing it, from a virtual console?

With the exception of "loginctl unlock-sessions" as root or "loginctl unlock-
session" as the same user, none. It's the whole point of the screenlocker 
architecture (that is, you can't just kill it and unlock the screen).

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

Re: [KDE4] what component does the screenlocking?

[Luca Beltrame]

In data martedì 28 febbraio 2017 18:08:40 CET, René J.V. Bertin ha scritto:

> Yeah, I know that KDE no longer maintains most of KDE4. Fortunately some
> distributions have a slightly different take on concepts like continuity

I would like if you stopped doing such blanket statements. Plasma 4 *was* on 
Long Term Support for quite a while when Plasma 5 was born and for some 
releases along the way. 
In openSUSE we dropped Plasma 4 because continuity means *nothing* if no one 
can fix bugs.

> bleeding-edge distros like KaOS fail to convince me that the "better
> Plasma5" is not indeed the enemy of "good old Plasma4", to paraphrase an

Again, blanket statement. How many distros have deployad Plasma 5 so far? 
Basically most of the larger ones. In openSUSE we even put Plasma master under 
openQA. n = 1 does not make a great sample size.

> If the screensaver also provides session locking I'll start with making it a
> habit to restart Plasma each time I get the screensaver glitch.

It does, and IIRC the later 4.x versions also worked like that. Technically 
there's no screensaver, just a screen locker (the *community* on a KDE 
Community Forums poll decided that the interest in keeping screensavers was 
minimal).

> open session. If sddm supports something similar I might adopt it earlier
> than Plasma5 (presuming sddm supports other session types than Plasma5

That's why I say blanket statements are *bad*. SDDM is not made by KDE and it 
does support different sessions.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

[Luca Beltrame]

lbeltrame added a comment.


  In https://phabricator.kde.org/D4596#86009, @garg wrote:
  
  > I would argue that breeze-gtk should already have had this change in order 
to not break on systems where GTK is >= 3.20 and that introducing a new 
build-dep is the only way of fixing thee issue.
  
  
  Please patch it at the distro level until 5.10. I *totally* disagree on 
behavioral changes on stable releases, even for build requirements.
  
  I have reverted both commits in 5.9.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D4596

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: garg, sitter
Cc: lbeltrame, apol, sitter, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[breeze-gtk/Plasma/5.9] /: Revert "No need for WITH_GTK3_VERSION anymore"

[Luca Beltrame]

Git commit 5691771806221890b1ff9a8d401d778633ca6130 by Luca Beltrame.
Committed on 13/02/2017 at 16:21.
Pushed by lbeltrame into branch 'Plasma/5.9'.

Revert "No need for WITH_GTK3_VERSION anymore"

This reverts commit 5328755bf3dc4261ecca6e705009faefa2b87339.

Changing build requirements in a stable release is a great way to annoy
distributions and violates the principle of least surprise.

CCMAIL: ro...@garg.io
CCMAIL: plasma-devel@kde.org

M  +1-1Breeze-dark-gtk/CMakeLists.txt
M  +1-1Breeze-gtk/CMakeLists.txt
M  +2-0CMakeLists.txt

https://commits.kde.org/breeze-gtk/5691771806221890b1ff9a8d401d778633ca6130

diff --git a/Breeze-dark-gtk/CMakeLists.txt b/Breeze-dark-gtk/CMakeLists.txt
index 15fbb2f..4cafdd8 100644
--- a/Breeze-dark-gtk/CMakeLists.txt
+++ b/Breeze-dark-gtk/CMakeLists.txt
@@ -3,7 +3,7 @@ install(DIRECTORY gtk-2.0 DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Bre
 install(DIRECTORY assets DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze-Dark
 ${directory_EXCLUDES})
 
-if (PKG_GTK_VERSION VERSION_LESS "3.20")
+if (WITH_GTK3_VERSION VERSION_LESS "3.20")
 install(FILES gtk-3.18/gtk.css DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze-Dark/gtk-3.0/)
 else()
 install(FILES gtk-3.20/gtk.css DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze-Dark/gtk-3.0/)
diff --git a/Breeze-gtk/CMakeLists.txt b/Breeze-gtk/CMakeLists.txt
index 5096c28..957665f 100644
--- a/Breeze-gtk/CMakeLists.txt
+++ b/Breeze-gtk/CMakeLists.txt
@@ -3,7 +3,7 @@ install(DIRECTORY gtk-2.0 DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Bre
 install(DIRECTORY assets DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze
 ${directory_EXCLUDES})
 
-if (PKG_GTK_VERSION VERSION_LESS "3.20")
+if (WITH_GTK3_VERSION VERSION_LESS "3.20")
 install(FILES gtk-3.18/gtk.css DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze/gtk-3.0/)
 else()
 install(FILES gtk-3.20/gtk.css DESTINATION 
${KDE_INSTALL_FULL_DATAROOTDIR}/themes/Breeze/gtk-3.0/)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 930ad61..db52ea5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -13,6 +13,8 @@ find_package(GTKEngine)
 find_package(PkgConfig)
 pkg_check_modules(PKG_GTK REQUIRED gtk+-3.0)
 
+set(WITH_GTK3_VERSION ${PKG_GTK_VERSION})
+
 include(KDEInstallDirs)
 
 # Exclude these patterns when installing directories as they have no use

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

[Luca Beltrame]

lbeltrame added a comment.


  This changes the build requirements. It should //not// go into 5.9 IMO.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4596

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: garg, sitter
Cc: lbeltrame, apol, sitter, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

[Luca Beltrame]

lbeltrame added a comment.


  FTR, the reason this was not done runtime was to avoid depending on a 
development package (and associated dependencies like a compiler) to install 
something that's architecture-dependent. My first. local patch I made at the 
time used pkg_config, but it was discarded for this reason.
  
  Not that I have hard feelings about this, should this be changed, but I just 
wanted to outline the rationale for it at the time.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D4596

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: garg
Cc: lbeltrame, apol, sitter, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  Speaking as a distro person: this might cause issues. The reason is that *if* 
we update to KF 5.29 (or 30) with this and Plasma stays as a stable version, we 
will get interesting conflicts.
  
  And of course, removing this in a stable version is **not** an option.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: lbeltrame, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Split the kioslaves out of plasma-workspace?

[Luca Beltrame]

In data venerdì 4 novembre 2016 19:09:17 CET, Martin Gräßlin ha scritto:

> Radical different idea: what about moving Dolphin from Applications to
> Plasma?

In this case, -1 from me: there are a number of people that use dolphin 
outside Plasma, and that would also be counter-intuitive for the branding.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

[Differential] [Commented On] D3249: Use our tooling for installing plasmoids

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  The reason is that CMake doesn't generate the `konsoleprofiles` directory 
when configuring.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3249

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3249: Use our tooling for installing plasmoids

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  Forgot to add, cmake complains about not being able to find plugin metadata.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3249

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3249: Use our tooling for installing plasmoids

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  kdeplasma-addons doesn't build here with these changes:
  
  [  201s] [  1%] Generating konsoleprofiles/package-metadata.json
  [  201s] make[2]: Entering directory 
'/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~https://phabricator.kde.org/rKDEPLASMAADDONS96211d07b193eb5b8a2c114369fc2eea76511315/build'
  [  201s] cd 
"/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~https://phabricator.kde.org/rKDEPLASMAADDONS96211d07b193eb5b8a2c114369fc2eea76511315/build/applets";
 && /usr/bin/desktoptojson -i 
/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~https://phabricator.kde.org/rKDEPLASMAADDONS96211d07b193eb5b8a2c114369fc2eea76511315/applets/konsoleprofiles/package/metadata.desktop
 -o 
/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~https://phabricator.kde.org/rKDEPLASMAADDONS96211d07b193eb5b8a2c114369fc2eea76511315/build/applets/konsoleprofiles/package-metadata.json
  [  201s] Error: Failed to open  
"/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~https://phabricator.kde.org/rKDEPLASMAADDONS96211d07b193eb5b8a2c114369fc2eea76511315/build/applets/konsoleprofiles/package-metadata.json";
 
  [  201s]  ((null):0, (null))
  [  201s] Unknown property type for key "X-Plasma-API" -> falling back to 
string
  [  201s] Unknown property type for key "X-Plasma-MainScript" -> falling back 
to string
  [  201s] make[2]: *** 
[applets/CMakeFiles/org.kde.plasma.konsoleprofiles-metadata-json.dir/build.make:61:
 applets/konsoleprofiles/package-metadata.json] Error 1

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3249

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  F354981: Spectacle.aq5462.png  And this 
is a screenshot.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2932

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  I've seen this on both multi and single screen. FV placed on the desktop, 
BTW. Screenshot coming up soon (because I run with the patch reverted).

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2932

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  This breaks Folder View in a spectacular way: icons overflow out of the 
applet, and even the title is displayed out of the frame.  In some situations 
I've also seen icons "dancing" continuously (but always overflowing).
  
  Reverting this commit fixes the issue completely.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2932

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D2732: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1

[lbeltrame (Luca Beltrame)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE629fa121be72: [MPRIS Dataengine] Use UTF-8 for 
URLs instead of Latin1 (authored by lbeltrame).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2732?vs=6607&id=6671

REVISION DETAIL
  https://phabricator.kde.org/D2732

AFFECTED FILES
  dataengines/mpris2/playercontainer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lbeltrame, broulik, #plasma, hein, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  As many others have noted already, the .desktop file is missing in this diff, 
and that broke kdeplasma-addons build.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D2677

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: lbeltrame, broulik, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  A question: what would happen if a user has existing shortcuts defined 
already? (I know that's a non-default case)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  In https://phabricator.kde.org/D2218#41975, @mart wrote:
  
  > most comments should be adressed now, will need again a period of test with 
several multiscreen users, as it has changed a bit
  
  
  I've been running this for a while, in two setups (one with 3 identical 
screens, another with two screens of which one is rotated 90 degrees) with no 
issues. Coupled with the already-merged patch by sebas in kscreen, I get no 
containment dance anymore at startup.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: lbeltrame, davidedmundson, rwooninck, graesslin, plasma-devel, 
jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  So far, no bad side effects that I can tell, even with the newer version.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  I've been using this all week without ill side effects. In fact, this solves 
an issue I had when testing notmart's p-w branch.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  For now I didnt notice any problems (with version 1 of the patch), at least 
no regressions (notice that I wasn't able to reproduce the issue described in 
the bug since a long time).
  
  Is there any difference worth testing in the new revision?

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  I have two identical screens set up as part of my 3 monitor set. I can test 
this.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: lbeltrame, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-desktop] kcms/colors: Fix build

[Luca Beltrame]

Git commit afc4f3281649bbecd8cd9667781d5df69c6d4925 by Luca Beltrame.
Committed on 13/07/2016 at 05:24.
Pushed by lbeltrame into branch 'master'.

Fix build

Comment out failing lines, which are referring to non-existent bits in
the UI file. This is a stop-gap solution.

*Please* check that things build before adjusting UI files. The code may
be referring to them, and if not adjusted, it will break.

CCMAIL: kain...@gmail.com
CCMAIL: plasma-devel@kde.org

M  +4-4kcms/colors/colorscm.cpp
M  +1-0kcms/colors/colorscm.h

http://commits.kde.org/plasma-desktop/afc4f3281649bbecd8cd9667781d5df69c6d4925

diff --git a/kcms/colors/colorscm.cpp b/kcms/colors/colorscm.cpp
index 80c01b1..b79b6e7 100644
--- a/kcms/colors/colorscm.cpp
+++ b/kcms/colors/colorscm.cpp
@@ -170,7 +170,7 @@ void KColorCm::updatePreviews()
 {
 schemePreview->setPalette(m_config);
 colorPreview->setPalette(m_config);
-setPreview->setPalette(m_config, 
(KColorScheme::ColorSet)(colorSet->currentIndex() - 1));
+// setPreview->setPalette(m_config, 
(KColorScheme::ColorSet)(colorSet->currentIndex() - 1));
 inactivePreview->setPalette(m_config, QPalette::Inactive);
 disabledPreview->setPalette(m_config, QPalette::Disabled);
 }
@@ -868,7 +868,7 @@ void KColorCm::updateColorTable()
 {
 // common colors is selected
 stackColors->setCurrentIndex(0);
-stackPreview->setCurrentIndex(0);
+// stackPreview->setCurrentIndex(0);
 
 KColorButton * button;
 foreach (button, m_commonColorButtons)
@@ -915,9 +915,9 @@ void KColorCm::updateColorTable()
 else
 {
 // a real color set is selected
-setPreview->setPalette(m_config, (KColorScheme::ColorSet)currentSet);
+// setPreview->setPalette(m_config, 
(KColorScheme::ColorSet)currentSet);
 stackColors->setCurrentIndex(1);
-stackPreview->setCurrentIndex(1);
+// stackPreview->setCurrentIndex(1);
 
 for (int i = KColorScheme::NormalBackground; i <= 
KColorScheme::AlternateBackground; ++i)
 {
diff --git a/kcms/colors/colorscm.h b/kcms/colors/colorscm.h
index 0aeee88..12254ba 100644
--- a/kcms/colors/colorscm.h
+++ b/kcms/colors/colorscm.h
@@ -22,6 +22,7 @@
 #define __COLORSCM_H__
 
 #include 
+#include 
 
 #include "ui_colorsettings.h"
 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

[Luca Beltrame]

In data venerdì 8 luglio 2016 10:34:52 CEST, Marco Martin ha scritto:

> I was referring to cantata as having under the hood problems (using mpd)
> does clementine use gstreamer? (that would be the most distro-blessed
> option)

IIRC, Clementine has no Qt5 port officially released.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The situation of KWallet, and what to do about it?

[Luca Beltrame]

In data giovedì 7 luglio 2016 13:17:12 CEST, Martin Graesslin ha scritto:

Hello Martin,

> Adding some more:
[...]

I think we should not forget that there's kwallet (the framework) and 
kwallet{manager} (the frontend).

I also think that Kwallet is very much ingrained in a lot of KDE software, so 
that rules out (IMO) the option for a drastic change there. I do believe, as 
Thomas stated, that we *need* to have a wallet available in the workspace. 

That said, some review would be in order in particular with regards to the 
encryption used (see the recent breakage that occurred "just" fixing a compiler 
warning).

(FYI, I'm using Kwallet with a GPG-based YubiKey, but I agree this is *not* an 
acceptable, or easy enough, solution for our userbase),

> - if one doesn't unlock the wallet fast enough applications start asking for
> the password. So getting a coffee while desktop starts results in thousands

This is no longer the case, IIRC dfaure has raised the timeout to 45 minutes.

> For Plasma I would like to see unlocking the wallet integrated into the
> desktop shell in some way. That would fix problems like the incorrect

That would mean probably having Plasma providing a sort of "frontend" to the 
framework? To be honest, I have no idea if there's any separation of GUI and 
wallet layers in the kwallet-framework code.


-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel