D13988: Use subseq matching for service runner

2018-08-02 Thread Michael Eden
michaeleden added a comment.


  @broulik thanks, will do!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13988: Use subseq matching for service runner

2018-08-02 Thread Michael Eden
michaeleden added a comment.


  @ngraham cool! So I should change the deps for KF 5.50 unless someone else 
disagrees?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13988: Use subseq matching for service runner

2018-07-11 Thread Michael Eden
michaeleden added a comment.


  @ngraham this didn't make it into 5.48 but it did make it into the commit 
after that. Should I put 5.49 even though its not tagged yet?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

2018-07-09 Thread Michael Eden
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a58e48707601: Updated RunCommand.qml to scroll with Ctrl 
+ home row (j, k) (authored by michaeleden).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13686?vs=36570&id=37459

REVISION DETAIL
  https://phabricator.kde.org/D13686

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: michaeleden, broulik, #plasma_workspaces, davidedmundson
Cc: davidedmundson, #plasma_workspaces, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13988: Use subseq matching for service runner

2018-07-08 Thread Michael Eden
michaeleden created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
michaeleden requested review of this revision.

REVISION SUMMARY
  This changes krunner to use sub-sequence matching fixing bug 262837.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feat/app-name-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13988

AFFECTED FILES
  runners/services/servicerunner.cpp

To: michaeleden
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

2018-06-23 Thread Michael Eden
michaeleden updated this revision to Diff 36570.
michaeleden added a comment.


  Use ES5 `var` instead of ES6 `const`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13686?vs=36541&id=36570

BRANCH
  feature/krunner-scroll-jk

REVISION DETAIL
  https://phabricator.kde.org/D13686

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: michaeleden, broulik, #plasma_workspaces
Cc: #plasma_workspaces, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

2018-06-22 Thread Michael Eden
michaeleden created this revision.
michaeleden added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
michaeleden requested review of this revision.

REVISION SUMMARY
  This change allows users to scroll through krunner output using their homerow.
  
  - Ctrl+j: Scroll Down
  - Ctrl+k: Scroll Up
  
  This makes scrolling easier for those familiar with this convention but 
doesn't
  inhibit users who aren't.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feature/krunner-scroll-jk

REVISION DETAIL
  https://phabricator.kde.org/D13686

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: michaeleden, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart