D19284: Close the window selected in the task group tooltip on middle click

[Nick Guletskii]

nickguletskii added a comment.


  Sorry, didn't notice the email notification for the comment before. My email 
is: n...@nickguletskii.com

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19284

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Nick Guletskii]

nickguletskii added a comment.


  Thanks! My email is: n...@nickguletskii.com

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19281

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Nick Guletskii]

nickguletskii added a comment.


  Sorry, I don't believe I can land it myself since I don't have a developer 
account.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19281

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Nick Guletskii]

nickguletskii updated this revision to Diff 55061.
nickguletskii edited the summary of this revision.
nickguletskii added a comment.


  I have replaced the previous version of a patch with a new version, which is 
based on the latest master. The new version doesn't wrap the whole tooltip item 
with a Plasma highlight. Instead, it modifies the active window line to also 
indicate whether the corresponding thumbnail has been hovered over or not. 
F6734813: Screenshot_Latte_Dock_Window_Thumbnails_Highlight_v2.png 


REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19281?vs=52458&id=55061

REVISION DETAIL
  https://phabricator.kde.org/D19281

AFFECTED FILES
  plasmoid/package/contents/ui/ToolTipInstance.qml

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii added a comment.


  I've described my problem in a bug report: 
https://bugs.kde.org/show_bug.cgi?id=404785

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii abandoned this revision.
nickguletskii added a comment.


  Hmm, sorry, I couldn't get the master branch to start on my machine, and 
since I've only used v0.8, I didn't realise this is already implemented. My 
mistake.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19284: Close the window selected in the task group tooltip on middle click

[Nick Guletskii]

nickguletskii created this revision.
nickguletskii added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  In Windows, it is possible to close windows by middle-clicking their previews 
in the taskbar. This patch adds this feature to Latte Dock. Now, middle 
clicking an item in the task group tooltip will close the corresponding window.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19284

AFFECTED FILES
  plasmoid/package/contents/ui/ToolTipWindowMouseArea.qml

To: nickguletskii, #latte_dock
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Nick Guletskii]

nickguletskii created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  Currently, the task group tooltip doesn't react to the user hovering over a 
thumbnail. This patch adds a standard Plasma Highlight around the item that the 
user is hovering over, which signals the user that the item is clickable:
  
  F6633128: Screenshot_Latte_Dock_Window_Thumbnails_Highlight.png 

  
  (Unfortunately, Spectacle didn't capture the cursor, which was hovering over 
the third item.)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19281

AFFECTED FILES
  plasmoid/package/contents/ui/ToolTipInstance.qml

To: nickguletskii
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii created this revision.
nickguletskii added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  Currently, Latte starts the "present windows" effect when the user clicks on 
a task group and the "present windows" effect is available. To force Latte to 
display the task selection tooltip instead, the "present windows" effect must 
be disabled entirely. This patch adds the ability to force Latte to open the 
task group tooltip even when the "present windows" effect is enabled.
  
  This patch adds an additional setting, both to the main dock settings dialog 
and the dock widget settings:
  
  F6633034: Screenshot_Latte_Group_Activation_Action.png 

  
  F6633037: Screenshot_Latte_Group_Activation_Action_Dock_Settings.png 

  
  When "Present windows is possible" (the default option) is selected, the 
current behavior will be retained. When "Show previews" is selected, clicking 
on a task group will open the window selection tooltip as if "present windows" 
is disabled.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

AFFECTED FILES
  containment/package/contents/config/main.xml
  containment/package/contents/ui/main.qml
  liblattedock/dock.h
  plasmoid/package/contents/config/main.xml
  plasmoid/package/contents/ui/config/ConfigInteraction.qml
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/task/TaskDelegate.qml
  shell/package/contents/configuration/TasksConfig.qml

To: nickguletskii, #latte_dock
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart