D27367: fix activity runner

[Oleg Solovyov]

McPain updated this revision to Diff 75900.
McPain marked an inline comment as done.
McPain added a comment.


  removed 2nd hunk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27367?vs=75605&id=75900

REVISION DETAIL
  https://phabricator.kde.org/D27367

AFFECTED FILES
  runners/activities/activityrunner.cpp

To: McPain, broulik, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#412961 , @davidedmundson 
wrote:
  
  > > It would just be nice not to have to think about this stuff
  >
  > There is an OOM killer. That OOM killer is faster than a human, has access 
to more info about processes and has higher privileges than userspace.
  
  
  (necroposting)
  Which usually freezes my PC for 10 seconds or even more

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: rooty, davidedmundson, graesslin, abetts, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, ahiemstra, mart

D27367: fix activity runner

[Oleg Solovyov]

McPain created this revision.
McPain added reviewers: broulik, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Activity runner is now useless:
  
  m_activities is always nullptr in ActivityRunner::run because 
ActivityRunner::down is called after ActivityRunner::match which makes activity 
changing impossible

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27367

AFFECTED FILES
  runners/activities/activityrunner.cpp

To: McPain, broulik, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Oleg Solovyov]

McPain added a comment.


  Happens to be a regression after 2f3bcfa 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: heikobecker.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Looks like there's a typo and it's not intended to exec "konsole --profile" 
with empty profile string because the funxtion returns early when profile is 
not empty.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp

To: McPain, heikobecker
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  In D21872#481213 , @ngraham wrote:
  
  > In D21872#481173 , @McPain wrote:
  >
  > > In D21872#481154 , 
@davidedmundson wrote:
  > >
  > > > It might be better to do it in
  > > >
  > > > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.
  > >
  > >
  > > I don't see any matching files in sddm
  >
  >
  > https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp
  
  
  thanks, but how should I do this?
  These translations doesn't belong to sddm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  In D21872#481154 , @davidedmundson 
wrote:
  
  > It might be better to do it in
  >
  > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.
  
  
  I don't see any matching files in sddm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  F6901033: изображение.png F6901031: 
изображение.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

AFFECTED FILES
  sddm-theme/KeyboardButton.qml

To: McPain
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a14258a0cd60: fill layouts from X server when there are 
no layouts in config (authored by McPain).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58951&id=59130

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#472461 , @ngraham wrote:
  
  > IMO what's seen in your screenshot is not useful behavior. If the full text 
fits in the regular UI, there's no need to show a tooltip; it's just redundant.
  
  
  I see. Somehow `subTextLabel.truncated` is always true

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain added a comment.


  In D21497#472546 , @ngraham wrote:
  
  > Looks good and works for me, though I'm not super familiar with this code 
so I'd appreciate a review from @hein or @broulik.
  
  
  I'll land this tomorrow if everything will be still ok

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58951.
McPain added a comment.


  style: for

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58950&id=58951

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58950.
McPain added a comment.


  foreach -> for
  use const

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58932&id=58950

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#472255 , @ngraham wrote:
  
  > I am still not actually getting any tooltips when I hover over an elided 
entry.
  >
  > F6860589: Screenshot_20190530_114108.png 

  
  
  strange
  F6861650: изображение.png 

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58932.
McPain set the repository for this revision to R119 Plasma Desktop.
McPain added a comment.


  updated paths

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58911&id=58932

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58911.
McPain added a comment.


  1. Overwrite `configureLayouts` based on whether `layouts` is empty or not
  2. Make sure fetched layouts were saved to config

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58889&id=58911

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  BUILD/plasma-desktop-5.15.4/kcms/keyboard/keyboard_config.cpp
  BUILD/plasma-desktop-5.15.4/kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 348198

TEST PLAN
  1. move ~/.config/kxkbrc
  2. connect a USB keyboard
  3. layout changing works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp

To: McPain
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#364814 , @mart wrote:
  
  > In D15247#341864 , @McPain wrote:
  >
  > > Additionally, tooltips are glitching if you move the mouse pointer too 
fast between items{F6324386 }
  >
  >
  > there was a recent fix in the kwin morphingpopup effect that should have 
fixed it, i would say go for it
  
  
  It was commit b257029afc3bfcd6366d2c2b910b8d91403ab8aa 
 
from plasma-framework
  @ngraham what could you say about patch?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#364814 , @mart wrote:
  
  > In D15247#341864 , @McPain wrote:
  >
  > > Additionally, tooltips are glitching if you move the mouse pointer too 
fast between items{F6324386 }
  >
  >
  > there was a recent fix in the kwin morphingpopup effect that should have 
fixed it, i would say go for it
  
  
  Hi. I don't see any

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20900: Reject invalid keys

[Oleg Solovyov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:257b03b185d3: Reject invalid keys (authored by McPain).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20900?vs=57249&id=57266

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/passworddialog.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4cb1e69c1a61: Reset model when there are new available 
connections (authored by McPain).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20788?vs=56894&id=57265

REVISION DETAIL
  https://phabricator.kde.org/D20788

AFFECTED FILES
  libs/models/networkmodel.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20900: Reject invalid keys

[Oleg Solovyov]

McPain updated this revision to Diff 57249.
McPain marked an inline comment as done.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20900?vs=57245&id=57249

BRANCH
  D20900

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/passworddialog.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20900: Reject invalid keys

[Oleg Solovyov]

McPain updated this revision to Diff 57245.
McPain edited the summary of this revision.
McPain removed 1 blocking reviewer(s): jgrulich.
Herald added 1 blocking reviewer(s): jgrulich.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20900?vs=57239&id=57245

BRANCH
  D20900

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/passworddialog.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20900: Reject invalid keys

[Oleg Solovyov]

McPain updated this revision to Diff 57239.
McPain retitled this revision from "Reject short PSK passwords" to "Reject 
invalid keys".
McPain edited the summary of this revision.
McPain added a comment.


  validate WPA-PSK and WEP keys

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20900?vs=57237&id=57239

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/passworddialog.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20900: Reject short PSK passwords

[Oleg Solovyov]

McPain updated this revision to Diff 57237.
McPain added a comment.


  Use validation

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20900?vs=57189&id=57237

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/passworddialog.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

McPain added a comment.


  In D20788#458047 , @jgrulich wrote:
  
  > You said it's broken so I would preffer not landing a broken patch.
  
  
  I thought it was a regression when I applied this patch. Could reproduce an 
error (see D20900 ) without it

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20788

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

McPain requested review of this revision.
McPain added a comment.
This revision is now accepted and ready to land.


  Tomorrow I'll land this patch, but I submitted another one
  
  https://phabricator.kde.org/D20900

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20788

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20900: Reject short PSK passwords

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
McPain requested review of this revision.

REVISION SUMMARY
  PasswordDialog accepted all WPA-PSK keys, included ones shorter than 8
  characters, which causes storing them in user's wallet.
  In that case, no new secrets will be requested from user: plasma-nm will
  silently fail to connect unless key is edited or deleted.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D20788

REVISION DETAIL
  https://phabricator.kde.org/D20900

AFFECTED FILES
  kded/secretagent.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

McPain added a comment.


  In D20788#457772 , @jgrulich wrote:
  
  > I think resetting the model might not be necessary, when 
addAvailableConnection() is called, it then updates item with a new available 
connection, which invalidates the filter anyway or at least it should.
  
  
  For some unknown reason, it doesn't.
  Trying to figure out what happens and why exactly it happens.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20788

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

McPain planned changes to this revision.
McPain added a comment.


  The patch "as-is" is broken.
  I had reports about resetting model right after clicking "Connect" button - 
model resets and there are no connection attempts.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20788

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20788: Reset model when there are new available connections

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 406765
  
  NetworkManager will remove all connections (at least wireless) and then add 
them again.
  When user creates a new connection and clicks "Disconnect" button before 
adding connections back, the one which user tried to connect to will disappear 
from list of available, and it will become impossible to reactivate it from 
applet.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20788

AFFECTED FILES
  libs/models/networkmodel.cpp

To: McPain, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Oleg Solovyov]

McPain added a comment.


  In D18979#441799 , @hein wrote:
  
  > Thanks! Do you need help landing this?
  
  
  Any instructions about "how to commit an accepted revision?"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Oleg Solovyov]

McPain added a comment.


  In D18979#428230 , @hein wrote:
  
  > Can you explain more what this is trying to achieve / what it solves with 
an example?
  
  
  https://bugsfiles.kde.org/attachment.cgi?id=117630

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Oleg Solovyov]

McPain requested review of this revision.
McPain added a comment.


  Seems like I can't use distinct screen mapping for each activity yet

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, sebas
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 401464
  
  According to FolderModel::filterAcceptsRow code, it is possible that 
folderview is used by containment but not associated with a screen.
  In case of m_screen == -1 there was no information about which items we 
should filter out.
  
  Instead, we do not change m_screen to -1 and we can filter out items that 
does not belong to our screen.
  m_screenUsed shows whether folderview is associated with a screen or not

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: McPain
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in foldermodel.cpp:170
> Also I don't think I understand this:
> 
> - Delay this via queued connection, such that the row is available and can be 
> mapped
> 
> at the point of rowsInserted() the row should be available, If not we have a 
> source model bug.

like I said, in 
https://phabricator.kde.org/R119:cc9c3d32a381980e367aa893c6796d611c7a33a7 the 
Qt::QueuedConnection was removed from connection, but the comment was unchanged

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain, davidedmundson
Cc: ngraham, davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain added a comment.


  Somebody review this for me, please, I'm too far away from actually testing it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain requested changes to this revision.
McPain added a comment.
This revision now requires changes to proceed.


  That's what I got with this patch.
  F6563817: изображение.png 
  
  Please remove Qt::QueuedConnection from both connections.
  Additionally, remove the references from comments

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#378768 , @davidedmundson 
wrote:
  
  > > Thanks. Any examples in KDE? I can't implement this from scratch right 
now.
  >
  > There is not, it would requires writing new C code.
  >  It's something I can help with.
  
  
  What/where I can start with?

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> fvogt wrote in foldermodel.cpp:154
> It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is 
> it done implicitly?

According to e94888701 
 and 
cc9c3d32a 
, 
the comment is wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain accepted this revision.
McPain added a comment.
This revision is now accepted and ready to land.


  It works, thanks.
  Removed D17689  and D17707 
 patches so I close then

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

[Oleg Solovyov]

McPain added a comment.


  In D17689#391265 , @hein wrote:
  
  > Here's my take: https://phabricator.kde.org/D18182
  
  
  is this intentional you mentioned *this* review, not 
https://phabricator.kde.org/D17707?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

[Oleg Solovyov]

McPain added a comment.


  In D17689#379900 , @hein wrote:
  
  > Cool, thanks for the update. I'm a bit flooded before the Christmas 
holidays, but I'll try to make sense of this in early 2019.
  
  
  ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17809: Check icon positions after move

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> positioner.cpp:418
> + */
> +while ((!isBlank(to) && from != to) || toIndices.contains(to)) {
>  to++;

AFAIK, the first part of condition is "check if `to` is blank and if it's not, 
check whether we're not moving icon to itself, and if we do, it's alright"
The second part is "check if we're already moving another icon to `to` and if 
we do so, try `to+1`"

REVISION DETAIL
  https://phabricator.kde.org/D17809

To: McPain, #plasma, hein
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17809: Check icon positions after move

[Oleg Solovyov]

McPain updated this revision to Diff 48238.
McPain added a comment.


  Fixed condition mistake

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17809?vs=48220&id=48238

REVISION DETAIL
  https://phabricator.kde.org/D17809

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: McPain, #plasma, hein
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17809: Check icon positions after move

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 402574
  
  When we're moving a bunch of icons to the area which is already busy, we 
didn't check whether we're moving icons to different places.
  
  Now we check additionally if we're moving icon to the place already taken by 
previously moved icons.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17809

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: McPain
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17707: FolderView: set sort mode to unserted after catching insert signal

[Oleg Solovyov]

McPain created this revision.
McPain added reviewers: hein, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  When new item is created, the initMaps() is called. Positioner will init his 
maps relying on folderview.sortMode() == 0 (alphanumeric sort)
  For example, we have three icons: (1, 2, 3)
  If we create a "12" icon, it should be (1, 2, 3, 12), but it is (1, empty, 2, 
3, 12):
  (1, 2, 3) -> create -> (1, 12, 2, 3) -> move(0, 3) -> (1, empty, 2, 3, 12) we 
moved to (0,4) because (0,3) is busy
  
  Before patch:
  F6493015: after.png 
  
  After patch:
  F6493084: Screenshot_20181220_141629.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17707

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: McPain, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17689: Positioner: call initMaps even if m_enabled == false

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  see BUG: 401023

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

AFFECTED FILES
  plasma-desktop/containments/desktop/plugins/folder/positioner.cpp

To: McPain
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  Anybody?

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17508: Simplify perStripe definition

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  We can get rid of double-checking of
  
  > gridView.flow == GridView.FlowLeftToRight
  
  because the priority of ?: operator is **lower** than the priority of 
division.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17508

AFFECTED FILES
  plasma-desktop/containments/desktop/package/contents/ui/FolderView.qml

To: McPain, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcmformats.cpp:322
> I don't understand, why is this sometimes empty?

Sorry for delayed reply.

In KCMFormats::initCombo we add locales to combo boxes.
First we add a QString() for "No change" option and then we add all possible 
locales.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain updated this revision to Diff 46892.
McPain added a comment.


  Default limit: 25% -> 10%
  Fix typos
  Auto detect swap, removed "includeSwap" setting
  KSysGuard: show kill button (implemented in D17366 
)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17217?vs=46407&id=46892

REVISION DETAIL
  https://phabricator.kde.org/D17217

AFFECTED FILES
  plasma-workspace/CMakeLists.txt
  plasma-workspace/freememorynotifier/CMakeLists.txt
  plasma-workspace/freememorynotifier/COPYING
  plasma-workspace/freememorynotifier/Messages.sh
  plasma-workspace/freememorynotifier/README
  plasma-workspace/freememorynotifier/freememorynotifier.cpp
  plasma-workspace/freememorynotifier/freememorynotifier.desktop
  plasma-workspace/freememorynotifier/freememorynotifier.h
  plasma-workspace/freememorynotifier/freememorynotifier.kcfg
  plasma-workspace/freememorynotifier/freememorynotifier.notifyrc
  plasma-workspace/freememorynotifier/freememorynotifier_prefs_base.ui
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.cpp
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.desktop
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.h
  plasma-workspace/freememorynotifier/module.cpp
  plasma-workspace/freememorynotifier/module.h
  plasma-workspace/freememorynotifier/org.kde.FreeMemoryNotifier.xml
  plasma-workspace/freememorynotifier/settings.kcfgc
  plasma-workspace/systemmonitor/ksystemactivitydialog.cpp
  plasma-workspace/systemmonitor/ksystemactivitydialog.h
  plasma-workspace/systemmonitor/main.cpp

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  If ksysguard was invoked from freememorynotifier directly, every process is 
displayed with its own kill button.
  In most "OOM-risky" cases it is required to kill one and only one process.
  
  Clicking on his own "Kill" button is cheaper than selecting it from list and 
clicking the main "Kill" button (2 clicks > 1 click)
  Also, you cannot hide this column by accident or show it when invoked by 
hotkey (Ctrl+Esc by default).
  
  Since it's invoked with --ignore-config option I implemented earlier (D17217 
) any layout changes won't be stored in 
config.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D17366

AFFECTED FILES
  libksysguard/processui/ProcessModel.cpp
  libksysguard/processui/ProcessModel.h
  libksysguard/processui/ksysguardprocesslist.cpp
  libksysguard/processui/ksysguardprocesslist.h

To: McPain
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367842 , @davidedmundson 
wrote:
  
  > There's also an alternative that I'd like to suggest:
  >  According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt 
there's a system called "memory pressure" you can watch for events on a 
specific FD with various levels of out-of-memory-ness. A lot cheaper than 
polling, far more reliable, and following the system's OOM configuration. 
Getting that in at a frameworks level so it can be hooked up to notifications 
in this case, but also garbage collections in UI code could be pretty cool.
  
  
  Thanks. Any examples in KDE? I can't implement this from scratch right now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367545 , @abetts wrote:
  
  > Is having this feature an optional feature? Can it be turned off?
  
  
  I'll make the notification "disableable" tomorrow

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367525 , @ngraham wrote:
  
  > Thanks for all the work!
  >
  > ...But is this actually useful or actionable for the majority of users? 
Free space is a fairly understandable concept: if you run out, you need to 
delete things to make more room before you can add more stuff. It won't fix 
itself unless the user does something. But memory pressure requires a much 
greater technical understanding and isn't subject to the same conditions. When 
the system is using up 75% of the available memory, there isn't necessarily a 
problem at all. Apps will move to swap automatically. Even if there is a 
problem, it's only temporary, and it may fix itself if the user does nothing as 
the system shuffles things around.
  >
  > I worry that this notifier would just be yet another annoying pop-up that 
people dismiss because they don't understand it.
  
  
  Sometimes I see what happens if you're running out of memory and oom can't do 
anything - the whole system halts and only solution for this is hard reset with 
all unsaved data lost.
  25% is not hardcoded value, you can reduce threshold down to 1% and also you 
can include your swap space in settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  FreeMemoryNotifier will warn when free RAM is running out.
  By default, it is 25% without swap space.
  
  Like freespacenotifier, it will check every 5 seconds for amount of free 
memory and
  warn every time when it drops below limit and when free space amount drops 
more than half of previous value
  
  User can either kill most greedy process immediately or open a task manager 
to kill unneeded processes manually.
  Task manager was patched to ignore global config and show only user own 
processes, sorted by memory used in descending order.
  
  The settings are available at new KCM located in Desktop Behavior category.
  KCM and KDED modules are linked through DBus - committed settings are applied 
immediately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

AFFECTED FILES
  plasma-workspace/CMakeLists.txt
  plasma-workspace/freememorynotifier/CMakeLists.txt
  plasma-workspace/freememorynotifier/COPYING
  plasma-workspace/freememorynotifier/Messages.sh
  plasma-workspace/freememorynotifier/README
  plasma-workspace/freememorynotifier/freememorynotifier.cpp
  plasma-workspace/freememorynotifier/freememorynotifier.desktop
  plasma-workspace/freememorynotifier/freememorynotifier.h
  plasma-workspace/freememorynotifier/freememorynotifier.kcfg
  plasma-workspace/freememorynotifier/freememorynotifier.notifyrc
  plasma-workspace/freememorynotifier/freememorynotifier_prefs_base.ui
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.cpp
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.desktop
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.h
  plasma-workspace/freememorynotifier/module.cpp
  plasma-workspace/freememorynotifier/module.h
  plasma-workspace/freememorynotifier/org.kde.FreeMemoryNotifier.xml
  plasma-workspace/freememorynotifier/settings.kcfgc
  plasma-workspace/systemmonitor/ksystemactivitydialog.cpp
  plasma-workspace/systemmonitor/ksystemactivitydialog.h
  plasma-workspace/systemmonitor/main.cpp

To: McPain, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:111
> can you put this in the commit description as well?

How to get commit access?

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: mart, davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  Any ideas how to fix the bugs I mentioned above?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  Additionally, tooltips are glitching if you move the mouse pointer too fast 
between items{F6324386 }

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  Found out that sometimes displayed text appears to be elided (not always 
reproducible)
  Resolution: 1920x1080, dpi: 142
  
  F6324374: Screenshot_20181012_165807.png 


REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  Anybody?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16038: Allow dictionary runner to search multiple times

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: jriddell.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Any time we search a word definition we add a source to our match engine but 
we never remove it.

TEST PLAN
  1. Open krunner
  2. Search a word definition
  3. Close krunner
  4. Open krunner
  5. Search the same word definition one more time
  
  Expected result: the definition appears again
  Actual result: there are no definitions shown.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16038

AFFECTED FILES
  runners/dictionary/dictionarymatchengine.cpp
  runners/dictionary/dictionarymatchengine.h

To: McPain, jriddell
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> main.qml:138
>  
> -readonly property int thickness: 
> Math.ceil(Math.min(parent.width, parent.height) / units.iconSizes.small)
>  

We need to make thickness independent from length.

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain updated this revision to Diff 42413.
McPain added a comment.


  (height * 2) + spacer.height -> (height - spacer.height) / 2

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15333?vs=41157&id=42413

REVISION DETAIL
  https://phabricator.kde.org/D15333

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:111
> Please explain the rationale behind this.
> 
> Especially the spacer.width being divided by 2 in the second part of the 
> statement.

> Especially the spacer.width being divided by 2 in the second part of the 
> statement.

Look at all the parentheses I wrote ;)
I divide by two a *subtraction* of spacer.width from width.

Former we calculated a button size to fit the whole widget vertically (if the 
layout is horizontal) and vice versa but what if we don't have enough space to 
fit the widget horizontally?

We have a 100x100 field. Okay, let height = 90 (margins, etc)
Then, first button 90x90, spacer 5x90 (still okay), and one more button 90x90 
(oops, fail: the widget is 185x90)

Now we check the second dimension and shrink the buttons when necessary.
First button 45x45, spacer 5x45, second button 45x45. The widget if 95x45, and 
it fits now.

So, we have to subtract spacer width from parent width and divide it by 2, 
because we have two buttons and check if it's smaller than height. If so, we 
fit in the width.

Same thing when layout is vertical.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

To: McPain, #plasma, ngraham
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

[Oleg Solovyov]

McPain added a comment.


  Before: F6252186: изображение.png 
  After: F6252262: изображение.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

[Oleg Solovyov]

McPain added a comment.


  In D14064#322643 , @davidedmundson 
wrote:
  
  > Urgh. Just read the code.
  >
  > We don't reset when we type a new letter. To do so would have a jumpy ui. 
Instead we reset when we get results back.
  >
  > That leaves a problem when you search for "firefo" ( with 1 result) to 
"firefodfhhxtffrdh" with zero results. Which is what this timer "solves"
  >
  > Clearly its not a good solution to the problem. Changing it to 5 seconds 
isn't helping.
  
  
  which solution would be good?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik, davidedmundson
Cc: davidedmundson, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 398493

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

AFFECTED FILES
  kcms/formats/kcmformats.cpp

To: McPain, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 398356

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

To: McPain, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a subscriber: ngraham.
McPain added a comment.


  In D14895#320987 , @ngraham wrote:
  
  > +1 for the concept. No opinion about the notification, but I think it's 
fine. Removing myself as a reviewer since I don't feel qualified to offer a 
code review. But sounds like you've got a shipit! You need someone to land it 
for you, right?
  
  
  Right. Nobody gave me a commit access yet

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik
Cc: ngraham, anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#320523 , @ngraham wrote:
  
  > Thanks, the patch applies now.
  >
  > Can you verify that this works for you? When I apply the patch (and reboot 
for good measure), I still don't see tooltips for items whose names are elided 
in KRunner.
  
  
  It works for me

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#319839 , @ngraham wrote:
  
  > The patch does not apply because of an extraneous `milou` in the path for 
your diff:
  >
  > Consider setting up `arc`; it makes the patch submission process so much 
simpler and less error-prone. :)
  >
  > 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  
  Also, I don't have arcanist in my repo (I'm using ALT linux)

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a comment.


  Just in case, I don't have commit access

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 40973.
McPain marked 12 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=40923&id=40973

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain updated this revision to Diff 40956.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15247?vs=40924&id=40956

REVISION DETAIL
  https://phabricator.kde.org/D15247

AFFECTED FILES
  lib/qml/ResultDelegate.qml

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  In case of something long in krunner you can't read the whole string because 
of one line restriction and fixed krunner width.
  
  This patch enables tooltips where you can read anything krunner shows.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

AFFECTED FILES
  milou/lib/qml/ResultDelegate.qml

To: McPain
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 40923.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39934&id=40923

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in soliddeviceengine.cpp:555
> I think you can just move the notification to
> 
> connect(job, &KIO::FileSystemFreeSpaceJob::result, ...) {
> 
> if (job->error() == ERR_SERVER_TIMEOUT) {
> 
>   
> 
> }
> }
> 
> but I haven't tested that.

I did. Job will never finish in that case

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in soliddeviceengine.cpp:560
> Sure, it /might/ work, but you're still fetching a random window N  seconds 
> after a user event.
> 
> I don't see how we can know that will result in correct behaviour.

Any ideas how to do it correctly?

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in soliddeviceengine.cpp:555
> not sure you need this timer
> 
> 1. You should still get the job finishing with error ERR_SERVER_TIMEOUT. 
> (untested, but the protocol manager in the client does have some stuff doing 
> this)
> 
> 2. if you don't get a progress bar for a drive that's frozen anyway, do you 
> really care?

There are solutions to notify user about stuck FS without that timer, right?

> davidedmundson wrote in soliddeviceengine.cpp:560
> We don't know which window will be active when this timer fires. Which means 
> the behavior to dismiss is somewhat random.

I tested it - works for me.

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 39934.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39933&id=39934

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 39933.
McPain marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39929&id=39933

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in soliddeviceengine.cpp:564
> You can remove it, see below.

What if it creates another job working on the same path?

The purpose is "check if nobody is working on path", not "save the timer 
pointer"

> anthonyfieroni wrote in soliddeviceengine.cpp:588
>   job->start();
> 
> as well.

Job starts without it

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 39929.
McPain added a comment.


  Used KIO::FileSystemFreeSpaceJob

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39901&id=39929

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a comment.


  In D14895#310633 , @broulik wrote:
  
  > Might not be an issue as you call `setData` anyway but just something I 
want you to keep in mind for testing.
  
  
  something like
  
setData(udi, I18N_NOOP("Free Space"), QVariant(0));
setData(udi, I18N_NOOP("Free Space Text"), KFormat().formatByteSize(0));
setData(udi, I18N_NOOP("Size"), QVariant(0));
  
  or what?
  And what to do after obtaining **real** data?

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a comment.


  In D14895#310633 , @broulik wrote:
  
  > Might not be an issue as you call `setData` anyway but just something I 
want you to keep in mind for testing.
  
  
  I

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a comment.


  In D14895#310633 , @broulik wrote:
  
  > Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently 
supposed to return `true`
  
  
  Who will use that `true`?
  I didn't found any places where that value is used.
  
  The only place I found ignores it:
  
void SolidDeviceEngine::deviceChanged(const QString& udi, const QString 
&property, const QVariant &value)
{
setData(udi, property, value);
updateSourceEvent(udi);
}

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain added a comment.


  In D14895#310535 , @davidedmundson 
wrote:
  
  > Thanks for looking into this.
  >
  > Whilst this looks fine,  we have a more standard abstraction layer for 
async IO via KIO.
  >  There's a FileSystemFreeSpaceJob which should work here.
  
  
  We can always do it later, fixibg bug itself is more important than making it 
through KIO

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 39901.
McPain marked 3 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39897&id=39901

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 39897.
McPain added a comment.


  Removed useless debug string

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39896&id=39897

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain created this revision.
McPain added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 397537
  
  Earlier plasmashell assumed that you'll get free space info immediately 
(which is not true in case of losing connection to server containing a mounted 
filesystem - statfs will wait for response forever and freeze everything since 
it's happening in main thread)
  
  I moved obtaining that info into different thread so that case won't freeze 
anything anymore.
  It creates exactly one thread per one path. If a path is already being 
processed, new thread won't be created.
  Also I implemented a timer used to notify about broken connection after 15 
seconds.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

[Oleg Solovyov]

McPain added a comment.


  ping?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

[Oleg Solovyov]

McPain added a comment.


  In D14064#291125 , @broulik wrote:
  
  > I would rather see a thorough investigation on what this does and why it is 
or is not needed. There's a couple of slow runners that suffer issues because 
of premature resetting but I don't understand why it has this code in the first 
place.
  
  
  As far as I know, krunner uses milou to launch queries:
  
  https://cgit.kde.org/milou.git/tree/lib/sourcesmodel.cpp#n215

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary haven't enough time to complete query before resetting by milou

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  https://bugs.kde.org/show_bug.cgi?id=390776

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

AFFECTED FILES
  lib/sourcesmodel.cpp

To: McPain, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14063: KRunner Dictionary can't find anything

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  https://bugs.kde.org/show_bug.cgi?id=390776

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14063

AFFECTED FILES
  BUILD/kdeplasma-addons-5.12.6/runners/dictionary/dictionarymatchengine.cpp

To: McPain, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10338: Don't show tooltips for inactive windows

[Oleg Solovyov]

McPain accepted this revision.
McPain added a comment.
This revision is now accepted and ready to land.


  This commit looks good and it works just as planned

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10338

To: broulik, #plasma, graesslin, McPain
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9506: milti-screen sleep fix

[Oleg Solovyov]

McPain abandoned this revision.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D9506

To: McPain, sebas, drosca
Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9506: milti-screen sleep fix

[Oleg Solovyov]

McPain added a comment.


  UPD:
  I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB)
  If I swap monitors, KSCeen doesn't work (noticed it past friday evening)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D9506

To: McPain, sebas, drosca
Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart