Review Request: forgetten slot defination
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1569/ --- Review request for Plasma and Aaron Seigo. Summary --- checkAvailability must be a slot because it was used by connect( in plasma-desktop-runner.cpp:45 QObject::connect(QDBusConnection::sessionBus().interface(), SIGNAL(serviceOwnerChanged(QString,QString,QString)), this, SLOT(checkAvailability(QString,QString,QString))); This addresses bugs a, be, checkAvailability, instead, method, must, normal, of, and slot. https://bugs.kde.org/show_bug.cgi?id=a https://bugs.kde.org/show_bug.cgi?id=be https://bugs.kde.org/show_bug.cgi?id=checkAvailability https://bugs.kde.org/show_bug.cgi?id=instead https://bugs.kde.org/show_bug.cgi?id=method https://bugs.kde.org/show_bug.cgi?id=must https://bugs.kde.org/show_bug.cgi?id=normal https://bugs.kde.org/show_bug.cgi?id=of https://bugs.kde.org/show_bug.cgi?id=slot Diffs - trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h 1022509 Diff: http://reviewboard.kde.org/r/1569/diff Testing --- Thanks, Omer F. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: forgetten slot defination
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1569/ --- (Updated 2009-09-11 22:10:15.009367) Review request for Plasma and Aaron Seigo. Summary --- checkAvailability must be a slot because it was used by connect( in plasma-desktop-runner.cpp:45 QObject::connect(QDBusConnection::sessionBus().interface(), SIGNAL(serviceOwnerChanged(QString,QString,QString)), this, SLOT(checkAvailability(QString,QString,QString))); Diffs - trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h 1022509 Diff: http://reviewboard.kde.org/r/1569/diff Testing --- Thanks, Omer F. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fixing Bball getting stuck at the corner
On 2009-07-19 00:16:17, Omer F. USTA wrote:
Hi , just to learn why or instead of common || ? in
if (m_bottom_right == 1 or m_bottom_left == 1) {
Sujith H wrote:
I changed it to '||'.
This looks committed with r999070 and r999083
it will be nice to mark as submitted
- Omer F.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/#review1655
---
On 2009-07-17 23:37:46, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/
---
(Updated 2009-07-17 23:37:46)
Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and
Sebastian Kügler.
Summary
---
The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it
doesn't stuck. I had added a feature that when dropped from right/left top
will make the ball bounce.
Diffs
-
/trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542
/trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542
Diff: http://reviewboard.kde.org/r/1054/diff
Testing
---
Tested in my laptop and works fine here.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fixing Bball getting stuck at the corner
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/#review1655
---
Hi , just to learn why or instead of common || ? in
if (m_bottom_right == 1 or m_bottom_left == 1) {
- Omer F.
On 2009-07-17 23:37:46, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/
---
(Updated 2009-07-17 23:37:46)
Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and
Sebastian Kügler.
Summary
---
The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it
doesn't stuck. I had added a feature that when dropped from right/left top
will make the ball bounce.
Diffs
-
/trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542
/trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542
Diff: http://reviewboard.kde.org/r/1054/diff
Testing
---
Tested in my laptop and works fine here.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/#review1656 --- QString appName(); -- QString appName() const; and QString QuicklaunchIcon::appName() -- QString QuicklaunchIcon::appName() const - Omer F. On 2009-05-22 05:13:57, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-22 05:13:57) Review request for Plasma, Aaron Seigo and Lukas. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: BackgroundListModel::removeBackground must be a slot but it wasn't
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/883/ --- Review request for Plasma. Summary --- @backgroundlistmodel.cpp: connect(m_dirwatch, SIGNAL(deleted(QString)), this, SLOT(removeBackground(QString))); used as Slot but it wasn't defined as slot in .h file Diffs - /trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h 986882 Diff: http://reviewboard.kde.org/r/883/diff Testing --- Thanks, Omer F. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
