D27078: Drag-and-drop files at the right coordinates
painlessroaster updated this revision to Diff 75238. painlessroaster added a comment. fix unnecessary/unintentional whitespace change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27078?vs=74819=75238 REVISION DETAIL https://phabricator.kde.org/D27078 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h To: painlessroaster, hein, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27078: fix for: Bug 416915 - broken keep of destination coordinates in drag-and-drop operations
painlessroaster created this revision. painlessroaster added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. painlessroaster requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27078 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h To: painlessroaster, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D10837: bad textarea width for rename file if filename too short
painlessroaster added a comment. Radek Bucek radek.bu...@voipmonitor.org REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10837: bad textarea width for rename file if filename too short
painlessroaster added a comment. I do not have a contributor account. Please commit this. REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10837: bad textarea width for rename file if filename too short
painlessroaster added a comment. new patch with correct rtl support REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10837: bad textarea width for rename file if filename too short
painlessroaster added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. > > Eike Hein wrote: > Can you give me a real name I can use on the commit? Radek Bucek radek.bu...@voipmonitor.org thank you for commit - Painless --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97884 --- On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > >
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? I do not have an account on github. - Painless --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97884 --- On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > >
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97884 --- Ship it! Ship It! - Painless Roaster On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > >  > > Painless Roaster wrote: > It is OK. The vertical scroller is dynamically added if need. His > addition preserves text position and text wrapping. Therefore scroller is > slightly to the right. > Try edit short text and add next characters until show scroller. You will > see that this is good. > > Eike Hein wrote: > It would be nicer if the overall editor would resize once the scrollbar > appears so the margins are still symmetric, avoiding the broken appearance in > the screenshot. > > Painless Roaster wrote: > Thank you for your review. But horizontal center of editbox with scroller > is not good idea. My main idea is 'the same text position and wrap in label > and edit box'. If edit box show/hide vertical scroller, position of text must > remain in place. Movement with editbox is disturbing for user (if user > inserted char for show scroller or remove char for hide scroller). Any news about use this patch to master branche? - Painless --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97371 ------- On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > >  > > Painless Roaster wrote: > It is OK. The vertical scroller is dynamically added if need. His > addition preserves text position and text wrapping. Therefore scroller is > slightly to the right. > Try edit short text and add next characters until show scroller. You will > see that this is good. > > Eike Hein wrote: > It would be nicer if the overall editor would resize once the scrollbar > appears so the margins are still symmetric, avoiding the broken appearance in > the screenshot. Thank you for your review. But horizontal center of editbox with scroller is not good idea. My main idea is 'the same text position and wrap in label and edit box'. If edit box show/hide vertical scroller, position of text must remain in place. Movement with editbox is disturbing for user (if user inserted char for show scroller or remove char for hide scroller). - Painless --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97371 ------- On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > >  It is OK. The vertical scroller is dynamically added if need. His addition preserves text position and text wrapping. Therefore scroller is slightly to the right. Try edit short text and add next characters until show scroller. You will see that this is good. - Painless --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97371 --- On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128423/ > --- > > (Updated Čec. 13, 2016, 1:13 odp.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 > > > Repository: plasma-desktop > > > Description > --- > > fix rename file (or folder) in folder plugin (and desktop in folder mode) > - enable multiline edit > - fix size and position > - fix escape from edit if user pressed Esc > - fix suppress open file (or folder) if user clicked in editbox > - fix size and position in popup mode > > > Diffs > - > > containments/desktop/package/contents/ui/FolderView.qml ced3507 > > Diff: https://git.reviewboard.kde.org/r/128423/diff/ > > > Testing > --- > > > Thanks, > > Painless Roaster > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- (Updated Čec. 13, 2016, 1:13 odp.) Review request for Plasma. Bugs: https://bugs.kde.org/show_bug.cgi?id=361097 https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097 Repository: plasma-desktop Description --- fix rename file (or folder) in folder plugin (and desktop in folder mode) - enable multiline edit - fix size and position - fix escape from edit if user pressed Esc - fix suppress open file (or folder) if user clicked in editbox - fix size and position in popup mode Diffs - containments/desktop/package/contents/ui/FolderView.qml ced3507 Diff: https://git.reviewboard.kde.org/r/128423/diff/ Testing --- Thanks, Painless Roaster ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- Review request for Plasma. Repository: plasma-desktop Description --- fix rename file (or folder) in folder plugin (and desktop in folder mode) - enable multiline edit - fix size and position - fix escape from edit if user pressed Esc - fix suppress open file (or folder) if user clicked in editbox - fix size and position in popup mode Diffs - containments/desktop/package/contents/ui/FolderView.qml ced3507 Diff: https://git.reviewboard.kde.org/r/128423/diff/ Testing --- Thanks, Painless Roaster ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
