D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  ok, cool.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  The greyborder around the submenu heading isn't consistent with the other 
main menu heading which have no border, and inconsistent with the Kirigami back 
button style but otherwise, it looks good.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  The whole area of the Kirigami style back button is clickable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  Yea, the hover border isn't necessary. Maybe the back navigation should work 
like how it does with Kirigami.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11757: Polish sidebar header appearance

[Richard Bowen]

richardbowen added a comment.


  I prefer the system settings as it currently is in 5.12, though the submenu 
heading could be a little bit darker.
  
  As for the changes made, I think the person that made the main sidebar header 
color different from the sub-sidebar header color did so intentionally, in line 
with the menu heirarchy. The horizontal line you added separating the search 
section from the sidebar options is cool though. The back navigation as it is 
is pretty clear, no need to turn it into a button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  The preferences-desktop-wallpaper icon beside "Configure Desktop" works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  In D11253#232632 , @ngraham wrote:
  
  > In D11253#232607 , @richardbowen 
wrote:
  >
  > > Since wallpaper is a feature of the desktop I don't think mentioning 
wallpaper in the context menu title is necessary.
  >
  >
  > The entire point of this patch is my assertion that making the mental leap 
"desktop contains wallpaper" is too high a bar for many users. It's obvious for 
developers like us, but for normal users, it's... less than obvious.
  >
  > > the word "Configure" is used throught plasma so  maybe that's a case to 
work with it.
  >
  > That was what I started with, but people thought "Configure Desktop and 
Wallpaper" was too long.
  
  
  I just asked my sister who never tried to change the desktop wallpaper on a 
computer before to change the wallpaper on Plasma and...she did, quite easily. 
She right clicked, read the menu options, and chose the one that made sense. I 
think you underestimate the general user.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Since wallpaper is a feature of the desktop I don't mentioning wallpaper in 
the context menu title is necessary. "Configure Desktop" sounds a little 
technical but with the wallpaper image beside it it should be more clear. the 
word Configure is used throught plasma so  maybe thats a case to work with it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Also how about a preferences shortcut for "Desktop Wallpaper" (or some other 
suitable text) searchable from the start menu and krunner? This would be 
similar to the other desktop preferences that are searchable like "Desktop 
Theme", "Desktop Effects", etc..
  
  F5763672: Screenshot_20180323_085008.png 
 F5763671: Screenshot_20180323_085252.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  In D11253#232189 , @mart wrote:
  
  > what about as text using Configure-desktop and as icon 
preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png 

  
  
  +1
  
  A big part of the desktop experience is the wallpaper so this looks good. 
Also the wallpaper setting is the first option in the "Configure Desktop" 
window so having this as the wallpaper icon beside "Configure Desktop" gives a 
good hint that setting the wallpaper is a function of Configure Desktop.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Richard Bowen]

richardbowen added a comment.


  Blue screen is fine with me but hey, I like blue.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  I wonder if one should dumb down the interface to accommodate this word 
scanning habit, where one doesn't really read stuff one just scans the screen 
for a keyword and then gets frustrated when the keyword (like "Wallpaper") 
doesn't show up . Well if it works then fine. The proposed text is quite long 
though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Richard Bowen]

richardbowen added a comment.


  Windows has the word "Personalize" which is quite descriptive. "Customize 
Desktop" sounds fine as well. but I think the word "Configure" is used more 
often throughtout the Plasma desktop.
  
  How often do you see users complaining about not knowing how to set the 
wallpaper? If they know what a desktop is then they should be able to figure it 
out. Similar to Windows it is accessed via a right click context menu.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart