Review Request: Plasma virus wallpaper no toolbutton
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3143/ --- Review request for Plasma. Summary --- This patch replaces the QToolButton (to select a custom background image) in the virus wallpaper config dialog with a KPushbutton. This way the button label is shown and the dialog now looks more similar to the ones from the 'image' and 'slideshow' wallpapers. Diffs - trunk/KDE/kdeplasma-addons/wallpapers/virus/virusconfig.ui 1098825 Diff: http://reviewboard.kde.org/r/3143/diff Testing --- Thanks, Sascha ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde 4.3 wallpaper extravaganza?
On Thursday 02 April 2009 11:28:34 you wrote: > Hi Sascha, > awesome and thanks for taking over! > What do you plan to change for 4.3? > I'm only aware of minor annoyances such as opening the configure wallpapers > dialog resetting the zoom and position. > Not much, I think fixing all remaining bugs is enough for know, it can still be feature-extended later on. > Greetings, > Frederik > > On Thursday 02 April 2009 11:19:53 Sascha Peilicke wrote: > > On Thursday 02 April 2009 05:36:49 you wrote: > > > hello everyone ... > > > > > > we have no fewer than SIX cool wallpapers sitting in playground right > > > now: > > > > > > mandelbrot > > > marble > > > pattern > > > qedje > > > virus > > > weather > > > > > > you know which of those you are responsible for. ;) > > > > > > i'd like to see as many of the as reasonable migrate into > > > kdeplasma-addons for 4.3; if you agree, please respond letting me know > > > and i'll move it on in or conversely you can do it yourself. > > > > > > i also see that there is quite a bit of code duplication happening > > > right now between the image file based ones. i'll try and sort that out > > > by making Plasma::Wallpaper a little less skeletal :) > > > > Hi, I'm currently responsible for the "marble" wallpaper, it's mostly > > done, only minor bugs here and there, Altough I haven't touched it for a > > while (due to too infrequent web access), I'll move it by myself then. -- Sascha Peilicke http://saschpe.wordpress.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDE 4.2 Toolbars
On Thursday 13 November 2008 00:16:07 Aaron J. Seigo wrote: > On Wednesday 12 November 2008, Matthias Fuchs wrote: > > Nuno Pinheiro schrieb: > > > Well some time ago I sudgested to Celeste that we should use in the > > > thoolbars text along side icons instead of text under icons. Couse: > > > [...] > > > 2 Saves precious vertical space. > > > > That is true, but keep in mind that if you do not run your apps in > > fullscreen horizontal space becomes more important. I would have to try > > it if there are apps where that would pose a problem. > > > > One would be the German version of Akregator, because of the long text: > > or one could fix the toolbars in Akrgator to be more sensible, e.g.: > > New Feed: > i hate that word "Feed" btw, it's total jargon; how about "Add News > Source"? if it wasn't for akregator-in-kontact, i'd even suggest removing > this from the toolbar altogether > > Fetch Feed: > Check for Updates > > Fetch All Feeds ... hur what? no, mimic KMail here: have one button with a > drop down that lists the individual feeds in it, and have the default click > action to be all feeds > > Abort Fetches: wtf? the stop button at the bottom of the window and a menu > entry is enough this does *not* belong in a tool bar > > What is This: another wtf. this so does not belong in the toolbar. > > that would leave us with: > > Add News Source > Check for Updates > > i assume that even in german that would fit ;) I would recommend having the "Next unread article" as default in the toolbar for convenience. As a native german speaker the two * Füge Nachrichtenquelle hinzu * Nachrichtenquellen aktualisieren would work but "feed" is so common nowadays and I assume no german speaker wants to read "Akregator Nachrichtenquellen-Leser" :-) -- Sascha Peilicke http://saschpe.wordpress.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[PATCH] Review request for plasma marble wallpaper (playground)
For Frederic Gladhorn and FYI.
This patch adds/changes a lot of features to the marble plasma wallpaper in
playground.
Re-enabled the stars plugin as current Marble trunk doesn't seem to crash on
it any further.
Moved to a more generic support for globe rotation schemes to allow something
like "hover on home location" or free rotation (with the marble navigation
plugin).
Mouse interaction was removed completely, this caused all sort of weird
troubles when interacting with plasma widgets (instead rotates the globe or
vice versa). Mouse scrolling previously used for zooming the globe is also
otherwise reserved for switching workspaces. Instead the user can enable the
marble navigation widget to zoom/rotate the globe.
Reworked the configuration screen to show only options which make sense
together. This means some values are shown and hidden based on selected globe
rotation behavior, marble theme etc. More generic "show placemarks" instead
of "show night, show citylights, show places" to not present too much config
detail to the user.
Maybe we should also change the name from "The Earth" to something more
descriptive or just "Marble globe" to advertise this great technology ^^
There still remains some work on tweaking zoom/rotate/pan to stop the user
from scrolling over the maps _edges_ on flat map projections (looks not too
nice currently). The patch mixes code cleanup and feature changes, but being
in playground and in early development stage, I was just too lazy to produce
distinct patches :-)
Affected files:
playground/base/plasma/wallpapers/marble/config.ui
playground/base/plasma/wallpapers/marble/marble.cpp
playground/base/plasma/wallpapers/marble/marble.h
playground/base/plasma/wallpapers/marble/CMakeLists.txt
playground/base/plasma/wallpapers/CMakeLists.txt
--
Sascha Peilicke
http://saschpe.wordpress.com
Index: wallpapers/marble/config.ui
===
--- wallpapers/marble/config.ui (Revision 897233)
+++ wallpapers/marble/config.ui (Arbeitskopie)
@@ -1,11 +1,11 @@
- PatternSettingsWidget
-
+ MarbleSettingsWidget
+
0
0
-357
+358
331
@@ -115,27 +115,44 @@
-
-
+
+
- &Follow sun position
+ Rotation:
-
- true
+
+ Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
-
-
-
- &Rotate automatically
-
+
+
+
+
+ Follow the sun
+
+
+
+
+ Hover above home location
+
+
+
+
+ Custom rotation
+
+
+
+
+ Custom placement
+
+
-
+
-
+
0
@@ -149,7 +166,7 @@
-L&ongitude Rotation:
+Longitude rotation:
Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
@@ -161,21 +178,12 @@
-
-
- 0
- 0
-
-
true
Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
-
-No rotation
-
°
@@ -194,7 +202,7 @@
-
+
0
@@ -208,7 +216,7 @@
-L&atitude Rotation:
+Latitude rotation:
Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
@@ -220,21 +228,12 @@
-
-
- 0
- 0
-
-
true
Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
-
-No rotation
-
°
@@ -252,8 +251,22 @@
-
-
+
+
+
+Set current position as home
+
+
+
+
+
+
+Enable navigation widget
+
+
+
+
+
0
@@ -267,7 +280,7 @@
-Update &Interval:
+Update every:
Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter
@@ -277,64 +290,42 @@
-
+
-
-
- 0
- 0
-
-
-
-Qt::WheelFocus
-
10
-0
+1
-10
+3600
-s
+ seconds
-
-No updates
-
-
-
-
- Show &cities
+
+
+
+ Qt::Horizontal
-
-
-
-
- 0
- 0
-
+
+
+
+ Determines whether all kind o
Re: [PATCH] Review request for plasma marble wallpaper (playground)
On Monday 15 December 2008 23:16:32 Aaron J. Seigo wrote: > On Monday 15 December 2008, Sascha Peilicke wrote: > > Mouse interaction was removed completely, this caused all sort of weird > > troubles when interacting with plasma widgets (instead rotates the globe > > or vice versa). > > are you saying that mouse events passed to the wallpaper would end up > passed to the widget as well? were you accept()ing the mouse event passed > in? if these are bugs in libplasma, i'd like to know about them so they can > be fixed. =) Not that I know of, events are accept()-ed, it just feels wrong to have direct mouse interaction with the background. As a user I get confused whether I'm actually interacting with my plasmoids or with the globe behind it. So it's just about usability, which is arguable, of course. > > Maybe we should also change the name from "The Earth" to something more > > descriptive or just "Marble globe" to advertise this great technology ^^ > > "The Earth" is pretty descriptive, i think =) it's more obvious what it is > compared to "Marble Globe" as well (i wouldn't know what that was if i > didn't know that Marble was a KDE mapping application). in plasma we have a > policy of not showing the technical name of something (jargon) when there > is a functional name to it. ergo things like Activity instead of > Containment. Agreed, my issue is that "The Earth" is currently able to show "The Moon" (the rest of our solar system may follow), so maybe just "Globe" is better. -- Sascha Peilicke http://saschpe.wordpress.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Cashew lost at lower screen res
I'm running KDE-4.2 Beta 1 and discovered that the Cashew won't update it's position when placed in the lower right corner or the right or bottom edge while lowering resolution, the other edges/corners work fine. It fine again when reverting the resolution change, so it seems to just not update it's position on res changes. Is this bug already known? A similar thing happens in the ZUI but I guess this is another story. -- Sascha Peilicke http://saschpe.wordpress.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Review request for plasma marble wallpaper (playground)
On Wednesday 17 December 2008 12:53:30 Frederik Gladhorn wrote: > Hi Sascha, > thanks for looking at the marble wallpaper - that's much appreciated from > my side :) > I have had no time to look at the patch at all yet, will do so on the > weekend. I attached a more current one here :-) > > On Monday 15 December 2008 21:41:16 Sascha Peilicke wrote: > > For Frederic Gladhorn and FYI. > > > > > > This patch adds/changes a lot of features to the marble plasma wallpaper > > in playground. > > > > Re-enabled the stars plugin as current Marble trunk doesn't seem to crash > > on it any further. > > Seems good to me, I enabled it again here and have had no trouble with it > lately. > > > Moved to a more generic support for globe rotation schemes to allow > > something like "hover on home location" or free rotation (with the marble > > navigation plugin). > > > > Mouse interaction was removed completely, this caused all sort of weird > > troubles when interacting with plasma widgets (instead rotates the globe > > or vice versa). Mouse scrolling previously used for zooming the globe is > > also otherwise reserved for switching workspaces. Instead the user can > > enable the marble navigation widget to zoom/rotate the globe. > > I had not a single weird interaction - you just need to differentiate > between applet and wallpaper and you'll be fine. > This is the change that I don't agree with. For me the wallpaper is all > about being fancy-interactive-hotness and it's sole purpose is to brag > about KDE hotness with it. > Many people hate the wheel on workspace option, I don't have a strong > opinion either way, but I think the wheel is much better used to zoom here. > This wallpaper doesn't bring speed or a faster work flow - it is just a > toy, so people using the wheel to switch desktops won't use this wallpaper > I guess. My problem with the marble navigation widgets is that they clutter > the desktop. I want to see that globe thingy, not lots of controls. > Maybe a checkbox to enable mouse interaction? More options ftw...? Yeap, this seems to need a bit more discussion, here's what I currently have: 4 rotation modes, 2 already known (follow sun, custom rot), + hover on home + free movement. free movement basically means no movement + a checkbox which enables the marble navigation widget. I agree that it would be a bit clumsy to be shown all the time, so this is more intented to be enabled, move the globe in place, disable it and enjoy. A bonus is that the nav widget can be customized, so I stripped it down a bit, this is what it looks like when enabled: http://img150.imageshack.us/img150/4710/marblenavwidgetwc3.png > I started it to show a friend who had something similar once upon a time in > some proprietary environment how flexible and great our frameworks are. > I'd even like to open a browser with the placemarks - same as marble does. > Wikipedia ftw. Would be great to have, this would be the real semantic desktop ^^ > > Reworked the configuration screen to show only options which make sense > > together. This means some values are shown and hidden based on selected > > globe rotation behavior, marble theme etc. More generic "show placemarks" > > instead of "show night, show citylights, show places" to not present too > > much config detail to the user. > > Very good, I just threw in every marble option I could find ;) making it > more understandable is a good idea. > > > Maybe we should also change the name from "The Earth" to something more > > descriptive or just "Marble globe" to advertise this great technology ^^ > > See Aarons reply, I'm fine with Globe, I'm a little against putting Marble > here. Updated the desktop file accordingly. -- Sascha Peilicke http://saschpe.wordpress.com Index: marble/config.ui === --- marble/config.ui (revision 897996) +++ marble/config.ui (working copy) @@ -1,11 +1,11 @@ - PatternSettingsWidget - + MarbleSettingsWidget + 0 0 -357 +358 331 @@ -115,27 +115,44 @@ - - + + - &Follow sun position + Rotation: - - true + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - &Rotate automatically - + + + + + Follow the sun + + + + + Hover above home location + + + + + Custom rotation + + + + + Custom placement + + - +
