D24097: Use symbolic icon in intro page

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  Use the monochrome icon instead of the colorful icon because of dark themes

REPOSITORY
  R124 System Settings

BRANCH
  symbolic-icon-intro-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24097

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24049: add tooltips to the intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66387.
tienisto added a comment.


  using enums (ToolTipPosition) instead of booleans

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24049?vs=66376&id=66387

BRANCH
  intropage-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24049

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/ToolTips/tooltipmanager.cpp
  sidebar/ToolTips/tooltipmanager.h
  sidebar/package/contents/ui/IntroIcon.qml

To: tienisto, #vdg, ngraham, GB_2
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24049: add tooltips to the intro page

[Tien Do Nam]

tienisto added inline comments.

INLINE COMMENTS

> ngraham wrote in SidebarMode.cpp:581
> Is there a strong reason to move these around?

I want to have all the initializations of tooltip managers in one place. I 
couldn't add the third manager there because the placeHolderWidget is not 
initialized yet

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D24049

To: tienisto, #vdg, ngraham, GB_2
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24049: add tooltips to the intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66376.
tienisto added a comment.


  remove unnecessary brackets in onEntered and onExited

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24049?vs=66374&id=66376

BRANCH
  intropage-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24049

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/ToolTips/tooltipmanager.cpp
  sidebar/ToolTips/tooltipmanager.h
  sidebar/package/contents/ui/IntroIcon.qml

To: tienisto, #vdg, ngraham, GB_2
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24049: add tooltips to the intro page

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  Add tooltips to the most used settings in the intro page

TEST PLAN
  Move your cursor on one of the most used settings, a tooltip will appear

REPOSITORY
  R124 System Settings

BRANCH
  intropage-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24049

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/ToolTips/tooltipmanager.cpp
  sidebar/ToolTips/tooltipmanager.h
  sidebar/package/contents/ui/IntroIcon.qml

To: tienisto, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66251.
tienisto added a comment.


  use Kirigami units for vertical margin

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66250&id=66251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66250.
tienisto added a comment.


  change "Frequently used:" to "Frequently Used"

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66246&id=66250

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto added a comment.


  What do other people think about the light rectangle around the "frequently 
used" icons?
  Because I am in favor of this :)

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66246.
tienisto added a comment.


  use rounding again and delete unused id

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66245&id=66246

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66245.
tienisto added a comment.


  move Kirigami.Heading inside ColumnLayout

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66244&id=66245

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto added a comment.


  In D23984#532719 , @GB_2 wrote:
  
  > What about a design like this? F7363944: System Settings Intro Page 
Mockup.png 
  
  
  I actually like the light rectangle more because it increase the connection 
between the icons. However if you think so ^^
  What I don't like about your version is that there is so much empty space 
around the content...
  Here is my new version, what do you think?
  
  F7364198: Compromise #1.png 

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66244.
tienisto added a comment.


  Remove light rectangle; add Plasma icon; more Kirigami units

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66205&id=66244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto marked 4 inline comments as done.
tienisto added a comment.


  Okay. Now I am using more Kirigami units now. About "KDE Plasma" vs "Plasma" 
I am not sure because Plasma is less known than KDE.
  Regarding the round corners, I have decreased the radius a little bit. Hope 
it is better now? :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66205.
tienisto added a comment.


  less rounded corners and decrease use of hard coded numbers

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66201&id=66205

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto marked 3 inline comments as done.
tienisto added a comment.


  Thanks for your feedback. I was actually lighten the background instead of 
darken it :)
  But still, Qt.darker/Qt.lighter is much simpler!

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender

D23984: [System Settings] redesign intro page

[Tien Do Nam]

tienisto updated this revision to Diff 66201.
tienisto added a comment.


  simplify brighter background

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23984?vs=66192&id=66201

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, GB_2, ngraham
Cc: anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender

D23984: redesign intro page

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  the intro page got a visual overhaul

TEST PLAN
  Open systemsettings and see

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23984

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart