D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1c9d021daf4e: Create a hotspot KCM for Plasma Mobile 
(authored by tfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29019?vs=80765&id=80796#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80765&id=80796

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich, nicolasfella, cblack
Cc: cblack, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
tfella added a comment.


  F8251937: HotspotKcm.png 

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
tfella updated this revision to Diff 80765.
tfella added a comment.


  Use network-wireless-hotspot as icon

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80714&id=80765

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80714.
tfella marked an inline comment as done.
tfella added a comment.


  Change id

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80689&id=80714

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80689.
tfella added a comment.


  fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80688&id=80689

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella added a comment.


  Git/Arc decided to do weird things, I hope I didn't break it

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80688.
tfella marked 6 inline comments as done.
tfella added a comment.


  Fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80683&id=80688

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80683.
tfella added a comment.


  Whitespace fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80679&id=80683

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella created this revision.
tfella added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REVISION SUMMARY
  Implements T12895 . Might include things 
like bluetooth and usb tethering in the future when implemented

TEST PLAN
  Edit SSID and password, start, connect

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28838: show ssid as title in mobile wifi connection editor

2020-04-14 Thread Tobias Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e527a2f0026f: show ssid as title in mobile wifi 
connection editor (authored by tfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28838?vs=80152&id=80153

REVISION DETAIL
  https://phabricator.kde.org/D28838

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: tfella, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28838: fix the title of the mobile wifi kcm connection editor

2020-04-14 Thread Tobias Fella 
tfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileWifiTitle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28838

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: tfella, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

2020-04-14 Thread Tobias Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm 
(authored by tfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28799?vs=80143&id=80146

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, ngraham, jgrulich, jbbgameich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

2020-04-14 Thread Tobias Fella 
tfella updated this revision to Diff 80143.
tfella marked an inline comment as done.
tfella added a comment.


  More fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28799?vs=80076&id=80143

BRANCH
  mobileWifiFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, ngraham, jgrulich, jbbgameich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

2020-04-14 Thread Tobias Fella 
tfella updated this revision to Diff 80076.
tfella added a comment.


  Minor Fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28799?vs=80029&id=80076

BRANCH
  mobileWifiFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

2020-04-13 Thread Tobias Fella 
tfella created this revision.
tfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REVISION SUMMARY
  Previous refactoring and existing errors made editing connections impossible. 
Also, existing work for adding hidden networks was broken. By fixing these 
problems, this patch implements T12893 .

TEST PLAN
  Test adding and editing connections

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileWifiFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart