Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/ --- (Updated Feb. 8, 2017, 3:50 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- This is the first step towards not loosing the sort order of the task buttons in the task bar, even when plasmashell crashes and the user has a specific manual sort order. For now, we use the sort order imposed by the creation time (so the user can affect the sort order simply by ordering the creation of the windows). Once this patch is successful, we can expand sort order storage by storing the manual sort order offset in the X window properties each time that offset changes. This will make plasmashell crashes less damaging to a user who prefers a certain task button sort order (for the duration of the X session). Diffs - libtaskmanager/CMakeLists.txt 9c3e15e libtaskmanager/tasksmodel.cpp bf37042 libtaskmanager/xwindowtasksmodel.h d24a7d5 libtaskmanager/xwindowtasksmodel.cpp c1e9495 Diff: https://git.reviewboard.kde.org/r/128417/diff/ Testing --- Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 Thanks, Xuân Baldauf
Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
> On Juli 10, 2016, 6:42 vorm., Eike Hein wrote: > > New features to libtaskmanager should be implemented on Wayland first. > > Otherwise they increase the porting effort, which I'm not willing to do > > (i.e. I'm not going to take any drive-by feature contributions that leave > > me to figuring out how to make it work on Wayland later). The feature of the current patch works both under X11 and under Wayland (tested with kwin5-5.7.0 based on wayland-1.11.0). No code change (e.g. in file "waylandtasksmodel.cpp") was necessary on the Wayland side to achieve the desired behavior. - Xuân --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/#review97248 --- On Juli 10, 2016, 12:15 vorm., Xuân Baldauf wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128417/ > --- > > (Updated Juli 10, 2016, 12:15 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This is the first step towards not loosing the sort order of the task buttons > in the task bar, even when plasmashell crashes and the user has a specific > manual sort order. For now, we use the sort order imposed by the creation > time (so the user can affect the sort order simply by ordering the creation > of the windows). > > Once this patch is successful, we can expand sort order storage by storing > the manual sort order offset in the X window properties each time that offset > changes. This will make plasmashell crashes less damaging to a user who > prefers a certain task button sort order (for the duration of the X session). > > > Diffs > - > > libtaskmanager/CMakeLists.txt 9c3e15e > libtaskmanager/tasksmodel.cpp bf37042 > libtaskmanager/xwindowtasksmodel.h d24a7d5 > libtaskmanager/xwindowtasksmodel.cpp c1e9495 > > Diff: https://git.reviewboard.kde.org/r/128417/diff/ > > > Testing > --- > > Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 > > > Thanks, > > Xuân Baldauf > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/ --- Review request for Plasma. Repository: plasma-workspace Description --- This is the first step towards not loosing the sort order of the task buttons in the task bar, even when plasmashell crashes and the user has a specific manual sort order. For now, we use the sort order imposed by the creation time (so the user can affect the sort order simply by ordering the creation of the windows). Once this patch is successful, we can expand sort order storage by storing the manual sort order offset in the X window properties each time that offset changes. This will make plasmashell crashes less damaging to a user who prefers a certain task button sort order (for the duration of the X session). Diffs - libtaskmanager/CMakeLists.txt 9c3e15e libtaskmanager/tasksmodel.cpp bf37042 libtaskmanager/xwindowtasksmodel.h d24a7d5 libtaskmanager/xwindowtasksmodel.cpp c1e9495 Diff: https://git.reviewboard.kde.org/r/128417/diff/ Testing --- Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 Thanks, Xuân Baldauf ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
