D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f9d31febf87e: Update the visiblity check for 
ActionToolbar by checking width with less… (authored by xuetianweng).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29022?vs=80690=80697

REVISION DETAIL
  https://phabricator.kde.org/D29022

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml

To: xuetianweng, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29022: Update the check for ActionToolbar by checking with less-"equal".

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  Otherwise some action, especially when there is only one action, it will be
  put in "more" menu even if there is enough space.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29022

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml

To: xuetianweng, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:aa57b34f75f0: Detect QQC2 version at build time with 
actual detection. (authored by xuetianweng).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80646=80647

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  In D28859#652379 , @davidedmundson 
wrote:
  
  > So the problem we're solving is that we want to go
  >
  > Qt5.12 - QQC2.5
  >  Qt5.13 - QQC2.6
  >  Qt5.14 - QQC2.7
  >  Qt5.15 - QQC2.15
  >
  > correct?
  >
  > We now know all Qt5 versions, and we know that Qt6 won't have versions.
  >
  > I don't see why need this complicated thing instead of an "if" statement on 
Qt5QuickControls2_VERSION_MINOR
  
  
  Just to correct it, the change is since 5.12.
  5.11 -> 5.4
  5.12 -> 5.12

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80646.
xuetianweng added a comment.


  Just fix the version by if-else check.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80227=80646

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  ping? :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  In D28859#649191 , @davidedmundson 
wrote:
  
  > I don't understand.
  >
  > We're still running this at compile time, so what's the practical 
difference?
  
  
  The old implement hard-codes it to (minor_version - 7), which is the old 
contract.
  
  This commit message says it will ties the version with minor version. (I 
don't think this will change anymore, because patch version will not introduce 
new API anyway).
  
https://github.com/qt/qtquickcontrols2/commit/3c7bfc156797b2f3ef08a8cf620b79da80e4b061
  
  In order to cover both cases, this code is doing the check simply checking 
minor , minor - 1 until it finds the highest available version.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80227.
xuetianweng added a comment.


  fix header

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80226=80227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt
  detectqqc2version.qml

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: Plasma, rizzitello, davidedmundson, apol, mart.
xuetianweng added a project: Plasma.
Herald added a subscriber: plasma-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  Whenever qqc release a new version the version need to be updated.
  Otherwise the feature is not available to user. This change tries
  to use real qml code to detect the version by creating object until
  success, force to use a minimal qpa platform when running it.

TEST PLAN
  Run the cmake under a env without display server and version is detected
  correctly.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt
  detectqqc2version.qml

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22535: Make kimpanel a system tray applet

[Xuetian Weng]

xuetianweng requested changes to this revision.
xuetianweng added a comment.


  This change doesn't serve any real functionality of kimpanel. It doesn't show 
the current input method in tray, doesn't hide or show up. And kimpanel usually 
consist multiple icons. While it's doubt whether we need that much for certain 
input method (currently user can blacklist some by hand), but being able to 
show some important ones should not be removed. (on windows, there're two icon 
for chinese case).
  
  Also, simply move the existing implementation into expanded tray is not 
acceptable, the layout is not designed for the expanded tray. There is much 
more space in the tray so even if we want to keep the similar ui large icon 
IMHO is prefered.
  
  As for configure, there's already a dbus call in kimpanel for launch the 
configuration, not sure if want to use that to launch kcm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma, xuetianweng
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added a comment.


  Not so sure why phabricator didn't set you as the commit author... sorry 
about that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e2a29f8ea072: Migration request from IBusConfig to 
GSettings (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11061?vs=28920=28964

REVISION DETAIL
  https://phabricator.kde.org/D11061

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added inline comments.

INLINE COMMENTS

> panel.cpp:922
> +impanel_update_engines(impanel, var_engines);
> +if (var_engines)
> +g_variant_unref(var_engines);

https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

Always use braces

> panel.cpp:933
> +impanel_update_triggers(impanel, var_triggers);
> +if (var_triggers)
> +g_variant_unref(var_triggers);

Same as above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng requested changes to this revision.
xuetianweng added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panel.cpp:1049
> +g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, 
> (gpointer)impanel_settings_changed_callback, impanel);
> +g_clear_pointer (>settings_general, g_object_unref);
> +g_clear_pointer (>settings_hotkey, g_object_unref);

I think you can use g_clear_object here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added a comment.


  In D11061#219841 , @davidedmundson 
wrote:
  
  > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem
  
  
  imho, this is pretty irrelevant here.. gsettings is not directly gconf and 
gconf itself is deprecated since gtk3 iirc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added inline comments.

INLINE COMMENTS

> panel.cpp:1031
>  impanel->xkbLayoutManager = new XkbLayoutManager;
> +impanel->settings_general = g_settings_new (IBUS_SCHEMA_GENERAL);
> +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY);

IMHO you need to g_object_unref this two new settings in 
ibus_panel_impanel_destroy.

> panel.cpp:1033
> +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY);
> +g_signal_connect(impanel->settings_general, "changed", G_CALLBACK 
> (impanel_settings_changed_callback), impanel);
> +g_signal_connect(impanel->settings_hotkey, "changed", G_CALLBACK 
> (impanel_settings_changed_callback), impanel);

and disconnect the signal too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10498: Workaround the touchpad toggle button not working

[Xuetian Weng]

xuetianweng accepted this revision.
xuetianweng added a comment.


  I sent the comment before you corrected the diff branch. LGTM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D10498

REVISION DETAIL
  https://phabricator.kde.org/D10498

To: aacid, davidedmundson, xuetianweng
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10498: Workaround the touchpad toggle button not working

[Xuetian Weng]

xuetianweng accepted this revision.
xuetianweng added a comment.
This revision is now accepted and ready to land.


  Oh, ok.. now the diff looks normal.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D10498

REVISION DETAIL
  https://phabricator.kde.org/D10498

To: aacid, davidedmundson, xuetianweng
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10498: Workaround the touchpad toggle button not working

[Xuetian Weng]

xuetianweng added a comment.


  Emm, mind to get rid of the .desktop part for this review?
  
  Also I think you need to give some explanation about why this works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10498

To: aacid, davidedmundson, xuetianweng
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:60bc30083fe4: Plasma change icons should exit after its 
work finished. (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8529?vs=21457=24848

REVISION DETAIL
  https://phabricator.kde.org/D8529

AFFECTED FILES
  kcms/icons/changeicons.cpp

To: xuetianweng, apol, mart, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8529#186000, @broulik wrote:
  
  > Good to go, no?
  
  
  I have no problem with that. Any one have extra comment?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
  
  > Sorry for the long delay on a review.
  >
  > Can you give a short overview on how the switching works between Xlib and 
libinput backend on X? So what's the runtime detection if libinput is available 
or not? Somebody above said mouse kcm is not available without libinput anymore 
with this patch. But this should not happen of course.
  >
  > Naming the config option Pointer Acceleration is problematic, because 
libinput names another property "pointer acceleration". I think we should not 
change the  name. Unneeded deviation from upstream. Maybe better add a tooltip 
with a description if people complain.
  >
  > In the touchpad kcm the backends for libinput and xlib are in different 
files (in the same backend/x11 subfolder). Is this possible here as well?
  
  
  The touchpad's libinput backend is only for wayland. And it also has some 
different code to support xf86-input-libinput under its x11 directory. As I 
said before they are different things.
  
  We haven't get to the point to support wayland in this kcm yet.
  
  If people has better idea about the naming we can change later.. right now, 
we seems to use pointer acceleration for "rate". The profile is more clear.
  
  Also if you check the Mouse navigation tab there's another "acceleration 
profile". I guess that's somewhat matching in the meaning.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec352304d357: Add xf86-input-libinput support for X11 
mouse backend. (authored by xuetianweng).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8798?vs=22774=23472#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8798?vs=22774=23472

REVISION DETAIL
  https://phabricator.kde.org/D8798

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kcmmouse.ui
  kcms/input/mouse.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
  
  > Sorry for the long delay on a review.
  >
  > Can you give a short overview on how the switching works between Xlib and 
libinput backend on X? So what's the runtime detection if libinput is available 
or not? Somebody above said mouse kcm is not available without libinput anymore 
with this patch. But this should not happen of course.
  >
  > Naming the config option Pointer Acceleration is problematic, because 
libinput names another property "pointer acceleration". I think we should not 
change the  name. Unneeded deviation from upstream. Maybe better add a tooltip 
with a description if people complain.
  >
  > In the touchpad kcm the backends for libinput and xlib are in different 
files (in the same backend/x11 subfolder). Is this possible here as well?
  
  
  Well, there's nothing changed for X11 and things only get better. X11 doesn't 
use libinput directly, it uses a xf86 input driver called xf86-input-libinput. 
This change enables the kcm to configure the mouse option using this driver. 
Otherwise, the old kcm does nothing when people use this driver (it means some 
configuration in kcm doesn't work for them).
  
  From the dependency point of view, it only introduce a build time dependency 
on xf86-input-libinput (by using some string macro in it), just like we already 
depend on xf86-input-evdev as build dependency. While it is possible to to 
hardcode those strings directly, I don't feel comfortable doing so because it 
introduces risk of breakage that we will not notice.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  @jriddell ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng marked 3 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#170892, @jriddell wrote:
  
  > This disables the input kcm if libinput x11 plugin is not found.  I expect 
this is fine, it is for ubuntu distros at least, but it might be worth asking 
distros if it causes them a problem.
  
  
  FYI on ubuntu the package is 
https://packages.ubuntu.com/xenial/xserver-xorg-input-libinput-dev .
  
  Actually it only contains some macro string definition, but I would still 
prefer to use the macro from header instead of duplicate them here. After all, 
we're also depending on 
https://packages.ubuntu.com/artful/xserver-xorg-input-evdev-dev . And kwin's 
wayland mode will use libinput anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22774.
xuetianweng added a comment.


  revert the accidentally changed currentIndex in ui file when save in designer.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8798?vs=22543=22774

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kcmmouse.ui
  kcms/input/mouse.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  Whether it shows up reallys depends on your system. Especially when there's 
multiple mouse driver available and you may using evdev.
  
  For example, here's one output on my system, when you see something like 
this, you'll know it's using libinput's xf86 driver. On ubuntu the relavant 
package I found is:
  https://packages.ubuntu.com/artful/xserver-xorg-input-libinput
  
$ xinput list-props 16
Device 'Newmen1100 MOUSE':
   Device Enabled (142):   1
   Coordinate Transformation Matrix (144): 1.00, 0.00, 0.00, 
0.00, 1.00, 0.00, 0.00, 0.00, 1.00
   libinput Natural Scrolling Enabled (285):   0
   libinput Natural Scrolling Enabled Default (286):   0
   libinput Left Handed Enabled (287): 0
   libinput Left Handed Enabled Default (288): 0
   libinput Accel Speed (289): 0.00
   libinput Accel Speed Default (290): 0.00
   libinput Accel Profiles Available (435):1, 1
   libinput Accel Profile Enabled (436):   1, 0
   libinput Accel Profile Enabled Default (437):   1, 0
   libinput Scroll Methods Available (291):0, 0, 1
   libinput Scroll Method Enabled (292):   0, 0, 0
   libinput Scroll Method Enabled Default (293):   0, 0, 0
   libinput Button Scrolling Button (438): 2
   libinput Button Scrolling Button Default (439): 2
   libinput Middle Emulation Enabled (297):0
   libinput Middle Emulation Enabled Default (298):0
   libinput Send Events Modes Available (262): 1, 0
   libinput Send Events Mode Enabled (263):0, 0
   libinput Send Events Mode Enabled Default (264):0, 0
   Device Node (265):  "/dev/input/event17"
   Device Product ID (266):7119, 41
   libinput Drag Lock Buttons (301):   
   libinput Horizontal Scroll Enabled (302):   1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  @apol got a chance to test it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma
Cc: apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#169156, @apol wrote:
  
  > In https://phabricator.kde.org/D8798#169155, @ngraham wrote:
  >
  > >   $ kcmshell5 touchpad
  > >   kcm_touchpad: Using X11 backend
  > >
  > >
  > > The file on disk is at 
`/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so` (on KDE Neon and other 
Ubuntu-based distros)
  >
  >
  > Are you sure? because this is modifying files in kcms/input that creates a 
kcm_input.so... Is it a kcm that extends kcm_touchpad.so?
  
  
  It's called mouse. kcmshell5 mouse

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma
Cc: apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22543.
xuetianweng added a comment.


  Fix based on comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8798?vs=22284=22543

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kcmmouse.ui
  kcms/input/mouse.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8770: Resolve the input method issue by always force focus in search field.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:44d8a7500e36: Resolve the input method issue by always 
force focus in search field. (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8770?vs=22212=22494

REVISION DETAIL
  https://phabricator.kde.org/D8770

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/Header.qml

To: xuetianweng, hein, mart
Cc: ngraham, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:55a8d72e9786: Use heuristic weighted length algorithm to 
calculate the query term length. (authored by xuetianweng).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8771?vs=22289=22290

REVISION DETAIL
  https://phabricator.kde.org/D8771

AFFECTED FILES
  CMakeLists.txt
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp

To: xuetianweng, hein, broulik
Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22289.
xuetianweng marked an inline comment as done.
xuetianweng added a comment.


  Use the new kcoreaddons function to cal the length.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8771?vs=22234=22289

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8771

AFFECTED FILES
  CMakeLists.txt
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp

To: xuetianweng, hein, broulik
Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a reviewer: Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added a reviewer: ngraham.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Added libinput support to X11 backend. It also adds an new option to backend
  which is only available to libinput device currently.

TEST PLAN
  Manually tested and inspect with xinput tool.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kcmmouse.ui
  kcms/input/mouse.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

xuetianweng marked an inline comment as done.
xuetianweng added inline comments.

INLINE COMMENTS

> cfeck wrote in servicerunner.cpp:52
> Since there is no 'else', the length is increased by 3 for Han characters. Is 
> this intended?

Yeah you're right.. I intended to use else here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8771

To: xuetianweng, hein, broulik
Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22234.
xuetianweng added a comment.


  forget to use else..

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8771?vs=22214=22234

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8771

AFFECTED FILES
  runners/services/servicerunner.cpp

To: xuetianweng, hein, broulik
Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22214.
xuetianweng added a comment.


  Revert the accident checking length change. Also make weightedLength linkage 
local.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8771?vs=22213=22214

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8771

AFFECTED FILES
  runners/services/servicerunner.cpp

To: xuetianweng, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: hein, broulik.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Composing CJK character requires a lot more key comparing to latin
  characters. The raw length check does not make much sense for query string
  in CJK characters. Here we use a simple algorithm to query the character
  script property in unicode. If they are belong to CJK, use length 2 instead
  of 1 for the character.

TEST PLAN
  Search "系" (normally requires three key press "x + i + 1" under pinyin) under
  zh_CN in krunner and get some result instead of nothing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8771

AFFECTED FILES
  runners/services/servicerunner.cpp

To: xuetianweng, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8770: Resolve the input method issue by always force focus in search field.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22212.
xuetianweng added a comment.


  revert the reordering of code in unrelated part

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8770?vs=22211=22212

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8770

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/Header.qml

To: xuetianweng, hein, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8770: Resolve the input method issue by always force focus in search field.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: hein, mart.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  ActivityManager.qml doesn't have input method issue because the initial
  focus is inside the text field. So here we try to apply the same logic.
  Always force focus into the text field first, and handle the rest of key
  event accordingly. So we don't need to use event.text to append or do
  anything special, because event.text is not a input method compatible
  way to handle input.

TEST PLAN
  Manually test arrow key navigation. Also test input method typing is enabled
  when menu is opened.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8770

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/Header.qml

To: xuetianweng, hein, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8585: Preserve the order in dbus menu when doing action reusing.

[Xuetian Weng]

xuetianweng added a reviewer: broulik.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8585

To: xuetianweng, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:40f8edd70f4a: Refactor kcm_input to enable having 
multiple backends. (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8460?vs=21675=22108

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/kapplymousetheme.cpp
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Xuetian Weng]

xuetianweng abandoned this revision.
xuetianweng added a comment.


  Being split into small patches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: subdiff, ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng reclaimed this revision.
xuetianweng added a comment.


  .. Sorry click on the wrong one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng abandoned this revision.
xuetianweng added a comment.


  To be split into small patches.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Xuetian Weng]

xuetianweng added a reviewer: Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng added a reviewer: Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8460#161613, @subdiff wrote:
  
  > In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote:
  >
  > > Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will 
only
  > >  get a virtual cursor. Thus I just move the condition to check the name 
of qpa
  > >  platform for now.
  >
  >
  > Can you explain this more? And why is checking the qpa platform name now 
different to the previous check? But I think you're right that the backend is 
not used in the Wayland session. The workaround 

 in KWin reads in the X mouse acceleration directly from the config file.
  
  
  I tested under weston Xwayland's cursor and key mapping can be configured. So 
it does make some sense to use X11 backend on all window system for now. Remove 
the check.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng updated this revision to Diff 21675.
xuetianweng marked 8 inline comments as done.
xuetianweng added a comment.


  Remove backend check so xwayland settings may be changed.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8460?vs=21674=21675

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/kapplymousetheme.cpp
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng added inline comments.

INLINE COMMENTS

> subdiff wrote in mousebackend.h:26
> Put this enum class in a separate file, such that you don't have to include 
> the full mousebackend.h in other header files like mouse.h

I guess I can put it in mousesettings.h ..

> subdiff wrote in mousesettings.h:46
> -> currentAccelProfile

Actually this should be removed for now since I haven't add code to use this 
prop.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng updated this revision to Diff 21674.
xuetianweng marked 11 inline comments as done.
xuetianweng added a comment.


  update based on comments.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8460?vs=21404=21674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/kapplymousetheme.cpp
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Xuetian Weng]

xuetianweng added a comment.


  @mart I understand what you want to say, but for this specific case:
  
  
https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037
  
  rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.
  
  And thus there's no signal that can be used for this function.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: apol, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Right now plasma-iconchanges may remains on the system after change the icon
  theme.

TEST PLAN
  Run plasma-changeicons manually. It does exit and change the icon theme.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8529

AFFECTED FILES
  kcms/icons/changeicons.cpp

To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng updated this revision to Diff 21404.
xuetianweng added a comment.


  Update accroding to subdiff's comment.
  
  Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only
  get a virtual cursor. Thus I just move the condition to check the name of qpa
  platform for now.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8460?vs=21274=21404

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/kapplymousetheme.cpp
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: subdiff, davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Split patch for https://phabricator.kde.org/D8168. This change only refactor 
the X11-related code into
  its own places. KCM itself will only use the backend interface.

TEST PLAN
  Manually test all options.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:987b4dec9264: Port kcm input to UI File. (authored by 
xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8456?vs=21268=21269

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

xuetianweng updated this revision to Diff 21268.
xuetianweng added a comment.


  Merge kmousedlg.ui into kcmmouse.ui.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8456?vs=21262=21268

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: subdiff, davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A split version of https://phabricator.kde.org/D8168. This only refactors the 
hardcoded ui constructor
  into an equilvalent UI file. This change has no string change nor behavior
  change.

TEST PLAN
  Test config opton manually.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.h
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Xuetian Weng]

xuetianweng added a comment.


  ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Xuetian Weng]

xuetianweng retitled this revision from "kcm_input: Refactor the code to enable 
support of multiple backends." to "kcm_input: Refactor the code and add support 
for libinput under X11".
xuetianweng edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Xuetian Weng]

xuetianweng edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code to enable support of multiple backends.

[Xuetian Weng]

xuetianweng updated this revision to Diff 20440.
xuetianweng added a comment.


  using a UI file and add libinput support.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8168?vs=20421=20440

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8168

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.h
  kcms/input/kmousedlg.ui
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.cpp

To: xuetianweng, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code to enable support of multiple backends.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: davidedmundson, mart.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Refactor the code like kcm_touchpad to enable support for different backend.
  Right now we only have X11.

TEST PLAN
  Manually tested on weston and X11.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8168

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8149: Add support for gtk3 theme variant feature.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:59c62319781b: Add support for gtk3 theme variant feature. 
(authored by xuetianweng).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8149?vs=20363=20371

REVISION DETAIL
  https://phabricator.kde.org/D8149

AFFECTED FILES
  Breeze-gtk/gtk-3.0/gtk-dark.css
  Breeze-gtk/gtk-3.18/gtk-dark.css
  Breeze-gtk/gtk-3.20/gtk-dark.css

To: xuetianweng, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8149: Add support for gtk3 theme variant feature.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Gtk3 supports theme variant feature, which allows application to specify
  a variant theme to use.

TEST PLAN
  Test with gtk3-demo -> Application Class, select prefer dark theme, also test
  with GTK_THEME=Breeze:dark

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8149

AFFECTED FILES
  Breeze-gtk/gtk-3.0/gtk-dark.css
  Breeze-gtk/gtk-3.18/gtk-dark.css
  Breeze-gtk/gtk-3.20/gtk-dark.css

To: xuetianweng, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D1075: Display mouse image in mouse kcm properly on highdpi screen

[Xuetian Weng]

xuetianweng abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1075

To: xuetianweng, apol, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7436: kimpanel: change highlight color

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored 
by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7436?vs=18624=18628

REVISION DETAIL
  https://phabricator.kde.org/D7436

AFFECTED FILES
  applets/kimpanel/package/contents/ui/CandidateHighlight.qml
  applets/kimpanel/package/contents/ui/InputPanel.qml

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng added a comment.


  That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D7436

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng updated this revision to Diff 18624.
xuetianweng added a comment.


  Use plasma svg as highlight

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7436?vs=18451=18624

BRANCH
  arcpatch-D7436

REVISION DETAIL
  https://phabricator.kde.org/D7436

AFFECTED FILES
  applets/kimpanel/package/contents/ui/CandidateHighlight.qml
  applets/kimpanel/package/contents/ui/InputPanel.qml

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng commandeered this revision.
xuetianweng added a reviewer: guoyunhe.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: xuetianweng, #plasma, guoyunhe
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

[Xuetian Weng]

xuetianweng added a comment.


  Can you try to make use of PlasmaComponents.Highlight  instead of custom 
highlight like this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7436

To: guoyunhe, #plasma
Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D4879: notifications: Correctly display the file in jobs

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:403b7348e168: notifications: Correctly display the file 
in jobs (authored by xuetianweng).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4879?vs=18412=18413

REVISION DETAIL
  https://phabricator.kde.org/D4879

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml
  dataengines/applicationjobs/kuiserverengine.cpp

To: xuetianweng, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D4879: notifications: Correctly display the file in jobs

[Xuetian Weng]

xuetianweng updated this revision to Diff 18412.
xuetianweng added a comment.


  update based on david's comments.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4879?vs=12041=18412

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4879

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml
  dataengines/applicationjobs/kuiserverengine.cpp

To: xuetianweng, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a0dee59dcf28: Implement the new panel icon size ceiling 
also for Input Method Panel. (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5962?vs=14812=14815

REVISION DETAIL
  https://phabricator.kde.org/D5962

AFFECTED FILES
  applets/kimpanel/package/contents/ui/main.qml

To: xuetianweng, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

[Xuetian Weng]

xuetianweng updated this revision to Diff 14812.
xuetianweng added a comment.


  inPanel is not used.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5962?vs=14811=14812

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5962

AFFECTED FILES
  applets/kimpanel/package/contents/ui/main.qml

To: xuetianweng, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added a project: Plasma.

REVISION SUMMARY
  It was done for various other applets but not this.
  
  BUG:378443

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5962

AFFECTED FILES
  applets/kimpanel/package/contents/ui/main.qml

To: xuetianweng, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5054: Make sure clock in lock screen is displayed within screen

[Xuetian Weng]

xuetianweng abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5054

To: xuetianweng, #plasma, graesslin
Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4996: Fix invalid reference of toolTipArea.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2f5dbfbc1560: Fix invalid reference of toolTipArea. 
(authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4996?vs=12347=12492

REVISION DETAIL
  https://phabricator.kde.org/D4996

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml

To: xuetianweng, hein, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4996: Fix invalid reference of toolTipArea.

[Xuetian Weng]

xuetianweng added a reviewer: Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4996

To: xuetianweng, hein, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5054: Make sure clock in lock screen is displayed within screen

[Xuetian Weng]

xuetianweng created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  On certian screen setup, e.g. 2560x1440 with scale factor 2, the clock
  text will be displayed outside the screen. This change make the clock
  align with the top of the screen instead of use margin and verticalCenter.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D5054

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: xuetianweng, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4996: Fix invalid reference of toolTipArea.

[Xuetian Weng]

xuetianweng updated this revision to Diff 12347.
xuetianweng added a comment.


  fix may be applied to 5.9 branch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4996?vs=12346=12347

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4996

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml

To: xuetianweng, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4996: Fix invalid reference of toolTipArea.

[Xuetian Weng]

xuetianweng created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  When activateTask is called from root Item, it will fail to resolve the
  reference of toolTipArea. This change make toolTipArea a property of Task
  and make activateTask() access it via this property.

TEST PLAN
  Manually test via Meta+number on group item.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4996

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml

To: xuetianweng, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4879: notifications: Correctly display the file in jobs

[Xuetian Weng]

xuetianweng added a comment.
View Revision
In D4879#91745, @mart wrote:

In D4879#91664, @xuetianweng wrote:
(If not, ship this. it seems fine)

Label0 is also used elsewhere. We could add another value to engine though, not sure if worth it.


it's used in the job delegate and as an error message when the transfer fails. maybe having the simple file name is ok in both cases?


I realized this is a generic description field.. not sure if always interpret it as a url is correct..

Are we talking about do the file name parsing in dataengine, and has a separate data field, called labelFileNameN, and keep it update with labelN?REPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4879EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: xuetianweng, martCc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4879: notifications: Correctly display the file in jobs

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D4879#91642, @davidedmundson wrote:
  
  > Label0 comes from the dataengine
  >  We have some nice C++ methods to get a filename from a URL, can we do it 
there?
  >
  > (If not, ship this. it seems fine)
  
  
  Label0 is also used elsewhere. We could add another value to engine though, 
not sure if worth it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4879

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Request, 5 lines] D4879: notifications: Correctly display the file in jobs

[Xuetian Weng]

xuetianweng created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  For url with parameter like audiocd:/1.wav?device=/dev/sr0, the filename
  displayed in notifications applet is not correct ("sr0") instead of 1.wav.
  This commit try to remove the query string before extract the last path
  component.

TEST PLAN
  Manually with audiocd-kio

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4879

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#72924, @graesslin wrote:
  
  > I would say the overall problem is that this here still uses an XLib event 
queue. But Qt uses an xcb connection. I would say this needs a porting away 
from the XLib code and use Qt's XCB connection and event handling.
  
  
  At that time the xinput in xcb is incomplete and buggy so XLib is the only 
choice. Not sure if things change now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71988, @graesslin wrote:
  
  > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote:
  >
  > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
  > >
  > > > Could you explain the relationship to global shortcuts? That sounds to 
me like a bug which needs to be fixed in kglobalaccel
  > >
  > >
  > > I don't really sure about this. So basically XlibNotifications uses 
XISelectEvent to monitor certain event. And strangely, the event is not 
received only if it is triggered by global hotkey.
  >
  >
  > Which "event"?
  
  
  search XIPropertyEvent in xlibnotifications.cpp
  
  For whatever reason, that part of code is not reached if it is triggered by 
global hotkey with current code, the display pointer is not shared with 
anyone.. I really don't understand why adding a new one helps, but it does help.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71724, @knambiar wrote:
  
  > Might this change fix this issue? 
https://bugs.kde.org/show_bug.cgi?id=370588
  
  
  Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to 
confirm it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
  
  > Could you explain the relationship to global shortcuts? That sounds to me 
like a bug which needs to be fixed in kglobalaccel
  
  
  I don't really sure about this. So basically XlibNotifications uses 
XISelectEvent to monitor certain event. And strangely, the event is not 
received only if it is triggered by global hotkey. The Display* used in 
touchpad kded is already a separated one instead of Qt's, so I don't know if 
there's any interference between them. If someone could highlight me about what 
is the real cause of this I'd appreciated it.
  
  My guess is that it could be caused by mix Xinput call on the same display 
and there's some interference.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 31 lines] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng created this revision.
xuetianweng added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  For some reason, the XI event is not received if the change is from
  global shortcut. This makes global shortcut always disable the touchpad
  because kded5 never aware it is disabled. This simple workaround may fix
  it.
  
  CCBUG:370588

TEST PLAN
  Manually test with global shortcut.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3829

AFFECTED FILES
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibnotifications.cpp
  kcms/touchpad/src/backends/x11/xlibnotifications.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng closed this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng updated the summary for this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng updated the summary for this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng added a subscriber: Plasma.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng created this revision.
xuetianweng added reviewers: mart, hein, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  For natgeoprovider, since the page it can be accepted by QXmlStreamReader
  to get required content, we simple parse it as XML (HTML is NOT necessarily
  valid XML).
  
  For noaaprovider, QXmlStreamReader will hit an error in the middle of parsing
  so we use regular expression to extract the url.

TEST PLAN
  Manually test with plasmashell

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

AFFECTED FILES
  CMakeLists.txt
  dataengines/potd/CMakeLists.txt
  dataengines/potd/natgeoprovider.cpp
  dataengines/potd/natgeoprovider.h
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas