Change in plasma-framework[master]: Change string from non-existing %2 to %1.

2015-01-12 Thread Xuetian Weng (Code Review) 
Xuetian Weng has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/318

Change subject: Change string from non-existing %2 to %1.
..

Change string from non-existing %2 to %1.

Change-Id: I52b69a7bd65118c5d0a8dc5bc1649ca0157769d4
CCMAIL:notm...@gmail.com
---
M src/plasma/private/applet_p.cpp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework 
refs/changes/18/318/1

diff --git a/src/plasma/private/applet_p.cpp b/src/plasma/private/applet_p.cpp
index f4eb2c6..dac7eb9 100644
--- a/src/plasma/private/applet_p.cpp
+++ b/src/plasma/private/applet_p.cpp
@@ -135,7 +135,7 @@
 QString api = appletDescription.property("X-Plasma-API").toString();
 
 if (api.isEmpty()) {
-q->setLaunchErrorMessage(i18n("The %2 widget did not define which 
ScriptEngine to use.", appletDescription.name()));
+q->setLaunchErrorMessage(i18n("The %1 widget did not define which 
ScriptEngine to use.", appletDescription.name()));
 return;
 }
 

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/318
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52b69a7bd65118c5d0a8dc5bc1649ca0157769d4
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Xuetian Weng 
Gerrit-Reviewer: Marco Martin 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Change in plasma-framework[master]: save some CPU cycle when busy indicator is not visible.

2014-12-14 Thread Xuetian Weng (Code Review) 
Xuetian Weng has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/240

Change subject: save some CPU cycle when busy indicator is not visible.
..

save some CPU cycle when busy indicator is not visible.

Change-Id: Ia5c296cdbc6c0ccd2ca45444d4f3171723b50d23
---
M src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework 
refs/changes/40/240/1

diff --git a/src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml 
b/src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
index 49021de..44abe4b 100644
--- a/src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
+++ b/src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
@@ -24,6 +24,7 @@
 
 BusyIndicatorStyle {
 indicator: PlasmaCore.SvgItem {
+id: indicatorItem
 svg: PlasmaCore.Svg { imagePath: "widgets/busywidget" }
 elementId: "busywidget"
 
@@ -45,7 +46,7 @@
 from: 0
 to: 360
 duration: 1500
-running: control.running
+running: control.running && indicatorItem.visible && 
indicatorItem.opacity > 0;
 loops: Animation.Infinite
 }
 }

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/240
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5c296cdbc6c0ccd2ca45444d4f3171723b50d23
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Xuetian Weng 
Gerrit-Reviewer: Kai Uwe Broulik 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Change in plasma-framework[master]: fix typo height -> width

2014-12-02 Thread Xuetian Weng (Code Review) 
Xuetian Weng has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/196

Change subject: fix typo height -> width
..

fix typo height -> width

updateMinimumWidth and updateMaximumWidth wrongly set the updated
value to height instead of width.

Change-Id: Ie24ef194d9bf02e53b92aa6802b0fbded68b896d
---
M src/plasmaquick/dialog.cpp
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework 
refs/changes/96/196/1

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index 931068a..1c07ab0 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -326,8 +326,8 @@
 //on the scene
 auto margin = frameSvgItem->fixedMargins();
 int minimumWidth = mainItemLayout->property("minimumWidth").toInt() + 
margin->left() + margin->right();
-q->contentItem()->setHeight(qMax(q->width(), minimumWidth));
-q->setHeight(qMax(q->width(), minimumWidth));
+q->contentItem()->setWidth(qMax(q->width(), minimumWidth));
+q->setWidth(qMax(q->width(), minimumWidth));
 
 hintsCommitTimer.start();
 }
@@ -368,8 +368,8 @@
 
 auto margin = frameSvgItem->fixedMargins();
 int maximumWidth = mainItemLayout->property("maximumWidth").toInt() + 
margin->left() + margin->right();
-q->contentItem()->setHeight(qMax(q->width(), maximumWidth));
-q->setHeight(qMax(q->width(), maximumWidth));
+q->contentItem()->setWidth(qMax(q->width(), maximumWidth));
+q->setWidth(qMax(q->width(), maximumWidth));
 
 hintsCommitTimer.start();
 }

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/196
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie24ef194d9bf02e53b92aa6802b0fbded68b896d
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Xuetian Weng 
Gerrit-Reviewer: Marco Martin 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel