D14949: Add option for whether to show the volume change OSD
anonym removed a reviewer: anonym. anonym added a comment. In D14949#659120 <https://phabricator.kde.org/D14949#659120>, @ngraham wrote: > In fact an option to hide the volume OSD was added in 5.19 already. Sadly I think we all forgot about this patch (sorry about that) but at least it's done now. Thanks for trying, it's appreciated! However, D29263 <https://phabricator.kde.org/D29263> does not solve my problem at all (see D29263#659354 <https://phabricator.kde.org/D29263#659354>). > Further visual improvements to the OSD and reduction in its intrusiveness can be discussed at D20569 <https://phabricator.kde.org/D20569>. I'm sad to say that this experience has made me quite disillusioned about participating further. :( REVISION DETAIL https://phabricator.kde.org/D14949 To: ngraham, #vdg Cc: kori, baberts, alexde, achauvel, amaiga, davidedmundson, filipf, rooty, graesslin, svenmauch, ngraham, romangg, mart, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
D14949: Add option for whether to show the volume change OSD
anonym added a comment. In D14949#335721 <https://phabricator.kde.org/D14949#335721>, @graesslin wrote: > It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the rest? For what it's worth: I opened this ticket and sent the patch, and I am not part of the Reddit community. Before I implemented my own fix I searched around for a solution I encountered a plethora of complaints and patches, with Reddit just being a drop in an ocean: - https://sergiorafael.wordpress.com/2017/02/13/disable-kdeplasma-volume-osdpopup/ - https://unix.stackexchange.com/questions/449855/how-to-disable-the-volume-popup-in-kde-plasma-5-13 - https://forums.linuxmint.com/viewtopic.php?t=205707 - http://hipersayanx.blogspot.com/2015/12/disable-volume-and-brightness-osd-in-kde.html (filed a patch for brightness OSD that was rejected: https://bugs.kde.org/show_bug.cgi?id=343962) - https://ubuntuforums.org/showthread.php?t=1198058 - https://www.reddit.com/r/kde/comments/5zyd1a/i_hate_the_new_volume_osd/ (has code to make the OSD into a thin horizontal strip) - https://forum.manjaro.org/t/kde-plasma-problems-volume-control-brightness-adjustment-data-traffic-ltor-layout-solved/21575 - https://forum.antergos.com/topic/6370/annoying-volume-icon-pop-up - https://github.com/Zren/plasma-applets/commit/337b7d11103da11576584bdd605726c38bbbc2f9 - https://forum.kde.org/viewtopic.php?f=88=85544 - https://forum.kde.org/viewtopic.php?f=67=99424 - https://forum.kde.org/viewtopic.php?f=289=153873 - https://bugs.kde.org/show_bug.cgi?id=363983 - https://bugs.kde.org/show_bug.cgi?id=398020 > Do we want to make the product more complicated (yes that's the result of a config option) to please some people on Reddit while at the same time we already have a mechanism to achieve the same? What is this "mechanism" you are talking about? I'm intrigued! REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: filipf, rooty, graesslin, svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D14949: Add option for whether to show the volume change OSD
anonym added a comment. In D14949#312757 <https://phabricator.kde.org/D14949#312757>, @ngraham wrote: > Simply making it smaller wouldn't really help the submitter's use case very much anyway since it would still show up and cover up //something//. Yes; I would be completely happy if the current (size and all) OSD would appear in the periphery of the screen, preferably a corner. So perhaps the missing option is actually a drop-down for the position of the OSD? An ambitious plan would be: - Center: the current OSD. (Default) - Notification Area: shows a thin vertical bar in the Notification Area (so the lower right corner for the default panel). - Top: shows a //very// thin horizontal bar centered at the top edge. - Bottom: like the above. > However I'd be open to making the default appearance configurable, as a small but vocal cohort of people don't seem to like it. Yay! I was trying to not just be another voice by providing an actual patch, but... > That's material for another patch though. ...I won't commit to dig deeper into the OSD subsystem, which this would require. REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D14949: Add option for whether to show the volume change OSD
anonym updated this revision to Diff 40053. anonym added a comment. Got it! I changed: - `volumeAudioFeedback` → `volumeFeedback` (like before) - `volumeOsdFeedback` → `volumeOsd` Ok? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14949?vs=40050=40053 REVISION DETAIL https://phabricator.kde.org/D14949 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/main.qml To: anonym, #vdg Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14949: Add option for whether to show the volume change OSD
anonym created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anonym requested review of this revision. REVISION SUMMARY When watching movies with significant volume differences (i.e. most modern movies) I find myself adjusting the volume a whole lot. Since the volume OSD appears in the middle of the screen I also have to rewind the video. That's just too disruptive (#347123 was not enough), so let's make it possible to disable the OSD completely. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14949 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/main.qml To: anonym Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
