[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment. In https://phabricator.kde.org/D1989#46775, @graesslin wrote: > I would like to see this integrated. But I think a few things need to be done: > > - I would love to see the example you had in your blog post added to tests > - I'm still unhappy about the name KWinQml - it's just not saying what it is. And actually it's not Qml at all. It's a declarative implementation. Might need brainstorming, maybe even broader on the mailinglist. Alright i will do the said things. And regarding the name, how does KWinDeclarative sound to you? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve marked 28 inline comments as done. bdhruve added a comment. Mark comments as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 351 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5781. bdhruve added a comment. Fix keyEvent code for non-X11 platforms. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5755=5781 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment. In https://phabricator.kde.org/D1989#44453, @graesslin wrote: > I just remembered: on X11 one needs to subtract 8 from the key code... The keyEvents are working perfectly now because of the solution you gave. Thank you. :-) Are there any other issues in the code? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 347 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5755. bdhruve added a comment. Added back the keyEvent handling and works perfectly now. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5753=5755 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 328 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5753. bdhruve added a comment. Remove keyEvent handling. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5713=5753 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment. In https://phabricator.kde.org/D1989#44333, @graesslin wrote: > > - KeyPress events to send keys. > > > > However, keyevents are not working as it should, if i press 'a' it types something different. > > might be that this is just not possible to send key events like that. In general QKeyEvent delivers the keysym. That is the scan code translated through the keyboard layout. The nativeSccanCode should have the original value but I would not trust it completely. > > Maybe leave key events out for the moment as an we don't necessarily need key events. Ok, I will remove keyEvent stuff and add to-do item for that. Once that is done are there any issues in this code? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 347 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5713. bdhruve added a comment. Pass different input events from QML to Kwin, - Use mouse hover events to set pointer position. - Mouse press/release events to send pointer button events. - KeyPress events to send keys. However, keyevents are not working as it should, if i press 'a' it types something different. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5389=5713 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added inline comments. INLINE COMMENTS > graesslin wrote in kwinqml.cpp:68 > ideally you don't need to repaint everything, but could just update the > actual changed areas (carried in the damaged signal) I am not much knowledgeable about how to render only specific area in QtQuick, i tried to search for it, but couldn't find anything related to it. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 298 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5389. bdhruve added a comment. - Performed the nullptr check for the buffer attached to the surface. - Removed qDebug() statements. - Fixed coding style. - Fixed issue of only first frame rendering. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5302=5389 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 284 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5302. bdhruve added a comment. - Fixed automatic selection of backend to look for WAYLAND_SOCKET also - Rendering kwin instance - Fixed minor issues. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5014=5302 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake main_wayland.cpp plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment. In https://phabricator.kde.org/D1989#38998, @bdhruve wrote: > In https://phabricator.kde.org/D1989#38844, @graesslin wrote: > > > Looks good now and I think we can look into the next steps: rendering the KWin instance you launch. The launched KWin instance connects to your Wayland server, binds to the Shell and will create a ShellSurface. That you will get through a signal on m_shell - compare wayland_server.cpp:148. I would as a next step try to hook into this and see whether the surface gets created. Once you have that you can look into rendering it. > > > > For that the ShellSurfaceInterface is connected to a SurfaceInterface. The rendering happens on the SurfaceInterface. There's a damaged signal which you should use to trigger a repaint of your QQuickItem. When rendering you can access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can access the buffer as a QImage and just render it. Pretty straight forward - hopefully. But first try to see whether you get the ShellSurface created. If not we need to look into what goes wrong. > > > I've added the slot for checking if surface gets created but signal doesn't get emitted. Would you please show me the way to proceed further now. I am not getting how to proceed further now, can you please help me on this? Also, current confusion i have is, should kwin_wayland nested window appear when i run qmlscene? Because currently it does appear. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment. In https://phabricator.kde.org/D1989#38844, @graesslin wrote: > Looks good now and I think we can look into the next steps: rendering the KWin instance you launch. The launched KWin instance connects to your Wayland server, binds to the Shell and will create a ShellSurface. That you will get through a signal on m_shell - compare wayland_server.cpp:148. I would as a next step try to hook into this and see whether the surface gets created. Once you have that you can look into rendering it. > > For that the ShellSurfaceInterface is connected to a SurfaceInterface. The rendering happens on the SurfaceInterface. There's a damaged signal which you should use to trigger a repaint of your QQuickItem. When rendering you can access the buffer on the SurfaceInterface. If KWin uses KWIN_COMPOSE=Q you can access the buffer as a QImage and just render it. Pretty straight forward - hopefully. But first try to see whether you get the ShellSurface created. If not we need to look into what goes wrong. I've added the slot for checking if surface gets created but signal doesn't get emitted. Would you please show me the way to proceed further now. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 253 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 5014. bdhruve added a comment. Fixed issues mentioned by @graesslin and connect to surfaceCreated. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4972=5014 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 244 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4972. bdhruve added a comment. Fixed issues mentioned by @graesslin. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4932=4972 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland, graesslin Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 242 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4932. bdhruve added a comment. Fixed issues mentioned by @graesslin. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4886=4932 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, #plasma_on_wayland, bshah Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added a comment.
In https://phabricator.kde.org/D1989#38023, @graesslin wrote:
> I would like to see a test case which verifies that it starts the
kwin_wayland instance and terminates it again.
I am not sure on how to add testcase for this?
Here is code I use for testing locally:
import QtQuick 2.0
import org.kde.kwin.app 1.0
Text {
text: "Hello world"
KWinApp {
id: kwin
//socketName:"kwin-emulator-wayland-0"
anchors.fill:parent
Component.onCompleted: kwin.start()
}
}
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 231 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4886. bdhruve added a comment. Fixed code as per mentioned by @bshah. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4848=4886 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland, bshah Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 225 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4848. bdhruve added a comment. Fixed copyright header. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4847=4848 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland, bshah Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 225 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4847. bdhruve added a comment. Fixed issues mentioned by @bshah REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4797=4847 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve added inline comments. INLINE COMMENTS > graesslin wrote in kwinqml.h:34 > instead of using start which needs to be invoked manually, you could also > react on the initialization completed in the QQuickItem I have fixed all other issues, but i am not sure on how to do this? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland Cc: graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 153 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4797. bdhruve added a comment. Fixed issues addressed by @graesslin REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4697=4797 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland Cc: graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 156 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve created this revision. bdhruve added a reviewer: Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This starts Wayland server with some basic interfaces - shm - compositor - seat - shell - output And starts nested kwin_wayland REPOSITORY rKWIN KWin BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES qml/CMakeLists.txt qml/kwinqml/CMakeLists.txt qml/kwinqml/kwinplugin.cpp qml/kwinqml/kwinplugin.h qml/kwinqml/kwinqml.cpp qml/kwinqml/kwinqml.h qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1758: Integrated FakeInput touch events into InputRedirection.
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6cae5f7ab925: Integrated FakeInput touch events into InputRedirection. (authored by bdhruve). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1758?vs=4190=4194 REVISION DETAIL https://phabricator.kde.org/D1758 AFFECTED FILES input.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma, graesslin Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 28 lines] D1758: Integrated FakeInput touch events into InputRedirection.
bdhruve created this revision. bdhruve added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin counterpart for touch event support in Fakeinput interface. REPOSITORY rKWIN KWin BRANCH fakeinput-touch REVISION DETAIL https://phabricator.kde.org/D1758 AFFECTED FILES input.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1672: Add support for touch events in fakeinput protocol and interface.
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND7d460ed00254: Add support for touch events in fakeinput protocol and interface. (authored by bdhruve). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=4089=4093 REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma, bshah, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. Thank you @graesslin and @bshah REPOSITORY rKWAYLAND KWayland BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma, bshah, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31870, @bshah wrote: > Looks good. Output of arc land fake-input-touch: TARGET Landing onto "master", the default target under git. REMOTE Using remote "origin", the default remote under git. FETCH Fetching origin/master... This commit will be landed: - 2d5d5c2 Add support for touch events in fakeinput protocol and interface. Revision 'https://phabricator.kde.org/D1672: Add support for touch events in fakeinput protocol and interface.' has not been accepted. Continue anyway? [y/N] Can i still submit it? REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 280 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve updated this revision to Diff 4089. bdhruve added a comment. Fixed the coding style issue. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=4063=4089 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 283 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve updated this revision to Diff 4063. bdhruve added a comment. Track touchIds and update autotests. (I am not sure if i did correctly or not.) REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=4000=4063 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31141, @graesslin wrote: > In https://phabricator.kde.org/D1672#31140, @bdhruve wrote: > > > In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > > > > > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. > > > > > > Martin, do you prefer this change to be done in this review only or in separate review. > > > I think it would be better to directly integrate it here. Hello, I've understood the problem and how to fix it in theory, but i am not sure on implementation details? For instance, I am not sure on where to track ids? On server side FakeInputInterface, FakeInputDevice or client side in FakeInput? So, can you please help me on this? REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve added a comment. In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. Martin, do you prefer this change to be done in this review only or in separate review. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 254 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve updated this revision to Diff 4000. bdhruve added a comment. Improved autotest REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=3992=4000 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma, graesslin Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 221 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve updated this revision to Diff 3992. bdhruve added a comment. Use position instead of delta in touch motion, and added docs. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=3982=3992 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 205 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve updated this revision to Diff 3982. bdhruve added a comment. Fixed issues mentioned by @graesslin and @bshah REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=3965=3982 BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, Plasma Cc: bshah, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 159 lines] D1672: Add support for touch events in fakeinput protocol and interface.
bdhruve created this revision. bdhruve added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds support for following in fakeinput interface: - touch_down - touch_motion - touch_up - touch_cancel - touch_frame TEST PLAN added autotests passes REPOSITORY rKWAYLAND KWayland BRANCH fake-input-touch REVISION DETAIL https://phabricator.kde.org/D1672 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 9 lines] D1008: [Image Wallpaper] Make color picker visible for all positioning mode.
bdhruve updated this revision to Diff 2436. bdhruve added a comment. Fix issues mentioned by broulik. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1008?vs=2432=2436 REVISION DETAIL https://phabricator.kde.org/D1008 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma Cc: broulik, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 2 lines] D1008: [Image Wallpaper] Make color picker visible for all positioning mode.
bdhruve created this revision. bdhruve added a reviewer: Plasma. bdhruve set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY If user is using svg wallpaper with opaque area, then this allows users to fill opaque area with color. Bug: 351012. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1008 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
