[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Yes, that is certainly a downside. One idea could be to move it into a 
submenu if there are more than X entries (though I'm not sure yet which number 
to choose). The downside of that would be that people who often add and remove 
places might get confused by the context menus jumping between submenu and no 
submenu

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3815

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  To solve the problem of the context menu getting very long: How about putting 
the places in a submenu?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3815

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  We always have to keep in mind that usind multiple layouts is an advanced 
feature used by a minority of users. Therefore, as long as a feature only 
becomes active when there are multiple layouts (and in this case only when 
multiple layouts are used _and_ the login failed), we do not need to worry too 
much about UI clutter.
  For that reason, I don't see mich of an issue with the patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, gregormi, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3756: [Folder View] Add "Restore" from trash option

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Yup, makes sense!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3756

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Great improvements!
  Is the desktop / Activity only shown if
  
  - there are multiple ones and
  - the task manager shows tasks from different ones?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3738

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, #vdg
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 for the patch (I don't think the icon is close enough to the login button 
to be problematic)
  
  Also +1 for disabling "show password" buttons in general via Kiosk

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3616

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: colomar, cfeck, graesslin, subdiff, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3538: Drop resize animation when adding pages

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1, definitely looks better to me (and Jens will love any killed animation, 
anyway ;) )

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Really nice!
  The single thumbnail might be a bit too large, as having large notification 
windows pop up could be irritating. Maybe half the size would be big enough?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I haven't had the chance to play with it and I think we should still have a 
plan B if we get negative feedback on it during beta tests, but the concept as 
it is described in the latest comments makes sense to me.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D3210#62062, @mart wrote:
  
  >
  
  
  
  
  > sorry for the late reply
  >  ok, so if i understood correctly:
  >  I'll remove those 2 options, and have instead both showing the scrollbar 
on hover *and* the scrollbar size depend uniquely for the global enabled state 
of animations?
  
  Yes, that is the idea.
  
  - When animations are off, always show the scrollbar with the same size it 
currently has
  - When animations are on, show the slim scrollbar by default and make it big 
on mouseover
  
  Would that work?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Whoa okay, that is complex...
  Given that I failed to understand what the proposed checkboxes were supposed 
to mean, I fear it will be the same for users.
  Therefore maybe not gibing the option at all is indeed the better solution, 
and your suggestion to turn the feature off when animations are turned off 
makes sense to me as well.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Great feature!
  I just fear that the naming scheme might make it look like the device name is 
the name for the port, like "A microphone called Audio Adapter".
  Maybe naming 
  Port (device name)
  would make it more clear?

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3268

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3302: RFC: [Task Manager] Indicate applications playing audio

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Very useful patch!
  
  The only thing I'm unsure of is the three-second delay. It might be a bit too 
long if some annoying applicaiton suddenly starts blaring sound and the option 
to mute it easily only becomes available after three seconds of torture.
  I think two or maybe even one second might already be enough to keep the icon 
from blinking.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3302

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein, drosca
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote:
  
  >
  
  
  
  
  >> Why do we need both? What happens if one checks the first but not the 
second?
  > 
  > You get a large scrollbar, visible only on mouse-over
  
  So that means it would be completely hidden as long as the mouse is not over 
it? I don't think that was ever the plan, but instead to have an always-visible 
small scrollbar which expands on mouseover.
  
  >> What happens if one checks the second, but not the first?
  > 
  > you get a small scrollbar that is always visible
  
  That would have bad usability due to the small hit area, though, wouldn't it?
  
  >> I fear we might be making things more complicated for users than 
necessary. I see only two useful scenarios:
  >> 
  >> 1. Small scrollbar that expands on mouseover
  >> 2. Always big scrollbar
  > 
  > If we make it so, I am sure there will be some (how many ?) users who will 
ask for the two combinations that I describe above,  and which are not covered 
by your choices 1 or 2.
  >  And IMHO their requests would be as valid as the one covered by 1. or 2.
  
  The other two scenarios would each have usability problems (as described 
above), though. Do we really want users to be able to create their own 
usability problems by making problematic choices?
  
  > Which is why I think "no" option would actually be better.
  >  In other word, either you have 2 checkboxes that cover all four possible 
combinations, or you start to make arbitrary (design based)  choices to reduce 
this number of combinations. Now if you go along that path, you might as well 
leave only one combination. (the one that is the most consistent with the 
design you want for breeze, and that does not reduce functionalities with 
respect to the old design).
  
  It isn't just "design-based" as in "aesthetics-based": The two options I 
described are the ones with the least usability problems. The only reason why I 
tend towards providing an option to switch off the mouseover-effect is that 
some people have problems with animation and therefore want to reduce them as 
much as possible,

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D3210#60602, @mart wrote:
  
  >
  
  
  in this latest version there are 2 checkboxes: "show scrollbar only on mouse 
over" and "small scrollbar" which both defautls to true
  
  Why do we need both? What happens if one checks the first but not the second? 
What happens if one checks the second, but not the first?
  I fear we might be making things more complicated for users than necessary. I 
see only two useful scenarios:
  
  1. Small scrollbar that expands on mouseover
  2. Always big scrollbar

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  If I understood it correctly (that there is only a checkbox "Only show full 
scrollbar on mouse over" added to the config) then that is exactly what I had 
in mind.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  It does make sense to me to give the option to turn the slim scroll bar as 
such on and off. I can imagine some people being uncomfortable with the 
animation on mouseover.
  Being able to configure individual parameters is probably overkill, however.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3156: WIP: Application Menu applet

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Our users will be very happy about this being back!
  I agree that there needs to be some way to access it via keyboard. Pressing 
alt to shift keyboard focus to the menu bar sounds like a good idea, if 
pressing alt again shifts it back to the window content again.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Sorry for not replying earlier.
  There is nothing that speaks against offering this context menu. However, all 
the actions in the context menu must be available in the main UI as well. Due 
to discoverability reasons, context menus must never be the only way to access 
an action.
  So, this patch is good to go, but there needs to be a way to do these things 
without the context menu as well.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2314

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, #plasma, #plasma:_design
Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3011: [SDDM Theme] Show caps lock warning

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 for the change!
  I think the string for failed unlock while capslock is on should be "Login 
failed (Caps lock is on)" though, as the "login failed" part is the more 
important one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3011

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D2957: [SDDM Theme] Offer switching to the user's session if there is one

[colomar (Thomas Pfeiffer)]

colomar added a subscriber: graesslin.
colomar added a comment.


  > Also it really needs to be a config option somewhere. People do multiple 
login. We made LightDM reuse sessions and got tonnes of comments.
  
  @graesslin said he'd prefer to block multiple login with the same user due to 
all the issues it can cause. Can't people who are advanced enough to use 
multiple logins without problems also just go to a VT and start Plasma manually?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2957

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: graesslin, davidedmundson, colomar, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Definitely a good change!
  
  Suggestion as for when to release: One way we could go about it is see 
whether we get bug reports about the current behavior. If users perceive it as 
a bug, we release this as a bugfix, otherwise it goes into 5.9.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2957

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2944: [TabBox] Switch between windows with mouse wheel

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Behavior sounds sensible, wrapping around would make sense, though.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2944

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I've just asked the other VDG members for their take on the font size.
  Since this is not a big issue either way, the patch is fine to go in anyway.
  If the VDG decides we'd like the font to be smaller, it would be nice if it 
could be changed in another patch.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2741

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[colomar (Thomas Pfeiffer)]

colomar added inline comments.

INLINE COMMENTS

> compositing.ui:291
> + This brings performance improvement for e.g. games.
> + The setting can be overruled by window specific rules.
> + 

window-specific

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: sebas, broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2753#51248, @broulik wrote:
  
  > Because that's an idea Martin and I had a while ago iirc. And also I don't 
see how we could make this one scrolling page, since it's a QML thing with a 
ScrollView embedded in a widget environment.
  
  
  Then I'd recommend using the tabs for now, and then with the next iteration 
reimplement the whole KCM in QML(and not having the wallpaper selection in its 
own scroll view, but putting it all on one big page that scrolls.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2753

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2753#51234, @mart wrote:
  
  > as far i know the guidelines for new kcms are no tabs?
  
  
  Indeed the idea was to use a longer, scrolling page instead of tabs, combined 
with expanding sections for advanced settings.
  
  What made you choose tabs, Kai?

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2753

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  There is always still the possibility to use one of the Action Buttons as a 
close button (as shown in the Gallery) if it gets too long to easily swipe away.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  phab/listviewsheet

REVISION DETAIL
  https://phabricator.kde.org/D2580

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #kirigami, #vdg, apol
Cc: colomar, plasma-devel, apol

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  There is always still the possibility to use one of the Action Buttons as a 
close button (as shown in the Gallery) if it gets too long to easily swipe away.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  phab/listviewsheet

REVISION DETAIL
  https://phabricator.kde.org/D2580

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #kirigami, #vdg, apol
Cc: colomar, plasma-devel, apol

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2383#50991, @andreaska wrote:
  
  > ordinary I had more often the problem that the notification stuff is empty 
but I'd like to know what happend in the past.
  >
  > most of the time I see no new notification but I'd like to see the old ones 
(5.7.4) maybe 5.8 change this behavior
  
  
  Why do you want to see them? There is a property for notifications where they 
can be set to be permanent or not.
  Why do you want to see non-permanent notifications from the past? They 
informed about things which are not relevant anymore, otherwise they would be 
set as permanent.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, mck182, #plasma, davidedmundson
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1771#50973, @broulik wrote:
  
  > Can we have something more concise than "Visual feedback (On-Screen 
Display) for status changes not triggered via a graphical user interface". 
Perhaps just "Visual feedback for status changes"?
  
  
  Hm... or maybe give an example? "Visual feedback for status changes such as 
brightness or volume"?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1771

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: colomar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Okay, let's stick with the context menu for now and see if we can find a good 
place in the popup at some point.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, mck182, #plasma, davidedmundson
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Why is the font for the window titles so large? I don't really see much 
benefit from that...

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2741

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2610: Make icon follow styleHints

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  > What you say does make sense, but I'd like to note that in KDE4 they did 
respect the single-/double-click settings (when on the desktop, not in the 
panel), so this can be seen as "regression" in Plasma5.
  
  I'd call it an improvement, actually, because now it makes more sense.
  
  > And I think the problem is that while it is true that they are different 
from folderview icons technically, for a "normal" user they are probably the 
same.
  
  It might be for many, but those who treat a desktop containment like a 
folderview will have that mental model shattered pretty quickly anyway: For 
example, a single click still would not select an icon widget like a file in a 
folderview, because widgets cannot be selected, or clicking on a different 
widget on the desktop might execute an action immediately, which is 
inconsistent again.
  
  If I'd set up Plasma for someone coming from Windows (or any other OS/DE that 
treats the desktop like a file browser), I'd choose the folderview containment 
for them so that they can keep their mental model (which does not contain the 
notion of widgets on the desktop, anyway). If someone chooses the desktop 
containment, there is no way around adapting your mental model.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2610

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: wbauer, colomar, broulik, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2610: Make icon follow styleHints

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  The only raison d'être for "double-click to open" is to be able to select on 
single click. If selecting is not possible (as is the case both in the panel 
and in a desktop containment), there is no reason for opening only on 
double-click (other than consistency with Windows, but an icon widget in a 
Desktop containment is not the same as an icon on the Windows desktop, because 
the Windows desktop behaves like our folderview containment, not like our 
desktop containment).
  
  Therefore, I am clearly against this patch in general. Trying to make things 
in a desktop containment kinda sorta behave like a folderview will only 
introduce more inconsistency and confusion than it prevents.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2610

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: colomar, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2584#48381, @broulik wrote:
  
  > Plasma is the only major desktop environment that still supports a 
non-composited uscase. Unity and Gnome cannot disable it in the first place.
  
  
  Oh, so they just ignore that request from applications completely?
  In that case, we're fine with doing whatever we want ;)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Actually, I'm not really convinced of this. Blocking compositing is done via 
an official, cross-desktop API, isn't it? It's not a KWin-specific feature, 
right?
  If so, then KWin should not go alone in offering this config option. If I'm 
an application developer and have set my application to block compositing, I'd 
expect that to be respected. If most compositors always respect it, but for one 
compositor, it depends on a user setting, this introduces another layer of 
complexity for application developers.
  Knowing our users, some of them will turn this off, knowing it will impact 
performance, but will then still go ahead and file bug reports about a game 
being too slow, or whatever happening because the game developer just expected 
blocking compositing to work, but for those users, it doesn't.
  
  If it's made configurable in all major compositors, then application 
developers at least know that they cannot expect blocking compositing to work. 
If we're the only ones allowing to configure it, it will get messy.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Differential] [Updated] D2524: New User Switcher

[colomar (Thomas Pfeiffer)]

colomar added a project: VDG.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2524

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2523: New lockscreen

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Please tag all diffs with UI changes with VDG to make sure we learn about 
them.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2523

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: colomar, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D2523: New lockscreen

[colomar (Thomas Pfeiffer)]

colomar added a project: VDG.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2523

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Big +1, yay for consistency!

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: colomar, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2449: small utility to create L packages

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2449#46736, @mart wrote:
  
  >
  
  
  
  
  > it's instant save, some pieces couldn't be done differently at the moment
  
  Hm, I think that's a problem.
  
  1. Instant apply is not a common pattern in KDE software at all and therefore 
unexpected
  2. Instant save in an edit field cannot really be done predictably, as the 
user can never tell exactly when it's saved (certainly not with any character 
typed, right?)
  
  Why not just use a save button?
  
  >> - Is it possible to change the thumbnail in there as well?
  > 
  > yes, click on it or drag and drop (when is empty it shows a label telling 
this)
  
  Ah, perfect!

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2449: small utility to create L packages

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Thanks!
  Feedback:
  
  - The lineedits should be made long enough to actually hold the whole content 
(for the comment, maybe a textbox would be better?), because editing in a field 
which is too small for the content is really annoying.
  - How does one save changes?
  - Is it possible to change the thumbnail in there as well?

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2449: small utility to create L packages

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Can you please provide screenshots of the tool? Yes, even developer-centric 
tools should get a UI review ;)

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2448: use dbus interface to switch shell l

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  UI-wise, I'd do it differently.
  Currently, the description of what the checkbox affects and the checkbox 
itself are too far separated, plus it makes it sound like the layout is going 
to be changed even if the checkbox is not checked. Instead what I'd do is, 
below the general description paragraph (above the actual selection), put
  
  [  ] Change the workspace layout to the one in the selected theme
  
  **unchecked** by default, and if it's checked, show directly below
  "Warning: When clicking "Apply", your current workspace layout (including all 
panels and desktop widgets) will be irrevocably lost and changed to the one 
defined in the Look & Feel theme."

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2409: Update Color KCM

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  The KCM looks okay for a first iteration, although for the future, it would 
make more sense to design it like the Look And Feel or Desktop Theme KCMs, with 
a grid of bigger previews instead of list + one big preview.
  What I'd change right now is Config Scheme -> Edit Scheme
  
  For the editor app: The biggest problem is that it still looks and feels like 
a KCM or a config dialog, not like a proper application. That is okay for the 
first iteration, but in the future, it should be turned into a proper 
application layout (with a classical top toolbar, more spacing etc).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Looks great now, thank you for digging into the focus stuff!

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, #plasma, davidedmundson
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I'm glad that you're fixing this inconsistency!
  
  Just for clarification since it can't be seen from the screenshots: In System 
Settings, the full highlight color is only used on the sidebar when it is 
currently focused. When the main window area is focused (initially when the 
sidebar is shown, or when interacting with the main content), the hover 
highlight visualization is used in the sidebar.
  
  Is that the same in your patch?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Shouldn't that button rather be in the popup itself?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mck182
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2219: Add option to enable volume feedback

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Is the feedback only played when there is no other source playing?
  If not, it should be done like that. If you already have something playing, 
it's just annoying to play an additional sound, and does not provide any 
additional info because you notice how loud whatever is playing plays.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2219

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: colomar, sebas, plasma-devel, ali-mohamed, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2212#41489, @drosca wrote:
  
  > > But it takes more than half of my screen !!!
  >
  > Yes, because gridUnit sizing is broken. Here is how it looks on my system 
with patched plasma-framework:
  >  F189452: PDCLXFY.png 
  
  
  This size looks fine.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: colomar, sebas, mart, broulik, drosca, andreaska, mck182, plasma-devel, 
jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2223#41238, @mart wrote:
  
  > if they would auto clear, but still stay for some minutes, i would be fine
  
  
  Even in some minutes, quite a few notifications can pile up in the queue if 
you do lots of operations.
  This would only be acceptable if they could all be collapsed into a single 
notification, but I don't know if that is possible,

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  @mart If you started a file transfer job at some point and now you neither 
have a progress indicator anymore, nor see an error message, what is supposed 
to have happened other than that it succeeded?
  
  Of all the file transfer job, the vast majority will complete successfully 
(hopefully, otherwise we have way bigger problems). Notifying about the success 
at the point it happens makes sense because it shows you "Ah good, now I can 
start working with the files at their destination!". However, long after that 
moment, if you see no indication of failure, you know it succeeded.
  
  Now that the notification queue does what it's supposed to do again in Plasma 
5.7, it's hugely annoying that it fills up with lots of "Coyping finished" 
messages that you have to manually remove although they tell you //nothing// 
you don't already know.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 from me (of course, since it was my request ;) )

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  How about we keep it as one option and only add more fine-grained controls of 
users demand it?
  
  If we want to do fine-grained options right away, it should be hidden behind 
an "Advanced" expander (see 
https://techbase.kde.org/Projects/Usability/HIG/Settings ), since it's only a 
corner-case which can be safely ignored by most users.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: broulik, colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I agree with Martin: Either people want to see an OSD when changing a 
parameter using the keyboard, or they don't. 
  Like Martin, I don't see why someone would want an OSD when changing screen 
brightness with the keyboard, but not when changing volume.
  
  Would it be possible to link to the KCM where OSDs can be configured from the 
volume applet settings? That would make it easier for people who are only 
annoyed by the volume OSD to find the setting...

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2204: [Service Runner] Search through "Comment" as well

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Big +1, both showing and being able to search in the description is crucial 
especially for newer users who have not memorized the often entirely arbitrary 
application names.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, sebas
Cc: colomar, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  > There is one strange thing regarding the behaviour - the sub-item links.
  > 
  > The first problem is that it is not obvious what is clickable and what is 
not - the only hint is a slight change in the background (at least with my 
colour scheme) on hover.
  
  Is that different to how it was before?
  
  > The item itself has an arrow cursor while the sub-items have the 'URL' 
hand, while the hover-highlight highlights the whole item in both cases.
  
  Oh, right, that's not good. I'd make it all use the hand cursor, then.
  
  > It is not obvious what will be opened when something has been clicked. 
Maybe a better approach would be to always open the item's KCM, but to 
preselect the sub-item that has been clicked on in it (instead of only showing 
the sub-item configuration without the ability to switch to another subitem 
without going back).
  
  Oh, I thought that was already the case, at least that's how I'd imagined it. 
Looks like our design specification was not detailed enough here.
  
  So yes, please, make it behave like Ivan said!
  
  > For example, when one clicks 'Workspace Theme' item, it shows the sub-items 
'Look and Feel', 'Desktop theme' ... on the left allowing the user to switch to 
different sub-items.
  > 
  > When one clicks the 'Desktop theme' sub-item link, it opens only the 
desktop theme configuration without other 'Workspace Theme' sub-items on the 
left. Instead, IMO, it should open the whole 'Workspace Theme' configuration, 
but preselect the 'Desktop theme' sub-configuration.
  > 
  > This way, the behaviour of both will be similar enough not to be annoying 
when somebody miss-clicks a sub-item.
  
  Yes, absolutely!

REPOSITORY
  rSYSTEMSETTINGS System Settings

REVISION DETAIL
  https://phabricator.kde.org/D2173

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: colomar, jensreuterberg, ivan, mart, plasma-devel, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Ok. Not spectacularly pretty, of course, but it does the job.
  Good to go from my side!

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2110

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Screenshot, please?

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2110

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2090: [Kickoff] Sort Favorites in-view

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1, good improvement!
  
  I fear that many users won't discover it, but we need a more global solution 
for that problem anyway.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2090

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Hm ok, good point. How do we prevent duplicate play controls, then?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Ah damn you're right, Plasma once again does more than I know ;)
  Back to this review request, though: Shouldn't the application itself handle 
media controls as jump lists?
  Cantata, for example, already does just that. Would it then show playback 
controls twice (which we should really avoid)?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Nice addition!
  However, what I'd like even more to see (in addition) is having a tooltip 
with player controls also on a launcher. Would that be possible as well?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Martin is right, OSDs are not only about keyboard shortcuts.
  
  They are quite difficult to describe clearly without relying on technical 
terms, however.
  
  Maybe "Visual feedback (On-Screen Display) for status changes not triggered 
via a graphical user interface"? 
  I think that's what they all have in common, because things done in the GUI 
should never trigger an OSD.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1771

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: colomar, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1940#35859, @broulik wrote:
  
  > If you drag it to an existing sticky note you'll paste the path to the 
file. I decided against pasting the file contents in this case back when I 
implemented this. This is in the notes applet and affects any drag and drop 
operation to it, not just for this runner.
  >
  >   If you drag a text file to the desktop, it'll create a sticky note with 
the file's contents.
  
  
  Makes sense, all fine from my perspective then!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1940

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Great change, +1 to all the features!
  
  Just a question: What does dragging to a sticky note do?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1940

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Makes sense!

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Where did you take that icon from?
  We have apps/office-calendar and org.kde.plasma.calendar, both of which look 
quite different from this one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1735: Notify about low peripheral batteries (mouse, keyboard)

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 from the usability side, the second wording iteration is indeed an 
improvement!

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1735

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, lueck, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Ah sorry, I overlooked the bug you mentioned.
  Alright, go ahead, then!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1592

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  What's the reason for this feature? Have users complained about the popup?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1592

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1591: [Shell Runner] Add "Run in Terminal" option

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Yup, makes sense!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1591

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Makes sense, and I agree that "notification sounds" is better.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1366

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: broulik, colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1504: [Service Runner] Search for Jump List Actions

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 from the usability side

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1504

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1478#27450, @mck182 wrote:
  
  > So that users may leave long-taking jobs unattended and then click "Open 
folder" on the notification or something once they're back and/or the job is 
done.
  
  
  Ah, right, that makes sense.
  Not grouping them can lead to a quite long list of notifications if someone 
does a lot of file transfer jobs, but that's certainly the lesser of two evils.
  +1 for the change, then!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design, mck182
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Why can we not make it scroll?

REVISION DETAIL
  https://phabricator.kde.org/D1479

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design, mck182
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Why are those notification even persistent in the first place? If a user 
misses the notification, they should notice that the job was finished by the 
fact that it's not running anymore.
  Only errors should be persistent.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, mck182, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1452: Implement volume overdrive

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I know Pavucontrol does the same, but I think this makes it too easy to go 
into overdrive.
  There is a reason why "100%" is not the actual maximum volume you can get out 
of a device.
  I don't want us to be liable for either burst speakers or burst eardrums...
  
  Is there any way we can change the look of the part of the slider that is 
above 100%, like make it red or something? Or any way we can indicate "Hey, do 
this only if you know what you're doing!"

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1443: Applet: Move Application streams with drag and drop

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  All thumbs up from the usability side!

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1443

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1366#25480, @drosca wrote:
  
  > F106811: event-sounds.png 
  >
  > Looks like this (always first in the list). It will need different icon, 
ideas?
  
  
  Event sounds are usually notifications, right? If so, I'd just use the 
notifications icon (preferences-desktop-notification)

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D1366

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I'd change the label to "Copy date/time to clipboard", otherwise it looks 
good!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1350

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, Plasma: Design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

[colomar (Thomas Pfeiffer)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINd847ddf84189: Fix search keywords between Desktop Effects 
KCM and Compositing KCM (authored by colomar).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1326?vs=3163=3167

REVISION DETAIL
  https://phabricator.kde.org/D1326

AFFECTED FILES
  kcmkwin/kwincompositing/kcmkwineffects.desktop
  kcmkwin/kwincompositing/kwincompositing.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma, graesslin
Cc: graesslin, bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 4 lines] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

[colomar (Thomas Pfeiffer)]

colomar retitled this revision from "Fix search keyword "animation speed" 
pointing to the wrong KCM" to "Fix search keywords pointing to the Desktop 
Effects KCM which should point to the Compositing KCM".
colomar updated the summary for this revision.
colomar updated this revision to Diff 3163.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1326?vs=3148=3163

REVISION DETAIL
  https://phabricator.kde.org/D1326

AFFECTED FILES
  kcmkwin/kwincompositing/kcmkwineffects.desktop
  kcmkwin/kwincompositing/kwincompositing.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: graesslin, bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1326#24768, @bshah wrote:
  
  > +1, but OpenGL,XRender,video settings keywords also should move away?
  
  
  Good point! And while we're at it, "compositing" as well.
  I'll do that tomorrow.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[colomar (Thomas Pfeiffer)]

colomar created this revision.
colomar added a reviewer: Plasma.
colomar set the repository for this revision to rKWIN KWin.
colomar added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Searching for "animation speed" now points to the Compositing KCM, where the 
animation speed setting is, instead of the Destkop Effects KCM, where it was 
before.
  Fixes BUG: 361436

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

AFFECTED FILES
  kcmkwin/kwincompositing/kcmkwineffects.desktop
  kcmkwin/kwincompositing/kwincompositing.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1291: Add microphone volume OSD

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I've asked Andreas to create the needed icons, please wait for them to arrive.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1291

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, Plasma: Design
Cc: colomar, elvisangelaccio, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel