[Differential] [Closed] D3991: kstart: Port away from K4AboutData
This revision was automatically updated to reflect the committed changes. Closed by commit R126:da328d6cada1: kstart: Port away from K4AboutData (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3991?vs=9796=9805#toc REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3991?vs=9796=9805 REVISION DETAIL https://phabricator.kde.org/D3991 AFFECTED FILES kstart/kstart.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
[Differential] [Request, 157 lines] D3991: kstart: Port away from K4AboutData
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kstart: Port away from K4AboutData kstart: Remove remaining bits of KDELibs4Support REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D3991 AFFECTED FILES CMakeLists.txt kstart/CMakeLists.txt kstart/kstart.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
[Differential] [Closed] D3734: Search for KF5Kirigami2 instead of KF5Kirigami
This revision was automatically updated to reflect the committed changes. Closed by commit R134:596589da77ec: Search for KF5Kirigami2 instead of KF5Kirigami (authored by heikobecker). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3734?vs=9171=9178 REVISION DETAIL https://phabricator.kde.org/D3734 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D3734: Search for KF5Kirigami2 instead of KF5Kirigami
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY plasma-discover crashes if it isn't present. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D3734 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3701: cmake: Raise KF5 requirement to 5.29.0
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf1dfd4da511: cmake: Raise KF5 requirement to 5.29.0 (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3701?vs=9064=9067 REVISION DETAIL https://phabricator.kde.org/D3701 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 2 lines] D3701: cmake: Raise KF5 requirement to 5.29.0
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At least kwindowsystem-5.29.0 is needed since https://phabricator.kde.org/R120:bbbce3a55e011bd9d3c531cf1537268162e86f9d. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3701 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3478: Port away from KDELibs4Support
This revision was automatically updated to reflect the committed changes. Closed by commit rKGAMMAb1a14d377405: Port away from KDELibs4Support (authored by heikobecker). REPOSITORY rKGAMMA KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3478?vs=8458=8459 REVISION DETAIL https://phabricator.kde.org/D3478 AFFECTED FILES CMakeLists.txt kcmkgamma/CMakeLists.txt kcmkgamma/gammactrl.cpp kcmkgamma/gammactrl.h kcmkgamma/kgamma.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, cfeck Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 22 lines] D3478: Port away from KDELibs4Support
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By - using KPluginFactory instead of the deprecated KGenericFactory - replacing KHBox with QWidget and QHBoxLayout TEST PLAN Builds and works as before. REPOSITORY rKGAMMA KGamma BRANCH master REVISION DETAIL https://phabricator.kde.org/D3478 AFFECTED FILES CMakeLists.txt kcmkgamma/CMakeLists.txt kcmkgamma/gammactrl.cpp kcmkgamma/gammactrl.h kcmkgamma/kgamma.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2781: Use KDE_INSTALL_DATAROOTDIR
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI3f2db19b3544: Use KDE_INSTALL_DATAROOTDIR (authored by heikobecker). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2781?vs=6748=6766 REVISION DETAIL https://phabricator.kde.org/D2781 AFFECTED FILES examples/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #kirigami, mart Cc: plasma-devel, apol
[Differential] [Request, 2 lines] D2781: Use KDE_INSTALL_DATAROOTDIR
heikobecker created this revision. heikobecker added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ...instead of hard-coding CMAKE_INSTALL_PREFIX. TEST PLAN Files are installed into the desired location. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2781 AFFECTED FILES examples/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #kirigami, mart Cc: plasma-devel, apol
[Differential] [Closed] D2564: Find KF5Wayland with other frameworks
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfce38e25062f: Find KF5Wayland with other frameworks (authored by heikobecker). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2564?vs=6239=6251 REVISION DETAIL https://phabricator.kde.org/D2564 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, graesslin Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2563: Include KDECompilerSettings earlier to silence cmake warning
This revision was automatically updated to reflect the committed changes. Closed by commit rKDECLITOOLSf24fb29f91fe: Include KDECompilerSettings earlier to silence cmake warning (authored by heikobecker). REPOSITORY rKDECLITOOLS KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2563?vs=6238=6244 REVISION DETAIL https://phabricator.kde.org/D2563 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONfd1b24f202c4: Use KDE_INSTALL_KCONFUPDATEDIR instead of hard-coding CMAKE_INSTALL_PREFIX (authored by heikobecker). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2562?vs=6237=6243 REVISION DETAIL https://phabricator.kde.org/D2562 AFFECTED FILES src/platformtheme/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 7 lines] D2564: Find KF5Wayland with other frameworks
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2564 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 2 lines] D2563: Include KDECompilerSettings earlier to silence cmake warning
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It needs to be placed before find_package(KF5Init) in this case because of KF5InitMacros. Otherwise I still get "CMake Warning (dev) at /usr/host/lib/cmake/KF5Init/KF5InitMacros.cmake:43 (add_executable): Policy CMP0063 is not set: Honor visibility properties for all target" despite the NO_POLICY_SCOPE flag. TEST PLAN Warning disappears, still builds fine. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2563 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX
heikobecker added a reviewer: Plasma. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2562 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 4 lines] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX
heikobecker updated this revision to Diff 6237. heikobecker added a comment. s/DATADIR/KCONFUPDATEDIR/ REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2562?vs=6227=6237 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2562 AFFECTED FILES src/platformtheme/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D2562: Use KDE_INSTALL_DATADIR instead of hard-coding CMAKE_INSTALL_PREFIX
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D2562 AFFECTED FILES src/platformtheme/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps
heikobecker added a comment. In https://phabricator.kde.org/D2377#44495, @sitter wrote: > In https://phabricator.kde.org/D2377#44484, @heikobecker wrote: > > > So I think two Find... modules are also needed or "message..." should stay. > > > Well. No. > > https://cmake.org/cmake/help/v3.0/command/find_package.html > > > Every non-REQUIRED find_package call can be disabled by setting the CMAKE_DISABLE_FIND_PACKAGE_ variable to TRUE. > Well, I understand that but I *really* don't think a message should be shown, that always yields the same result, no matter if it can be disabled via CMAKE_D_F_P_Foo or the packages in question are installed or not. What's the difference to message in that case? Also imagine a user investigating why the two packages don't show up although he has installed them. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D2377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, #plasma, davidedmundson Cc: davidedmundson, heikobecker, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps
heikobecker added a comment. I like packages stating their dependencies (even runtime ones) because that's where I look first as a packager. But if I'm not missing something (maybe a git add?) this change is a bit misleading because they can never be found. So I think two Find... modules are also needed or "message..." should stay. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter Cc: heikobecker, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D1944: Make NetworkManagerQt and BluezQt optional
This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL3257be562b2c: Make NetworkManagerQt and BluezQt optional (authored by heikobecker). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1944?vs=4604=4611 REVISION DETAIL https://phabricator.kde.org/D1944 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt daemon/actions/bundled/CMakeLists.txt daemon/config-powerdevil.h.cmake daemon/powerdevilactionpool.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, broulik, #plasma Cc: jgrulich, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional
heikobecker added a comment. > Yes. What dependencies are causing problems for you? NetworkManager and its dependencies mostly. If I compare the situation to kwin and kscreenlocker, for example, and its hard dependency on wayland there's an obvious benefit and wayland is rather small in size and dependencies. Here I would install a bunch of software I would never use on my desktop and probably would even have to blacklist some parts of it in systemd, before it's started automagically and messes up my normal config (and yes, sadly that happened before). REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, broulik Cc: jgrulich, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional
heikobecker added a comment. In https://phabricator.kde.org/D1944#35784, @broulik wrote: > We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare. Sure, in the end you're the maintainer. > The action checks for whether you're allowed to enable/disable WiFi or else it won't show up. It seems it doesn't check for the existance of such hardware (except if the former implies the latter). This needs to be fixed, @jgrulich That still would require said libraries and their dependencies, wouldn't it? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, broulik Cc: jgrulich, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 61 lines] D1944: Make NetworkManagerQt and BluezQt optional
heikobecker created this revision. heikobecker added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While it is most certainly sensible and helpful on a system equipped with Bluetooth and Wi-Fi hardware, it serves no purpose on a desktop system without these and just pulls in a long chain of unwanted dependencies. TEST PLAN Successfully built with BluezQt and NetworkManagerQt present and missing. REPOSITORY rPOWERDEVIL Powerdevil BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1944 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt daemon/actions/bundled/CMakeLists.txt daemon/config-powerdevil.h.cmake daemon/powerdevilactionpool.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, #plasma, broulik Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D851: Port kded plugin to json metadata
This revision was automatically updated to reflect the committed changes. Closed by commit rKWRITED5fd327369bc6: Port kded plugin to json metadata (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D851?vs=2062=2081#toc REPOSITORY rKWRITED KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D851?vs=2062=2081 REVISION DETAIL https://phabricator.kde.org/D851 AFFECTED FILES CMakeLists.txt kwrited.cpp kwrited.json EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, plasma-devel, arichardson Cc: arichardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 174 lines] D851: Port kded plugin to json metadata
heikobecker updated this revision to Diff 2062. heikobecker added a comment. Used suggested kcoreaddons_add_plugin REPOSITORY rKWRITED KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D851?vs=2058=2062 BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFFECTED FILES CMakeLists.txt kwrited.cpp kwrited.json EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, plasma-devel Cc: arichardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 11 lines] D851: Port kded plugin to json metadata
heikobecker created this revision. heikobecker added a reviewer: plasma-devel. REPOSITORY rKWRITED KWriteD BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFFECTED FILES CMakeLists.txt kwrited.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: heikobecker, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
