D18717: improvements for global shortcuts
trmdi updated this revision to Diff 50978. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50974=50978 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortcuts.cpp app/shortcuts/globalshortcuts.h app/view/view.cpp app/view/view.h shell/package/contents/configuration/pages/BehaviorConfig.qml shell/package/contents/configuration/pages/TasksConfig.qml To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18717: improvements for global shortcuts
trmdi added a comment. In D18717#405084 <https://phabricator.kde.org/D18717#405084>, @mvourlakos wrote: > it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues, > we are ok to commit if the property is moved to Layout I've moved it to Layout, and add a small improvement to the "Behavior> Activate based on position... " checkbox's checked value. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18717: improvements for global shortcuts
trmdi updated this revision to Diff 50974. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50814=50974 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortcuts.cpp app/shortcuts/globalshortcuts.h app/view/view.cpp app/view/view.h shell/package/contents/configuration/pages/BehaviorConfig.qml shell/package/contents/configuration/pages/TasksConfig.qml To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18717: improvements for global shortcuts
trmdi added a comment. In D18717#404861 <https://phabricator.kde.org/D18717#404861>, @mvourlakos wrote: > @trmdi can you confirm me the following for your code ? > > 1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded > 2. When the user changed the isPreferredForShortcuts for first time afterwards [1] is never used again EXCEPT if the user set the property ``` preferredForShortcutsTouched=false ``` > > on its own > > Is this what you wanted to achieve? > > Note: this is important, the preferredForShortcutsTouched property must be moved from universalsettings to layout My code works like this: 1, if the user has never touched the Behavior > Activate... checkbox, Latte would automatically find the best view. (Not only the first time) Yes, this should move to the layout class. 2, once he touched it, latte would remember that, and follow his setting. What do you think? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18717: improvements for global shortcuts
trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 403880 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/settings/universalsettings.cpp app/settings/universalsettings.h app/shortcuts/globalshortcuts.cpp shell/package/contents/configuration/pages/BehaviorConfig.qml To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super
trmdi added a comment. In D18620#404023 <https://phabricator.kde.org/D18620#404023>, @mvourlakos wrote: > @trmdi can you please test latest master for global shortcuts? No problem, I'm testing it, I'll give you feedback if I find anything. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18620 To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super
trmdi marked 2 inline comments as done. trmdi added a comment. In D18620#402845 <https://phabricator.kde.org/D18620#402845>, @mvourlakos wrote: > @trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted... > Meta is also used for showing Application Launcher so the two functionalities could be messed up together. > any ideas? I've been thinking about the Meta behavior. Some ideas: - When the holding action is detected: just show docks with badges and do not activate the App Launcher if users release the Meta key. App Launcher can be activated ONLY IF the holding action is not detected - Only show docks with badges if: press "Meta+`" (for the wayland case, or users don't want to wait to see the badges) or holding Meta is detected. (Currently, if I press a shortcut to activate an item, it will show the badges -> not needed) - Timeout for determining it's a holding action or not should be 1-2s This patch is just a draft, so you should improve it before merging by yourself. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18620 To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super
trmdi updated this revision to Diff 50574. trmdi marked an inline comment as done. trmdi retitled this revision from "Display shortcut badges while holding Super_L" to "Display shortcut badges while holding Super". trmdi edited the summary of this revision. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18620?vs=50569=50574 REVISION DETAIL https://phabricator.kde.org/D18620 AFFECTED FILES CMakeLists.txt README.md app/CMakeLists.txt app/globalshortcuts.cpp app/globalshortcuts.h To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super_L
trmdi updated this revision to Diff 50569. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18620?vs=50564=50569 REVISION DETAIL https://phabricator.kde.org/D18620 AFFECTED FILES CMakeLists.txt README.md app/CMakeLists.txt app/globalshortcuts.cpp app/globalshortcuts.h To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super_L
trmdi added a comment. In D18620#402521 <https://phabricator.kde.org/D18620#402521>, @mvourlakos wrote: > @trmdi > > 1. does it work? any issues? > 2. under wayland did you have any success? 1. It works without any issue with my use case. Not sure other cases. Can you test it ? 2. No, because `KModifierKeyInfo` does not work under wayland: https://bugs.kde.org/show_bug.cgi?id=370454 But I guess when it supports wayland, Latte will work too. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18620 To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18620: Display shortcut badges while holding Super_L
trmdi created this revision. trmdi added reviewers: Latte Dock, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Use `KModifierKeyInfo` to display shortcut badges while holding Super_L BUG: 401768 TEST PLAN Just playing with it. I still don't understand the `GlobalShortcut` class very well, correct me if I make any mistake. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18620 AFFECTED FILES CMakeLists.txt app/CMakeLists.txt app/globalshortcuts.cpp app/globalshortcuts.h To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18258: Wait forever until the lock file can be locked
trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - `timeout = 3000` is a bit short on some computer. Use `timeout = -1` will work for any case. BUG: 401041 TEST PLAN BUG: 401041 is fixed on my computer. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18258 AFFECTED FILES app/main.cpp To: trmdi, mvourlakos Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17073: Do not crop albumArt
trmdi updated this revision to Diff 47876. trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=46007=47876 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml To: trmdi, hein, broulik, ngraham, #vdg Cc: filipf, ndavis, abetts, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D17073: Do not crop albumArt
trmdi added a comment. How about this? I'd send a new patch if it's possible to change 2 things in one patch. F6486761: test.png <https://phabricator.kde.org/F6486761> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: filipf, ndavis, abetts, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D16890: [systemtray] Keep config entries after modifying
trmdi added a comment. In D16890#366015 <https://phabricator.kde.org/D16890#366015>, @anthonyfieroni wrote: > To commit it @mart @broulik ? I think that is not the root cause. You should fix the root cause instead of just a part of it. See my comment on https://bugs.kde.org/show_bug.cgi?id=393630#c25 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham Cc: trmdi, mart, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D17073: Do not crop albumArt
trmdi added a comment. In D17073#364393 <https://phabricator.kde.org/D17073#364393>, @ndavis wrote: > That blur looks nice, but I think the background should be more opaque like the Elisa header background.F6437066: Screenshot_20181122_005432.png <https://phabricator.kde.org/F6437066> Do you want to suggest some numbers ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D17073: Do not crop albumArt
trmdi updated this revision to Diff 46007. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=45950=46007 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml To: trmdi, hein, broulik, ngraham, #vdg Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D17073: Do not crop albumArt
trmdi added a comment. How about this ? F6436415: test.png <https://phabricator.kde.org/F6436415> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D17073: Do not crop albumArt
trmdi created this revision. trmdi added reviewers: hein, broulik, ngraham, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Because: - the standard aspect ratio of `albumImage` is always `1:1` - we should not crop the important part of `albumArt` in some cases. BUG: 401234 TEST PLAN Before: F6435279: Screenshot_20181121_200913.png <https://phabricator.kde.org/F6435279> After: F6435280: Screenshot_20181121_201846.png <https://phabricator.kde.org/F6435280> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml To: trmdi, hein, broulik, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
