[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Breeze] [Bug 339863] full and empty stars are indistinguishable
Quoting jpwhiting, jpwhiting heh kratingpainter takes the rating icon from the theme and changes the image pixels to grayscale manually... jpwhiting strange jpwhiting works I guess, though I would think two opposite icons would be better for accessibility jpwhiting so if gray is the foreground color as it seems in that bug On Sat, Oct 11, 2014 at 12:23 PM, Andrew Lake jamboar...@gmail.com wrote: https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 --- Comment #2 from Bhushan Shah bhus...@gmail.com --- Quoting jpwhiting, jpwhiting heh kratingpainter takes the rating icon from the theme and changes the image pixels to grayscale manually... jpwhiting strange jpwhiting works I guess, though I would think two opposite icons would be better for accessibility jpwhiting so if gray is the foreground color as it seems in that bug On Sat, Oct 11, 2014 at 12:23 PM, Andrew Lake jamboar...@gmail.com wrote: https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 --- Comment #3 from Andrew Lake jamboar...@gmail.com --- Thanks much Bhushan. One option would be to provide a new icon for the non-filled state. The downside is that, except for breeze, no existing icon themes would have this new icon. So I think it might be better to fix the underlying problem in KRatingPainter. My suggestion then is that the product for this bug be changed to frameworks-kwidgetaddons since, as described, the greyscale conversion alone won't produce a difference with any monochrome or greyscale icon sets. Unfortunately, I don't currently have bugzilla permissions to do this. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
