[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2023-09-07 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2018-02-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2018-02-06 Thread andreas
https://bugs.kde.org/show_bug.cgi?id=346972
Bug 346972 depends on bug 339863, which changed state.

Bug 339863 Summary: Full and empty stars are indistinguishable when using an 
icon theme (including Oxygen) that lacks the "rating-unrated" icon
https://bugs.kde.org/show_bug.cgi?id=339863

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-05-01 Thread Myriam Schweingruber
https://bugs.kde.org/show_bug.cgi?id=346972

Myriam Schweingruber myr...@kde.org changed:

   What|Removed |Added

 Depends on||339863

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=346972

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||jamboar...@gmail.com

--- Comment #2 from Andrew Lake jamboar...@gmail.com ---
Fixed in 5.3 (commit 89d85cc3a)

*** This bug has been marked as a duplicate of bug 339863 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Evert Vorster
https://bugs.kde.org/show_bug.cgi?id=346972

--- Comment #1 from Evert Vorster evors...@gmail.com ---
This bug was reported against Amarok with number 346711, but it was claimed
that this is not an Amarok bug, as it works fine in Oxygen theme

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=346972

David Edmundson k...@davidedmundson.co.uk changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #4 from David Edmundson k...@davidedmundson.co.uk ---
kdelibs is still getting releases, 
Christoph is it worth backporting your change?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=346972

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED

--- Comment #6 from Andrew Lake jamboar...@gmail.com ---
Sorry, I maybe should not have marked this as duplicate. Let me explain.

The problem for the Breeze icon theme is that the rating icon was monochrome
black (Icon Grey technically). This was reported earlier against Breeze in bug
339863. During that bug review it was decided to re-assign it to KRatingPainter
and Christopher Feck attempted to update KRatingPainter to improve how it
handles monochrome low-saturation icons.  Unfortunately, despite Christopher's
effort, it somehow didn't work out. So the Breeze icon theme was updated to use
a yellow icon, which is similar to oxygen and so should work similar to Oxygen.

So while the problem is technically RESOLVED-FIXED for Breeze, KRatingPainter
might still have a little trouble with monochrome low-saturation icons until we
figure out why Christopher's patch didn't seem to work.

I'll change this to fixed for Breeze here. Hrvoje Senjan has already re-opened
the KRatingPainter bug 339863. If that bug gets resolved then we can update the
icon theme to take advantage of the fix to provide an even more distinct full
vs empty rating star icon.

Hope this helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972

--- Comment #3 from Christoph Feck cf...@kde.org ---
Amarok is a KDE4 application, so it's not fixed.

*** This bug has been marked as a duplicate of bug 346625 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972

--- Comment #5 from Christoph Feck cf...@kde.org ---
The change apparently does not work :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel