mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > scriptengine_v1.cpp:345 > + // << appletData.property("plugin").toString() > + // << appletData.property("geometry.x").toInteger() * > ScriptEngine::gridUnit() > + // << appletData.property("geometry.y").toInteger() * > ScriptEngine::gridUnit() clear it from dead code > scriptengine_v1.cpp:622 > if (!command.isEmpty()) { > - //if (settings.getSetting(KEMailSettings::ClientTerminal) == > "true") { > - if (false) { > + // if (settings.getSetting(KEMailSettings::ClientTerminal) == > + // "true") { dead code > shellcorona.cpp:392 > > -QString ShellCorona::dumpCurrentLayoutJS() > +QString ShellCorona::dumpCurrentLayoutJS() const > { QByteArray and returning .toUtf8()? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH ivan/separateLookAndFeelLayoutSerialization REVISION DETAIL https://phabricator.kde.org/D2480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas