[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-06-01 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in main_wayland.cpp:449
> That dialog is a separate binary kwin_rules_dialog. Except for the virtual 
> keyboard and wayland debug console I don't think there are any user-facing 
> kwin-internal windows (that are real windows, not counting stuff like close 
> buttons on present windows and so on)

It's as Kai-Uwe says: KWin has no own windows. Everything are external programs 
launched by KWin with a cleaned up environment.

The only input field where KWin accepts input is the dialog for setting a 
shortcut for a window. As KGlobalAccel doesn't support input methods it's not a 
problem either.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-31 Thread broulik (Kai Uwe Broulik) 
broulik added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Ah, ok, I misunderstood that this will inherit by session since I thought 
> kwin start the script exit-with-session.
> 
> But then I still have one minor concern, for any window that actually inside 
> kwin (e.g. right click on title bar -> window specific settings), the input 
> method will be forced to qtvirtualkeyboard. Though I know input method is not 
> commonly being used there, but I don't think that's expected behavior for 
> input method user.

That dialog is a separate binary kwin_rules_dialog. Except for the virtual 
keyboard and wayland debug console I don't think there are any user-facing 
kwin-internal windows (that are real windows, not counting stuff like close 
buttons on present windows and so on)

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-31 Thread xuetianweng (Xuetian Weng) 
xuetianweng added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:449
> I don't understand the concern. The QT_IM_MODULE env variable set here in the 
> code only affects KWin. It is not passed to any other process.
> 
> Setting QT_IM_MODULE env variables will still overwrite everything - except 
> in KWin where the variable is pointless. So nothing changes except by default 
> KWin can now offer a virtual keyboard.

Ah, ok, I misunderstood that this will inherit by session since I thought kwin 
start the script exit-with-session.

But then I still have one minor concern, for any window that actually inside 
kwin (e.g. right click on title bar -> window specific settings), the input 
method will be forced to qtvirtualkeyboard. Though I know input method is not 
commonly being used there, but I don't think that's expected behavior for input 
method user.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-31 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the 
> session I wonder if it will be inherit by the whole desktop session.

I don't understand the concern. The QT_IM_MODULE env variable set here in the 
code only affects KWin. It is not passed to any other process.

Setting QT_IM_MODULE env variables will still overwrite everything - except in 
KWin where the variable is pointless. So nothing changes except by default KWin 
can now offer a virtual keyboard.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-30 Thread xuetianweng (Xuetian Weng) 
xuetianweng added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:449
> > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input 
> > method for Qt.
> 
> That's totally fine in this case. It only affects KWin and KWin doesn't have 
> any text input fields.
> 
> > IMHO for wayland there should be a wayland specific im module that talk to 
> > input method via wl_text.
> 
> QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think 
> that's exactly what you want.
> 
> > And X11 app should use a different QT_IM_MODULE.
> 
> Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all.

Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the 
session I wonder if it will be inherit by the whole desktop session.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-29 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input 
> method for Qt.
> 
> IMHO for wayland there should be  a wayland specific im module that talk to 
> input method via wl_text.
> 
> And X11 app should use a different QT_IM_MODULE.
> 
> FYI: https://fcitx-im.org/wiki/Input_method_related_environment_variables

> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input 
> method for Qt.

That's totally fine in this case. It only affects KWin and KWin doesn't have 
any text input fields.

> IMHO for wayland there should be a wayland specific im module that talk to 
> input method via wl_text.

QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think 
that's exactly what you want.

> And X11 app should use a different QT_IM_MODULE.

Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread mart (Marco Martin) 
mart added a comment.


  +1

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in virtualkeyboard.cpp:291
> Perhaps set ImhSensitiveData | ImhHiddenText ?

No those are already part of the contentHints() and already mapped.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin 
graesslin added a comment.


  F129735: Spectacle.lx1761.png 
  
  Virtual keyboard with some test input in the various supported layouts

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel