[Differential] [Commented On] D1963: Guaring the X11 calls not to appear in a wayland session

2016-06-20 Thread bshah (Bhushan Shah) 
bshah added inline comments.

INLINE COMMENTS

> switcherbackend.cpp:197
>  {
> -if (isReverseTab(m_actionShortcut[ACTION_NAME_PREVIOUS_ACTIVITY])) {
> -switchToActivity(Previous);
> +if (QX11Info::isPlatformX11()) {
> +// If we are on X11, we have all needed features for meta+tab

cache this value, as it is string comparison and impossible to change at 
runtime.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1963

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, sebas, graesslin, bshah
Cc: gladhorn, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1963: Guaring the X11 calls not to appear in a wayland session

2016-06-20 Thread gladhorn (Frederik Gladhorn) 
gladhorn added a comment.


  Guaring seems like a typo to me.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1963

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, sebas, graesslin, bshah
Cc: gladhorn, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel