[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[Alex T]

*colomar added a comment.

  Ah damn you're right, Plasma once again does more than I know ;)
  Back to this review request, though: Shouldn't the application
itself handle media controls as jump lists?
  Cantata, for example, already does just that. Would it then show
playback controls twice (which we should really avoid)?
*



I'm using Plasma 5.7 beta + Frameworks 5.23 + Qt 5.7 on Arch.
Cantata has static media controls on taskbar menu popup, but they don't
work.
Also MPRIS applet with cantata doesn't work well at all.
I can help you debug the problem if you tell me how.
Cheers, 5.7 is THE release i was waiting for.

Alex
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  I'll have a look about supporting NotShowIn for jump list actions, then 
players could hide those actions for Plasma. This key is not explicitly 
mentioned in docs for desktop actions, though. In any case, using static 
desktop actions for media controls is just stupid and an application bug.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Hm ok, good point. How do we prevent duplicate play controls, then?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Static desktop actions, which we use, are dumb static application launchers, 
ie. they cannot express status and worse it would launch an executable which 
then probably communicates through DBus to an existing instance, at which point 
we could just do that directly as we do now with added benefit of working with 
all major players.
  
  As of now I have no concrete plans to add dynamic jump list entries (on Unity 
a running application can associate a menu with a launcher similar to a tray 
icon or global menu) which some players use indeed to provide such controls. 
But we don't support that.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Ah damn you're right, Plasma once again does more than I know ;)
  Back to this review request, though: Shouldn't the application itself handle 
media controls as jump lists?
  Cantata, for example, already does just that. Would it then show playback 
controls twice (which we should really avoid)?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  We already have that.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Nice addition!
  However, what I'd like even more to see (in addition) is having a tooltip 
with player controls also on a launcher. Would that be possible as well?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F160500: Screenshot_20160627_190932.png  
Right clicking a pinned player running in the background with no window
  F160504: Screenshot_20160627_190958.png  
Right clicking a regular player window

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel