[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-22 Thread broulik (Kai Uwe Broulik)
broulik added a comment.


  As I already mentioned this morning I'm not too fond of the idea of locking 
the session for that. But I won't stand in the way of simplifying our codebase 
either. ±0 from me, if we can have an "Unlock" button for password-less 
accounts eventually.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, colomar, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment.


  Big +1, yay for consistency!

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: colomar, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas


[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-22 Thread mart (Marco Martin)
mart added a comment.


  +1 (whis will make it completely modal without being able to see the screen 
behing tough, which i don't think is a big issue)
  
  in any way works on wayland :)

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas


[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-21 Thread Martin Gräßlin
graesslin added a comment.


  > KSldApp::self()->lock(DefaultToSwitchUser)
  
  That won't work on Wayland. There ksmserver is not responsible for the lock 
screen and doesn't interact with KSldApp. Thus I would rather go for adding a 
dedicated call to the org.kde.screensaver DBus interface.
  
  In general: I'm all for it!

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D2525

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas