[Differential] [Commented On] D3923: Make AppstreamQt optional
mak added a comment. In https://phabricator.kde.org/D3923#73574, @anthonyfieroni wrote: > In https://phabricator.kde.org/D3923#73375, @mak wrote: > > > In any case, knowing the distro might be useful to check whether their packaging makes sense ;-) > > > KaOS don't have appstream nor appstreamQt nor Discover (it's a fairly normal when first two are missing) Well, then they should package it? It really has no unusual dependencies, and the only one which isn't available everywhere I checked (libstemmer) can be disabled via a compile-time switch. I am more after the "too many dependencies" claim than after distros not having packaged the library, because the latter is relatively easy to achieve (KaOS could just pull the Arch Linux package). Speaking of Arch Linux: Their package has an unnecessary dependency on protobuf, python2 and intltool. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: anthonyfieroni, huber, hein, mak, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
[Differential] [Commented On] D3923: Make AppstreamQt optional
anthonyfieroni added a comment. In https://phabricator.kde.org/D3923#73375, @mak wrote: > In any case, knowing the distro might be useful to check whether their packaging makes sense ;-) KaOS don't have appstream nor appstreamQt nor Discover (it's a fairly normal when first two are missing) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: anthonyfieroni, huber, hein, mak, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3923: Make AppstreamQt optional
hein added a comment. I'm in principle OK with this patch, but also don't mind the change apol requested if it makes him happier since it's his code. In this context I'd like to mention that I was slightly surprised/miffed that the original change went into Kicker during my vacation without waiting a couple of days for an extra review from the maintainer of the codebase. I know, common ownership, bus numbers, all that good stuff, but personally when I file a review I try to get input from the people I know feel responsible for the long-term health of a particular piece of code, an maybe that would have helped avoid three follow-up reviews to clean things up. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: hein, mak, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3923: Make AppstreamQt optional
mak added a comment. @davidedmundson What do you mean with big dependency chain? libappstream and libappstreamQt depend in total on only libxml2, libyaml, GLib and Qt5Core which pretty much any distro, especially with Plasma on it, should already have anyway. Didn't you use Neon? Or was it Manjaro/Arch? In any case, knowing the distro might be useful to check whether their packaging makes sense ;-) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: mak, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
