[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

2016-07-14 Thread Ivan Čukić
ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:1588
> we use this one
> 
> you've even updated the line that's using it in this very patch.

It is using activityRemoved(QString), not activityRemoved(), It would not 
compile otherwise after the change to Qt5 connect syntax :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

2016-07-14 Thread Ivan Čukić
ivan updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel