[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[sitter (Harald Sitter)]

sitter marked an inline comment as done.
sitter added a comment.


  Dump from IRC
  
  > [12:18]  ochurlaud: why is kcolorschemeeditor a standalone 
application if you don't use it as such?
  >  [12:25]  sitter: It can be used at such
  >  [12:26]  but you might want to access it from the colors kcm, 
and until now, i didn't find a way to reload the kcm after creating a new scheme
  >  [12:27]  maybe i would need to send a DBus signal or 
something...
  >  [12:27]  ochurlaud: so the plan is to not use SchemeEditorDialog 
directly but run the standalone application from the KCM?
  >  [12:28]  sitter, if it  is possible it is the plan
  >  [12:28]  the idea is also that notmart is creating a theme 
creation tool
  >  [12:28]  and a color scheme creation tool would be needed: it 
should finally move to plasma-sdk or something
  >  [12:29]  ah yes, cool then
  >  [12:30]  ochurlaud: also, yeah you'll probably need to send a dbus 
signal to the editor to have it load a different scheme
  >  [12:30]  sitter: well but don't expect it too early... :S
  >  [12:31]  ochurlaud: no no. I was just perplexed by there being an 
application but the application not actually being used by the KCM :)
  >  [12:36]  sitter: see Thomas comments on 
https://phabricator.kde.org/D2409 about the context
  >  [12:36]  Diff 2409 "Update Color KCM" [Closed] 
https://phabricator.kde.org/D2409
  >  [12:36]  It was the first iteration. Now that we have a 
standalone app, we can play with it so that it becomes better without breaking 
the kcm
  >  [12:37]  sitter: ok, then I accept your change, and we'll undo 
the nodisplay (maybe) in next iteration
  >  [12:37]  ochurlaud: right now I think nodisplay is the way to go. 
That being said, I think even with it being a proper application it would be 
weird to have it in the menu. Even if it doesn't look like a KCM anymore, it 
still is effectively a settings app, which we all bundle into systemsettings
  >  [12:38]  but yeah, that's a discussion to be had at a later time

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2478#46347, @sitter wrote:
  
  > Pulling in @ochurlaud
  >
  > The NoDisplay remark from Bhushan got me wondering how the KCM actually 
starts the app. And it turns out that it doesn't.
  >
  >   SchemeEditorDialog* dialog = new SchemeEditorDialog(path, this);
  >   dialog->setModal(true);
  >   dialog->show();
  >   
  >
  > Which is now raising the question why kcolorschemeditor was made a 
standalone application to begin with seeing as it adds no value?
  
  
  I would not put that in no-display but rather so that it goes in the tools or 
something similar

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[sitter (Harald Sitter)]

sitter added a reviewer: ochurlaud.
sitter added a subscriber: ochurlaud.
sitter added a comment.


  Pulling in @ochurlaud
  
  The NoDisplay remark from Bhushan got me wondering how the KCM actually 
starts the app. And it turns out that it doesn't.
  
SchemeEditorDialog* dialog = new SchemeEditorDialog(path, this);
dialog->setModal(true);
dialog->show();
  
  Which is now raising the question why kcolorschemeditor was made a standalone 
application to begin with seeing as it adds no value?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas