Bugs and aktivities

2010-10-14 Thread Mario Fux
Morning

I try to read kde-commits for several projects and after Ivan blogged about 
his most simple patch I tried to find the commit in the mailinglist (strange 
person me, I know). I found it and 2 hours later Aaron sent a patch which IMHO 
could reintroduce the bug, probably.
Ivan: 
--- trunk/KDE/kdelibs/plasma/theme.cpp #1183401:1183402
@@ -666,7 +666,7 @@
 }
 
 // try a compressed svg file in the fallback theme
-path = d-findInTheme(svgzName % QLatin1Char('z'), d-
fallbackThemes[i]);
+path = d-findInTheme(svgName % QLatin1Char('z'), d-
fallbackThemes[i]);
 
 if (path.isEmpty()) {
 // try an uncompressed svg file in the fallback theme

Aaron:
--- trunk/KDE/kdelibs/plasma/theme.cpp #1183474:1183475
@@ -666,7 +666,7 @@
 }
 
 // try a compressed svg file in the fallback theme
-path = d-findInTheme(svgName % QLatin1Char('z'), d-
fallbackThemes[i]);
+path = d-findInTheme(svgzName, d-fallbackThemes[i]);
 
 if (path.isEmpty()) {
 // try an uncompressed svg file in the fallback theme

Am I right or just to naive and still need to learn a lot about programming. I 
did not read the code of these files but just the two patches. I saw the z 
reappearing in Aarons patch which Ivan removed.

Anyway. Thx for patience. Here my other topic: Activities.

Aaron wrote a blog post about activities in KDE and Gnome (which btw already 
has an article on the german pro-linux.de :-). There severel proposed to 
include some default activities.

First I thought: Nice idea, but an activity is more than starting some 
applications. But then the idea convinced me in another area: KDE software 
promotion.

By providing some activities new users get a showcase of our applications in 
different task. E.g. the default Photo management activity opens Digikam (if 
installed of course) and Gwenview, the default Development activity opens 
Kdevelop, Kwrite/Kate and Konsole, the default Multimedia activity opens 
Dragon player, Amarok and Kccd (later PMC ;-).

Another purpose for this default activity are excibition booths and staff and 
new users get informed about this new concept in an easy way as they can 
just start and stop different default activities and see the effect: learning 
by doing.

griits
Mario
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bugs and aktivities

2010-10-14 Thread Aaron J. Seigo
On Thursday, October 14, 2010, Mario Fux wrote:
 I try to read kde-commits for several projects 

cool :)

 +path = d-findInTheme(svgName % QLatin1Char('z'), d-

 +path = d-findInTheme(svgzName, d-fallbackThemes[i]);

these two lines are equivalent. svgzName is svgName + 'z'.

 Aaron wrote a blog post about activities in KDE and Gnome (which btw
 already has an article on the german pro-linux.de :-). There severel
 proposed to include some default activities.

this could make sense ...

of course, the question would be what should the default activities be.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bugs and aktivities

2010-10-14 Thread Ivan Cukic

 Am I right or just to naive and still need to learn a lot about programming. 
 I 
 did not read the code of these files but just the two patches. I saw the z 
 reappearing in Aarons patch which Ivan removed.

Heh, in the beginning, there were two 'z's:

path = d-findInTheme(svgzName % QLatin1Char('z'), d-fallbackThemes[i]);

And I removed the first 'z'

path = d-findInTheme(svgName % QLatin1Char('z'), d-fallbackThemes[i]);

forgetting that there is a variable for that which Aaron fixed

path = d-findInTheme(svgzName, d-fallbackThemes[i]);

Although, if I saw this, the patch wouldn't be as magnificent :)


Cheerio,
Ivan


-- 
Before you talk to me, I should warn you: I am kind of strange

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel