D10362: Swap reveal password button logic

[Björn Feber]

GB_2 added a comment.


  Changed `onClicked` to `onPressedChanged`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10362: Swap reveal password button logic

[Björn Feber]

GB_2 updated this revision to Diff 59081.
GB_2 added a comment.


  Change reveal password button logic

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10362?vs=26701&id=59081

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10362: Swap reveal password button logic

[Chris Rizzitello]

rizzitello added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  In D10362#202592 , 
@elvisangelaccio wrote:
  
  > Would it be possible to implement this feature like in the Windows 10 lock 
screen? (i.e. don't toggle the state; reveal the password only as long as the 
button is pressed). I feel like it would remove the security issue in the first 
place (as there isn't anymore a persistent state where the password can be 
visible).
  
  
  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, #frameworks

D10362: Swap reveal password button logic

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Hmm I don't know, that's a button and a button should tell me what happens 
when I click it (Dolphin is also wrong imho).
  
  Would it be possible to implement this feature like in the Windows 10 lock 
screen? (i.e. don't toggle the state; reveal the password only as long as the 
button is pressed). I feel like it would remove the security issue in the first 
place (as there isn't anymore a persistent state where the password can be 
visible).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg, ngraham
Cc: elvisangelaccio, ngraham, starbuck, plasma-devel, #frameworks, michaelh, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10362: Swap reveal password button logic

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me, consistency is good.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, starbuck, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10362: Swap reveal password button logic

[Star Buck]

starbuck added a comment.


  Dolphin screenshot where "eye crossed out=files hidden":
  
https://user-images.githubusercontent.com/840070/34343479-cdc01690-e984-11e7-8728-2dac1e258c18.png
  
  Would further be also likely more consistent with other toggles in the 
future, like imagined on mobile "wifi crossed out=disabled", etc.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg
Cc: starbuck, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10362: Swap reveal password button logic

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10362: Swap reveal password button logic

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10362: Swap reveal password button logic

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Indicate state, not the action it will have. WHen the password field is empty 
it feels like the password will be shown once I start typing. Also, Dolphin 
does it this way for the "show hidden files" action.

TEST PLAN
  Empty field
  F5697019: Screenshot_20180207_152108.png 

  
  F5697017: Screenshot_20180207_151725.png 

  F5697018: Screenshot_20180207_151729.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart