D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:d435e886d56d: Use Kirgami.ToolBarApplicationHeader instead of the view headers (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10471?vs=27080&id=27200 REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES discover/qml/ApplicationPage.qml discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml discover/qml/DiscoverWindow.qml discover/qml/InstallApplicationButton.qml discover/qml/InstalledPage.qml discover/qml/KirigamiActionBridge.qml discover/qml/SearchPage.qml discover/qml/SourcesPage.qml discover/resources.qrc To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
apol updated this revision to Diff 27080. apol added a comment. Fix the search page REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10471?vs=27034&id=27080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES discover/qml/ApplicationPage.qml discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml discover/qml/DiscoverWindow.qml discover/qml/InstallApplicationButton.qml discover/qml/InstalledPage.qml discover/qml/KirigamiActionBridge.qml discover/qml/SearchPage.qml discover/qml/SourcesPage.qml discover/resources.qrc To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
apol updated this revision to Diff 27034. apol added a comment. Iterate over the applicationpage REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10471?vs=27029&id=27034 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES discover/qml/ApplicationPage.qml discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml discover/qml/DiscoverWindow.qml discover/qml/InstallApplicationButton.qml discover/qml/InstalledPage.qml discover/qml/KirigamiActionBridge.qml discover/qml/SourcesPage.qml discover/resources.qrc To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
apol updated this revision to Diff 27029. apol added a comment. Add missing file REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10471?vs=27021&id=27029 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml discover/qml/DiscoverWindow.qml discover/qml/InstalledPage.qml discover/qml/KirigamiActionBridge.qml discover/qml/SourcesPage.qml discover/resources.qrc To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers
apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the standard Kirigami component as header for Discover. Will need some polishing on the kirigami component but will pay off in the long run. BUG: 385973 REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES discover/qml/ApplicationsListPage.qml discover/qml/BrowsingPage.qml discover/qml/DiscoverWindow.qml discover/qml/InstalledPage.qml discover/qml/SourcesPage.qml discover/resources.qrc To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
