D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here
This revision was automatically updated to reflect the committed changes. Closed by commit R114:cd25c7078ab2: [konsolesession runner] Rename to konsoleprofiles, no sessions here (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10505?vs=27144=27361 REVISION DETAIL https://phabricator.kde.org/D10505 AFFECTED FILES runners/CMakeLists.txt runners/konsoleprofiles/CMakeLists.txt runners/konsoleprofiles/Messages.sh runners/konsoleprofiles/konsoleprofiles.cpp runners/konsoleprofiles/konsoleprofiles.h runners/konsoleprofiles/plasma-runner-konsoleprofiles.desktop runners/konsolesessions/CMakeLists.txt runners/konsolesessions/Messages.sh runners/konsolesessions/konsolesessions.cpp runners/konsolesessions/konsolesessions.desktop runners/konsolesessions/konsolesessions.h To: kossebau, broulik, mart Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH renametokonsoleprofiles REVISION DETAIL https://phabricator.kde.org/D10505 To: kossebau, broulik, mart Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here
kossebau added a subscriber: ltoscano. kossebau added a comment. @ltoscano Some question about the translation catalog which gets renamed here as well, from "plasma_runner_konsolesessions" to "plasma_runner_konsoleprofiles": Plasma 5.12 branch has the konsolesessions.po catalogs because scripty extracts them based on the existing Messages.sh. Just, in that branch this runner is dead code, was not yet ported to Qt5/Plasma5. In master the konsolesessions runner has been ported some days ago. This renaming is a follow-up. In the rename though almost all UI strings have been changed as well (session -> profile), so the old translations will not be useful anyway. So there is a plasma_runner_konsolesessions.pot file for Plasma 5.12 which contains strings which are not used for that branch and also no longer will be useful for master after this rename. What is the best solution here? I would guess it makes sense to remove the Messages.sh from the Plasma 5.12 and you/scripty then simply deleting any existing plasma_runner_konsolesessions.po(t) files from both master and stable. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10505 To: kossebau, broulik Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Possibly because the runner was based on the kate session runner, it used the term "session" across the place. Though actually it is supporting Konsole profiles. REPOSITORY R114 Plasma Addons BRANCH renametokonsoleprofiles REVISION DETAIL https://phabricator.kde.org/D10505 AFFECTED FILES runners/CMakeLists.txt runners/konsoleprofiles/CMakeLists.txt runners/konsoleprofiles/Messages.sh runners/konsoleprofiles/konsoleprofiles.cpp runners/konsoleprofiles/konsoleprofiles.h runners/konsoleprofiles/plasma-runner-konsoleprofiles.desktop runners/konsolesessions/CMakeLists.txt runners/konsolesessions/Messages.sh runners/konsolesessions/konsolesessions.cpp runners/konsolesessions/konsolesessions.desktop runners/konsolesessions/konsolesessions.h To: kossebau, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
