D10510: Fix window pin not showing

2018-02-14 Thread Eike Hein 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:840694cc5bbe: Fix window pin not showing (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10510?vs=27157=27160

REVISION DETAIL
  https://phabricator.kde.org/D10510

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10510: Fix window pin not showing

2018-02-14 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10510

To: hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10510: Fix window pin not showing

2018-02-14 Thread Eike Hein 
hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  showPin oscillates during startup and the prop being null'd
  on destroy() is not sync, so this creates a race condition.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10510

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart