D10513: Fix launching by touchscreen tap
This revision was automatically updated to reflect the committed changes. Closed by commit R119:31bcd0ac9590: Fix launching by touchscreen tap (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10513?vs=27165=27166 REVISION DETAIL https://phabricator.kde.org/D10513 AFFECTED FILES applets/kicker/package/contents/ui/ItemGridView.qml To: hein, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10513: Fix launching by touchscreen tap
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10513 To: hein, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10513: Fix launching by touchscreen tap
hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The mouse handling code relied on onPositionChanged to do setup work prior to onPressed. This is never guaranteed, but it's is likely to happen when using the mouse (since the pointer is usually moved from a panel icon to a delegate elsewhere on screen). In a touchscreen scenario, these odds reverse. The lesson to take away: Never assume onPositionChanged has run before onPressed. BUG:366527 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10513 AFFECTED FILES applets/kicker/package/contents/ui/ItemGridView.qml To: hein, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
