D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b2588104cc56: Place toolbox in the top right corner of 
the screen (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10563?vs=27306=27839

REVISION DETAIL
  https://phabricator.kde.org/D10563

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik added a comment.


  In D10563#209361 , @rikmills wrote:
  
  > In D10563#209359 , 
@davidedmundson wrote:
  >
  > > What xml file? If it's not used, delete it.
  >
  >
  > containments/desktop/package/contents/config/main.xml
  >
  > It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in 
a default setup at least.
  
  
  I mean the toolboxes/desktoptoolbox/contents/config/main.xml - I thought 
that's where the toolbox stores its config but it turns out it just writes them 
to the desktop containment config (which has all the keys of this one). This 
looks wrong to me, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Rik Mills]

rikmills added a comment.


  In D10563#209359 , @davidedmundson 
wrote:
  
  > > what "the toolbox' own xml file is ignored
  >
  > What xml file? If it's not used, delete it.
  
  
  containments/desktop/package/contents/config/main.xml
  
  It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a 
default setup at least.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[David Edmundson]

davidedmundson added a comment.


  > what "the toolbox' own xml file is ignored
  
  What xml file? If it's not used, delete it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> ToolBoxRoot.qml:143
>  function placeToolBox(ts) {
> +// if nothing has been setup yet, determin default position based on 
> layout direction
> +if (!ts) {

'determine'

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: cfeck, rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham added a comment.


  Apparently Kubuntu has been patching this for three years. I only found out 
today...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik added a comment.


  > If and when this goes in, any chance you could land it for 5.12.x?
  
  Strictly speaking, this is a behavior change, feature, not a bugfix per se.
  
  > This would let Kubuntu get rid of a downstream override, and help other 
distros planning to package 5.12.
  
  They could have told us earlier that they're patching it… distros could also 
just apply this patch if they want to.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham added a comment.


  If and when this goes in, any chance you could land it for 5.12.x? This would 
let Kubuntu get rid of a downstream override, and help other distros planning 
to package 5.12.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This moves it out of the way of desktop icons and is also what Plasma 4 did.
  The code is adjusted to mirror the position for right-to-left languages.
  
  BUG: 390038

TEST PLAN
  The last time I tried this I had the toolbox reposition itself topleft again 
when it moved out of the way of a top panel but I cannot reproduce this right 
now, needs some more testing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart