D10571: [AppletAppearance] Remove d QtObject

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5f59b7338949: [AppletAppearance] Remove d QtObject 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10571?vs=27325&id=32984

REVISION DETAIL
  https://phabricator.kde.org/D10571

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: broulik, #plasma, davidedmundson, mart
Cc: apol, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

D10571: [AppletAppearance] Remove d QtObject

[Aleix Pol Gonzalez]

apol added a comment.


  In D10571#219016 , @mart wrote:
  
  > the concern is that now applets have a codepath to access it by going to 
see their parents...
  >  but is something they should never ever do, so good to go for me
  
  
  If this is a concern, these properties can be set on the Timer...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson, mart
Cc: apol, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

D10571: [AppletAppearance] Remove d QtObject

[Marco Martin]

mart accepted this revision.
mart added a comment.


  the concern is that now applets have a codepath to access it by going to see 
their parents...
  but is something they should never ever do, so good to go for me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson, mart
Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10571: [AppletAppearance] Remove d QtObject

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10571: [AppletAppearance] Remove d QtObject

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's not like this is public API or anything.

TEST PLAN
  Saves one QObject per applet.
  Moving applets still works and is saved correctly, no warnings on console.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10571

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart