D10629: Avoid a double emitResult()

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by 
jtamate).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10629?vs=27523=27571

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp
  klipper/clipboardjob.cpp

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik added a comment.


  Okay, nevermind. Go for it then!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate added a comment.


  In D10629#209358 , @broulik wrote:
  
  >
  
  
  I did a objdump -d to be sure:
  
  > dataengines/places/setupdevicejob.cpp
  
  setError is from KJob and it only sets a member value (d->error = errorCode;)
  
  > dataengines/mpris2/playeractionjob.cpp
  
  setErrorText is from KJob also and it only sets a member value (d->errorText 
= errorText;)
  
  > dataengines/applicationjobs/jobaction.cpp
  
  The same as the other two.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik added a comment.


  dataengines/places/setupdevicejob.cpp
  dataengines/mpris2/playeractionjob.cpp
  dataengines/applicationjobs/jobaction.cpp

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate updated this revision to Diff 27523.
jtamate added a comment.


  I haven't found more instances of setResult followed by emitResult.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10629?vs=27456=27523

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp
  klipper/clipboardjob.cpp

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  A quick search through plasma codebase reveals that `setResult` followed by 
`emitResult` is done quite often. Care to fix these, too? :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  double_finish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  ServiceJob::setResult already does a emitResult.
  Discovered with the assert created in https://phabricator.kde.org/D9862

REPOSITORY
  R120 Plasma Workspace

BRANCH
  double_finish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp

To: jtamate, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart