D10773: Port to QmlObjectSharedEngine in all remaining places
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b284265924bd: Port to QmlObjectSharedEngine in all remaining places (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10773?vs=27860=28121 REVISION DETAIL https://phabricator.kde.org/D10773 AFFECTED FILES shell/osd.cpp shell/osd.h shell/shellcorona.cpp shell/shellcorona.h To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10773: Port to QmlObjectSharedEngine in all remaining places
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10773 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10773: Port to QmlObjectSharedEngine in all remaining places
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
OSD, Applet Alternatives, and Interactive Console were still creating their
own QML engine
TEST PLAN
- Changed volume, OSD showed up fine
- Successfully switched to another clock applet
- Brought up interactive console and ran `print("hello")` in it
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10773
AFFECTED FILES
shell/osd.cpp
shell/osd.h
shell/shellcorona.cpp
shell/shellcorona.h
To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
