D10850: Rename wallpaper translation catalogs to follow pattern
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f945ad4bae01: Rename wallpaper translation catalogs to follow pattern (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10850?vs=28087&id=30317 REVISION DETAIL https://phabricator.kde.org/D10850 AFFECTED FILES wallpapers/color/Messages.sh wallpapers/color/contents/ui/config.qml wallpapers/image/CMakeLists.txt wallpapers/image/Messages.sh wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml To: kossebau, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10850: Rename wallpaper translation catalogs to follow pattern
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If you do rename any catalogs please inform kde-i18n-doc so they can move any existing translations REPOSITORY R120 Plasma Workspace BRANCH fixwallpapercatalognames REVISION DETAIL https://phabricator.kde.org/D10850 To: kossebau, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10850: Rename wallpaper translation catalogs to follow pattern
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The wallpaper loading code expects the catalogs to follow the pattern "plasma_wallpaper_" + pluginid. While in config QML the domain needs to be explicitly set using i18nd, as the default textdomain is set to that of the config container, it is not needed in the wallpaper QML. While using a catalog with plasma_applet_* prefix works if setting the domain explicitly, the usage goes against the design of the naming patterns. So to give a good example and also properly marking the usage of the catalog, the names are switched. REPOSITORY R120 Plasma Workspace BRANCH fixwallpapercatalognames REVISION DETAIL https://phabricator.kde.org/D10850 AFFECTED FILES wallpapers/color/Messages.sh wallpapers/color/contents/ui/config.qml wallpapers/image/CMakeLists.txt wallpapers/image/Messages.sh wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml To: kossebau, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
