D10896: Show config selection OSD when display button is pressed
This revision was automatically updated to reflect the committed changes. Closed by commit R104:eacbddd22d99: Show config selection OSD when display button is pressed (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10896?vs=28251&id=28312 REVISION DETAIL https://phabricator.kde.org/D10896 AFFECTED FILES kded/daemon.cpp kded/daemon.h To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: Show config selection OSD when display button is pressed
dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: Show config selection OSD when display button is pressed
sebas updated this revision to Diff 28251. sebas added a comment. - clean up now-dead code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10896?vs=28202&id=28251 BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 AFFECTED FILES kded/daemon.cpp kded/daemon.h To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: Show config selection OSD when display button is pressed
sebas added a comment. OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already there, if that's OK from your POV. As to the other cleanups: Good point, I'll submit an updated version of this patch shortly. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: Show config selection OSD when display button is pressed
dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Hmm, I guess you can now kill `m_buttonTimer`, `m_iteration`, `resetDisplaySwitch()` and `applyGenericConfig()` as well, as those are used exclusively by the config iteration. You probably also want to check if the Selection OSD is already shown, otherwise pressing the Display Button multiple times would create multiple OSDs. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: Show config selection OSD when display button is pressed
ngraham retitled this revision from "show config selection osd when display button is pressed" to "Show config selection OSD when display button is pressed". ngraham edited the summary of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10896: show config selection osd when display button is pressed
sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY This makes the working of the display button much more intuitive. BUG:390096 TEST PLAN Tested with external display plugged in, system behaves as expected REPOSITORY R104 KScreen BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 AFFECTED FILES kded/daemon.cpp To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
