D11028: [media controller applet] Fix JS error on no xesam:url data set

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c7f2d8e7331a: [media controller applet] Fix JS error on 
no xesam:url data set (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11028?vs=28621=28702#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11028?vs=28621=28702

REVISION DETAIL
  https://phabricator.kde.org/D11028

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D11028#218774 , @broulik wrote:
  
  > My approach would have been
  >
  >   var xesamUrl = (metadata["xesam:url"] || "").toString();
  >
  >
  > but this is fine and more understandable for non-JS developers :)
  
  
  It took me years to no longer be a JS developer ;) But never seen this 
pattern before, think this is more nice, so will go for that :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixtoStringfromnull

REVISION DETAIL
  https://phabricator.kde.org/D11028

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  My approach would have been
  
var xesamUrl = (metadata["xesam:url"] || "").toString();
  
  but this is fine and more understandable for non-JS developers :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixtoStringfromnull

REVISION DETAIL
  https://phabricator.kde.org/D11028

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11028: [media controller applet] Fix JS error on no xesam:url data set

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixtoStringfromnull

REVISION DETAIL
  https://phabricator.kde.org/D11028

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart