D11066: Convert EffectView to a QQuickWidget

2018-03-05 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:68a2ec5d6365: Convert EffectView to a QQuickWidget 
(authored by fvogt).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11066?vs=28743&id=28765

REVISION DETAIL
  https://phabricator.kde.org/D11066

AFFECTED FILES
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/main.cpp
  kcmkwin/kwincompositing/model.cpp
  kcmkwin/kwincompositing/model.h

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

2018-03-05 Thread Martin Flöser 
graesslin accepted this revision.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

2018-03-05 Thread Fabian Vogt 
fvogt added a comment.


  I won't land this now to give @graesslin a chance to review this as well.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

2018-03-05 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

To: fvogt, #plasma, graesslin, davidedmundson
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11066: Convert EffectView to a QQuickWidget

2018-03-05 Thread Fabian Vogt 
fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.

REVISION SUMMARY
  The Qt Wayland support for subsurfaces is broken in many ways, producing
  graphical glitches and crashes:
  https://bugreports.qt.io/browse/QTBUG-54888 for instance.
  
  Using a QQuickWidget instead of a QQuickView avoids those issues, with
  the additional benefit of a nicer API.

TEST PLAN
  Opened the KCM with kcmshell and systemsettings, no subsurfaces used
  anymore.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11066

AFFECTED FILES
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/main.cpp
  kcmkwin/kwincompositing/model.cpp
  kcmkwin/kwincompositing/model.h

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart