D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

2018-03-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:152400c1b688: org.freedesktop.PowerManagement.Inhibit 
should only prevent suspend (authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11182?vs=29093=30307

REVISION DETAIL
  https://phabricator.kde.org/D11182

AFFECTED FILES
  daemon/powerdevilfdoconnector.cpp

To: broulik, #plasma, oliverhenshaw, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

2018-03-23 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Given it's relying on other applications being sane, which is generally 
unreliable, maybe it's best to only put this in master.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11182

To: broulik, #plasma, oliverhenshaw, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

2018-03-09 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, oliverhenshaw.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For preventing screen standby or screen locking the 
`org.freedesktop.ScreenSaver.Inhibit` must be used.
  Both calls erroneously did the same.

TEST PLAN
  Started a video in Chrome, got an inhibition for screen and suspend
  Started audio player in Chrome, got an inhibition for suspend only
  Started a download in Chrome, got an inhibition for suspend only
  Started a video in VLC, got an inhibition for screen and suspend

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11182

AFFECTED FILES
  daemon/powerdevilfdoconnector.cpp

To: broulik, #plasma, oliverhenshaw
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart